2009-07-21 02:23:52

by Subrata Modak

Subject: [PATCH 04/06][RESEND] Fix compilation warning for drivers/input/touchscreen/htcpen.c

gcc 4.4.1 generates the following build warning on i386:

CC drivers/input/touchscreen/htcpen.o
drivers/input/touchscreen/htcpen.c:50: warning: 'pnp_ids' defined but not used

Fix this by removing the static keyword when you are actually exporting
that structure. This patch was earlier posted on 14th July 2009:
http://lkml.org/lkml/2009/7/14/362,

Signed-off-by: Subrata Modak<[email protected]>
---

--- a/drivers/input/touchscreen/htcpen.c 2009-05-20 10:40:54.000000000 +0530
+++ b/drivers/input/touchscreen/htcpen.c 2009-07-15 06:15:34.000000000 +0530
@@ -47,7 +47,7 @@ static int invert_y;
module_param(invert_y, bool, 0644);
MODULE_PARM_DESC(invert_y, "If set, Y axis is inverted");

-static struct pnp_device_id pnp_ids[] = {
+struct pnp_device_id pnp_ids[] = {
{ .id = "PNP0cc0" },
{ .id = "" }
};

---
Regards--
Subrata

2009-07-21 05:22:07

by Dmitry Torokhov

Subject: Re: [PATCH 04/06][RESEND] Fix compilation warning for drivers/input/touchscreen/htcpen.c

Hi Subrata,

On Tue, Jul 21, 2009 at 07:53:44AM +0530, Subrata Modak wrote:
> gcc 4.4.1 generates the following build warning on i386:
>
> CC drivers/input/touchscreen/htcpen.o
> drivers/input/touchscreen/htcpen.c:50: warning: 'pnp_ids' defined but not used
>
> Fix this by removing the static keyword when you are actually exporting
> that structure. This patch was earlier posted on 14th July 2009:
> http://lkml.org/lkml/2009/7/14/362,
>
> Signed-off-by: Subrata Modak<[email protected]>

Umm, no, we don't export this particular structure, we are exporting
another structure referencing this. Are you compiling without module
support by any chance?

> ---
>
> --- a/drivers/input/touchscreen/htcpen.c 2009-05-20 10:40:54.000000000 +0530
> +++ b/drivers/input/touchscreen/htcpen.c 2009-07-15 06:15:34.000000000 +0530
> @@ -47,7 +47,7 @@ static int invert_y;
> module_param(invert_y, bool, 0644);
> MODULE_PARM_DESC(invert_y, "If set, Y axis is inverted");
>
> -static struct pnp_device_id pnp_ids[] = {
> +struct pnp_device_id pnp_ids[] = {
> { .id = "PNP0cc0" },
> { .id = "" }
> };
>

--
Dmitry