2009-07-11 09:19:32

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [FIX REQUEST] Need better management for include/linux/*.h

Hello all,

As include/linux/*.h file count is going to reach 1000.

We need to do some better techniques to reduce the number of files and
add some hierarchy levels like sub directories where possible.

Like atmel is not exporting to user-space we can easily do :

include/linux/atmel-mci.h -> include/linux/atmel/mci.h
include/linux/atmel_pdc.h -> include/linux/atmel/pdc.h
include/linux/atmel-pwm-bl.h -> include/linux/atmel/pwm-bl.h
include/linux/atmel_pwm.h -> include/linux/atmel/pwm.h
include/linux/atmel_serial.h -> include/linux/atmel/serial.h
include/linux/atmel-ssc.h -> include/linux/atmel/ssc.h
include/linux/atmel_tc.h -> include/linux/atmel/tc.h

Also these files are not exporting :

include/linux/kvm_host.h -> include/linux/kvm/host.h
include/linux/kvm_para.h -> include/linux/kvm/para.h
include/linux/kvm_types.h -> include/linux/kvm/types.h

Similarly for other files, where possible.

Thanks,
--
JSR



2009-07-12 07:58:46

by Avi Kivity

[permalink] [raw]
Subject: Re: [FIX REQUEST] Need better management for include/linux/*.h

On 07/11/2009 12:18 PM, Jaswinder Singh Rajput wrote:
> Hello all,
>
> As include/linux/*.h file count is going to reach 1000.
>
> We need to do some better techniques to reduce the number of files and
> add some hierarchy levels like sub directories where possible.
>
> Like atmel is not exporting to user-space we can easily do :
>
> include/linux/atmel-mci.h -> include/linux/atmel/mci.h
> include/linux/atmel_pdc.h -> include/linux/atmel/pdc.h
> include/linux/atmel-pwm-bl.h -> include/linux/atmel/pwm-bl.h
> include/linux/atmel_pwm.h -> include/linux/atmel/pwm.h
> include/linux/atmel_serial.h -> include/linux/atmel/serial.h
> include/linux/atmel-ssc.h -> include/linux/atmel/ssc.h
> include/linux/atmel_tc.h -> include/linux/atmel/tc.h
>
> Also these files are not exporting :
>
> include/linux/kvm_host.h -> include/linux/kvm/host.h
> include/linux/kvm_para.h -> include/linux/kvm/para.h
> include/linux/kvm_types.h -> include/linux/kvm/types.h
>
>

IMO a much better move is to place non-ABI files (and the #ifdef KERNEL
parts of ABI files) outside include/linux.


--
error compiling committee.c: too many arguments to function

2009-07-12 08:51:46

by Andi Kleen

[permalink] [raw]
Subject: Re: [FIX REQUEST] Need better management for include/linux/*.h

Jaswinder Singh Rajput <[email protected]> writes:

> Hello all,
>
> As include/linux/*.h file count is going to reach 1000.
>
> We need to do some better techniques to reduce the number of files and
> add some hierarchy levels like sub directories where possible.

Why? 100 or 1000 really doesn't make much difference; in both
cases you cannot easily browse and have to use tab completion.
And I doubt your reorganization would go below 100.

I would just leave it as it is.

-Andi
--
[email protected] -- Speaking for myself only.

2009-07-27 12:00:11

by Haavard Skinnemoen

[permalink] [raw]
Subject: Re: [FIX REQUEST] Need better management for include/linux/*.h

Avi Kivity wrote:
> IMO a much better move is to place non-ABI files (and the #ifdef KERNEL
> parts of ABI files) outside include/linux.

How about adding a new include/soc directory and move them all there
(along with similar header files from other SoC vendors)?

Haavard