2009-09-08 10:16:14

by Jiri Slaby

Subject: [PATCH 1/1] X86: pci quirks, fix pci refcounting

Stanse found a pci reference leak in quirk_amd_nb_node.
Instead of putting nb_ht, there is a put of dev passed as
an argument.

http://stanse.fi.muni.cz/

Signed-off-by: Jiri Slaby <[email protected]>
---
arch/x86/kernel/quirks.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c
index af71d06..6c3b2c6 100644
--- a/arch/x86/kernel/quirks.c
+++ b/arch/x86/kernel/quirks.c
@@ -508,7 +508,7 @@ static void __init quirk_amd_nb_node(struct pci_dev *dev)

pci_read_config_dword(nb_ht, 0x60, &val);
set_dev_node(&dev->dev, val & 7);
- pci_dev_put(dev);
+ pci_dev_put(nb_ht);
}

DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_K8_NB,
--
1.6.3.3

2009-09-09 21:12:15

by Jesse Barnes

Subject: Re: [PATCH 1/1] X86: pci quirks, fix pci refcounting

On Tue, 8 Sep 2009 12:16:18 +0200
Jiri Slaby <[email protected]> wrote:

> Stanse found a pci reference leak in quirk_amd_nb_node.
> Instead of putting nb_ht, there is a put of dev passed as
> an argument.
>
> http://stanse.fi.muni.cz/

Applied to linux-next, thanks.

--
Jesse Barnes, Intel Open Source Technology Center