2009-09-10 08:03:52

by Crane Cai

Subject: [PATCH] I2C: add new AMD SMBus device ID

Add new SMBus device ID for SB900

---
Hi Jean,

We follow your point, new patch submitted, please apply.

Thanks,
- Crane
---

Signed-off-by: Crane Cai <[email protected]>
---
drivers/i2c/busses/i2c-piix4.c | 8 +++++---
include/linux/pci_ids.h | 1 +
2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
index 0249a7d..a75d216 100644
--- a/drivers/i2c/busses/i2c-piix4.c
+++ b/drivers/i2c/busses/i2c-piix4.c
@@ -479,6 +479,7 @@ static struct pci_device_id piix4_ids[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_SMBUS) },
{ PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_SMBUS) },
{ PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS) },
+ { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_SB900_SMBUS) },
{ PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS,
PCI_DEVICE_ID_SERVERWORKS_OSB4) },
{ PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS,
@@ -499,9 +500,10 @@ static int __devinit piix4_probe(struct pci_dev *dev,
{
int retval;

- if ((dev->vendor == PCI_VENDOR_ID_ATI) &&
- (dev->device == PCI_DEVICE_ID_ATI_SBX00_SMBUS) &&
- (dev->revision >= 0x40))
+ if ((dev->vendor == PCI_VENDOR_ID_ATI &&
+ dev->device == PCI_DEVICE_ID_ATI_SBX00_SMBUS &&
+ dev->revision >= 0x40) ||
+ dev->vendor == PCI_VENDOR_ID_AMD)
/* base address location etc changed in SB800 */
retval = piix4_setup_sb800(dev, id);
else
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 73b46b6..0786ccd 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -537,6 +537,7 @@
#define PCI_DEVICE_ID_AMD_8131_BRIDGE 0x7450
#define PCI_DEVICE_ID_AMD_8131_APIC 0x7451
#define PCI_DEVICE_ID_AMD_8132_BRIDGE 0x7458
+#define PCI_DEVICE_ID_AMD_SB900_SMBUS 0x780b
#define PCI_DEVICE_ID_AMD_CS5536_ISA 0x2090
#define PCI_DEVICE_ID_AMD_CS5536_FLASH 0x2091
#define PCI_DEVICE_ID_AMD_CS5536_AUDIO 0x2093
--
1.6.0.4

2009-09-10 11:50:48

by Jean Delvare

Subject: Re: [PATCH] I2C: add new AMD SMBus device ID

Hi Crane,

On Thu, 10 Sep 2009 16:04:27 +0800, Crane Cai wrote:
> Add new SMBus device ID for SB900
>
> ---
> Hi Jean,
>
> We follow your point, new patch submitted, please apply.

Applied, thanks. FYI, I also had to list the SB900 in
Documentation/i2c/busses/i2c-piix4 and drivers/i2c/busses/Kconfig. Next
time, please include these changes in your patch. The completed patch
can be seen at:
ftp://ftp.kernel.org/pub/linux/kernel/people/jdelvare/linux-2.6/jdelvare-i2c/i2c-piix4-add-amd-SB900-smbus-device-id.patch

Will a datasheet for the SB900 be released to the public at some point
in the future? That would be useful for us developers.

Thanks,
--
Jean Delvare
http://khali.linux-fr.org/wishlist.html

2009-09-11 01:14:21

by Crane Cai

Subject: Re: [PATCH] I2C: add new AMD SMBus device ID

Hi Jean,

On Thu, Sep 10, 2009 at 01:50:47PM +0200, Jean Delvare wrote:
> Applied, thanks. FYI, I also had to list the SB900 in
> Documentation/i2c/busses/i2c-piix4 and drivers/i2c/busses/Kconfig. Next
> time, please include these changes in your patch. The completed patch
> can be seen at:
> ftp://ftp.kernel.org/pub/linux/kernel/people/jdelvare/linux-2.6/jdelvare-i2c/i2c-piix4-add-amd-SB900-smbus-device-id.patch
Thanks.
>
> Will a datasheet for the SB900 be released to the public at some point
> in the future? That would be useful for us developers.
Yes, in future.

--
Best Regards,
- Crane