2009-09-13 16:07:45

by Stephen Hemminger

Subject: dca: module load should not be an error message

The message (if it must exist) should not be an error message.
IMHO such messages are useless.

Signed-off-by: Stephen Hemminger <[email protected]>

---
I sent patch for this previously, but it seems to have been ignored.

--- a/drivers/dca/dca-core.c 2009-09-13 09:02:25.896005620 -0700
+++ b/drivers/dca/dca-core.c 2009-09-13 09:02:50.786144428 -0700
@@ -276,7 +276,7 @@ EXPORT_SYMBOL_GPL(dca_unregister_notify)

static int __init dca_init(void)
{
- printk(KERN_ERR "dca service started, version %s\n", DCA_VERSION);
+ pr_info("dca service started, version %s\n", DCA_VERSION);
return dca_sysfs_init();
}

2009-09-13 17:31:45

by Dan Williams

Subject: Re: dca: module load should not be an error message

Stephen Hemminger wrote:
> The message (if it must exist) should not be an error message.
> IMHO such messages are useless.
>
> Signed-off-by: Stephen Hemminger <[email protected]>
>
> ---
> I sent patch for this previously, but it seems to have been ignored.
>

Sorry about that... applied now. There are a couple other messages in
drivers/dma/ioat/dca.c and drivers/dma/ioat/pci.c that can also be
de-clawed. I'll take care of those.

Thanks,
Dan

2009-09-14 15:09:24

by Sosnowski, Maciej

Subject: RE: dca: module load should not be an error message

Williams, Dan J wrote:
> Stephen Hemminger wrote:
>> The message (if it must exist) should not be an error message.
>> IMHO such messages are useless.
>>
>> Signed-off-by: Stephen Hemminger <[email protected]>
>>
>> ---
>> I sent patch for this previously, but it seems to have been ignored.
>>
>
> Sorry about that... applied now. There are a couple other messages in
> drivers/dma/ioat/dca.c and drivers/dma/ioat/pci.c that can also be
> de-clawed. I'll take care of those.
>
> Thanks,
> Dan

Signed-off-by: Maciej Sosnowski <[email protected]>

Thanks,
Maciej-