2009-09-24 13:16:51

by Jaswinder Singh Rajput

Subject: [PATCH] PCI: fix htmldocs pci.c

Fix the following htmldocs warnings:

Warning(drivers/pci/pci.c:2552): No description found for parameter 'dev'
Warning(drivers/pci/pci.c:2552): No description found for parameter 'decode'
Warning(drivers/pci/pci.c:2552): No description found for parameter 'command_bits'
Warning(drivers/pci/pci.c:2552): No description found for parameter 'change_bridge'

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
Cc: Benjamin Herrenschmidt <[email protected]>
Cc: Tiago Vignatti <[email protected]>
Cc: Dave Airlie <[email protected]>
Cc: Jesse Barnes <[email protected]>
Cc: Randy Dunlap <[email protected]>
---
drivers/pci/pci.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 6edecff..67288ec 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -2542,10 +2542,10 @@ int pci_resource_bar(struct pci_dev *dev, int resno, enum pci_bar_type *type)

/**
* pci_set_vga_state - set VGA decode state on device and parents if requested
- * @dev the PCI device
- * @decode - true = enable decoding, false = disable decoding
- * @command_bits PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
- * @change_bridge - traverse ancestors and change bridges
+ * @dev: the PCI device
+ * @decode: true = enable decoding, false = disable decoding
+ * @command_bits: PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
+ * @change_bridge: traverse ancestors and change bridges
*/
int pci_set_vga_state(struct pci_dev *dev, bool decode,
unsigned int command_bits, bool change_bridge)
--
1.6.0.6

2009-09-24 15:54:35

by Randy Dunlap

Subject: Re: [PATCH] PCI: fix htmldocs pci.c

Jaswinder Singh Rajput wrote:
> Fix the following htmldocs warnings:
>
> Warning(drivers/pci/pci.c:2552): No description found for parameter 'dev'
> Warning(drivers/pci/pci.c:2552): No description found for parameter 'decode'
> Warning(drivers/pci/pci.c:2552): No description found for parameter 'command_bits'
> Warning(drivers/pci/pci.c:2552): No description found for parameter 'change_bridge'
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>

Ack, but already sent to Jesse & linux-pci mailing list.

> Cc: Benjamin Herrenschmidt <[email protected]>
> Cc: Tiago Vignatti <[email protected]>
> Cc: Dave Airlie <[email protected]>
> Cc: Jesse Barnes <[email protected]>
> Cc: Randy Dunlap <[email protected]>
> ---
> drivers/pci/pci.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 6edecff..67288ec 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -2542,10 +2542,10 @@ int pci_resource_bar(struct pci_dev *dev, int resno, enum pci_bar_type *type)
>
> /**
> * pci_set_vga_state - set VGA decode state on device and parents if requested
> - * @dev the PCI device
> - * @decode - true = enable decoding, false = disable decoding
> - * @command_bits PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
> - * @change_bridge - traverse ancestors and change bridges
> + * @dev: the PCI device
> + * @decode: true = enable decoding, false = disable decoding
> + * @command_bits: PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
> + * @change_bridge: traverse ancestors and change bridges
> */
> int pci_set_vga_state(struct pci_dev *dev, bool decode,
> unsigned int command_bits, bool change_bridge)

2009-09-25 09:49:56

by Tiago Vignatti

Subject: Re: [PATCH] PCI: fix htmldocs pci.c

On Thu, Sep 24, 2009 at 05:54:15PM +0200, ext Randy Dunlap wrote:
> Jaswinder Singh Rajput wrote:
> > Fix the following htmldocs warnings:
> >
> > Warning(drivers/pci/pci.c:2552): No description found for parameter 'dev'
> > Warning(drivers/pci/pci.c:2552): No description found for parameter 'decode'
> > Warning(drivers/pci/pci.c:2552): No description found for parameter 'command_bits'
> > Warning(drivers/pci/pci.c:2552): No description found for parameter 'change_bridge'
> >
> > Signed-off-by: Jaswinder Singh Rajput <[email protected]>
>
> Ack, but already sent to Jesse & linux-pci mailing list.

got my Ack also.

> > Cc: Benjamin Herrenschmidt <[email protected]>
> > Cc: Tiago Vignatti <[email protected]>
> > Cc: Dave Airlie <[email protected]>
> > Cc: Jesse Barnes <[email protected]>
> > Cc: Randy Dunlap <[email protected]>
> > ---
> > drivers/pci/pci.c | 8 ++++----
> > 1 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> > index 6edecff..67288ec 100644
> > --- a/drivers/pci/pci.c
> > +++ b/drivers/pci/pci.c
> > @@ -2542,10 +2542,10 @@ int pci_resource_bar(struct pci_dev *dev, int resno, enum pci_bar_type *type)
> >
> > /**
> > * pci_set_vga_state - set VGA decode state on device and parents if requested
> > - * @dev the PCI device
> > - * @decode - true = enable decoding, false = disable decoding
> > - * @command_bits PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
> > - * @change_bridge - traverse ancestors and change bridges
> > + * @dev: the PCI device
> > + * @decode: true = enable decoding, false = disable decoding
> > + * @command_bits: PCI_COMMAND_IO and/or PCI_COMMAND_MEMORY
> > + * @change_bridge: traverse ancestors and change bridges
> > */
> > int pci_set_vga_state(struct pci_dev *dev, bool decode,
> > unsigned int command_bits, bool change_bridge)
Tiago