2009-09-25 22:19:20

by Karen Xie

Subject: [PATCH v2 2/2 scsi-post-merge] cxgb3i: support of private MAC address in iSCSI

[PATCH v2 2/2 scsi-post-merge] cxgb3i: private MAC address for iSCSI

From: Karen Xie <[email protected]>

This patch updated the use of private MAC address per port in iscsi.

This patch is generated against scsi-post-merge.

Signed-off-by: Karen Xie <[email protected]>
---
drivers/scsi/cxgb3i/cxgb3i_offload.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/drivers/scsi/cxgb3i/cxgb3i_offload.h b/drivers/scsi/cxgb3i/cxgb3i_offload.h
index 6a1d86b..f585ece 100644
--- a/drivers/scsi/cxgb3i/cxgb3i_offload.h
+++ b/drivers/scsi/cxgb3i/cxgb3i_offload.h
@@ -234,9 +234,9 @@ struct sge_opaque_hdr {
* get and set private ip for iscsi traffic
*/
#define cxgb3i_get_private_ipv4addr(ndev) \
- (((struct port_info *)(netdev_priv(ndev)))->iscsi_ipv4addr)
+ (((struct port_info *)(netdev_priv(ndev)))->iscsic.ipv4_addr)
#define cxgb3i_set_private_ipv4addr(ndev, addr) \
- (((struct port_info *)(netdev_priv(ndev)))->iscsi_ipv4addr) = addr
+ (((struct port_info *)(netdev_priv(ndev)))->iscsic.ipv4_addr) = addr

/* max. connections per adapter */
#define CXGB3I_MAX_CONN 16384

2009-09-26 00:55:29

by Mike Christie

Subject: Re: [PATCH v2 2/2 scsi-post-merge] cxgb3i: support of private MAC address in iSCSI

[email protected] wrote:
> [PATCH v2 2/2 scsi-post-merge] cxgb3i: private MAC address for iSCSI
>
> From: Karen Xie <[email protected]>
>
> This patch updated the use of private MAC address per port in iscsi.
>
> This patch is generated against scsi-post-merge.
>
> Signed-off-by: Karen Xie <[email protected]>
> ---
> drivers/scsi/cxgb3i/cxgb3i_offload.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>
> diff --git a/drivers/scsi/cxgb3i/cxgb3i_offload.h b/drivers/scsi/cxgb3i/cxgb3i_offload.h
> index 6a1d86b..f585ece 100644
> --- a/drivers/scsi/cxgb3i/cxgb3i_offload.h
> +++ b/drivers/scsi/cxgb3i/cxgb3i_offload.h
> @@ -234,9 +234,9 @@ struct sge_opaque_hdr {
> * get and set private ip for iscsi traffic
> */
> #define cxgb3i_get_private_ipv4addr(ndev) \
> - (((struct port_info *)(netdev_priv(ndev)))->iscsi_ipv4addr)
> + (((struct port_info *)(netdev_priv(ndev)))->iscsic.ipv4_addr)
> #define cxgb3i_set_private_ipv4addr(ndev, addr) \
> - (((struct port_info *)(netdev_priv(ndev)))->iscsi_ipv4addr) = addr
> + (((struct port_info *)(netdev_priv(ndev)))->iscsic.ipv4_addr) = addr
>

This looks ok.

Reviewed-by Mike Christie <[email protected]>