2009-09-29 01:18:10

by Peter Huewe

Subject: [PATCH] video/omap: adding __init/__exit macros to various drivers

From: Peter Huewe <[email protected]>

Trivial patch which adds the __init/__exit macros to the module_init/
module_exit functions of the following drivers in media/omap:
drivers/video/omap/lcd_ams_delta.c
drivers/video/omap/lcd_mipid.c

Please have a look at the small patch and either pull it through
your tree, or please ack' it so Jiri can pull it through the trivial tree.

linux version v2.6.32-rc1 - linus git tree, Di 29. Sep 01:10:18 CEST 2009

Signed-off-by: Peter Huewe <[email protected]>
---
diff --git a/drivers/video/omap/lcd_ams_delta.c b/drivers/video/omap/lcd_ams_delta.c
index 1f74399..319a9a2 100644
--- a/drivers/video/omap/lcd_ams_delta.c
+++ b/drivers/video/omap/lcd_ams_delta.c
@@ -123,12 +123,12 @@ struct platform_driver ams_delta_panel_driver = {
},
};

-static int ams_delta_panel_drv_init(void)
+static int __init ams_delta_panel_drv_init(void)
{
return platform_driver_register(&ams_delta_panel_driver);
}

-static void ams_delta_panel_drv_cleanup(void)
+static void __exit ams_delta_panel_drv_cleanup(void)
{
platform_driver_unregister(&ams_delta_panel_driver);
}
diff --git a/drivers/video/omap/lcd_mipid.c b/drivers/video/omap/lcd_mipid.c
index 918ee89..d88a792 100644
--- a/drivers/video/omap/lcd_mipid.c
+++ b/drivers/video/omap/lcd_mipid.c
@@ -607,7 +607,7 @@ static struct spi_driver mipid_spi_driver = {
.remove = __devexit_p(mipid_spi_remove),
};

-static int mipid_drv_init(void)
+static int __init mipid_drv_init(void)
{
spi_register_driver(&mipid_spi_driver);

@@ -615,7 +615,7 @@ static int mipid_drv_init(void)
}
module_init(mipid_drv_init);

-static void mipid_drv_cleanup(void)
+static void __exit mipid_drv_cleanup(void)
{
spi_unregister_driver(&mipid_spi_driver);
}

2009-09-29 09:20:10

by Imre Deak

Subject: Re: [PATCH] video/omap: adding __init/__exit macros to various drivers

On Tue, Sep 29, 2009 at 03:18:06AM +0200, ext Peter Huewe wrote:
> From: Peter Huewe <[email protected]>
>
> Trivial patch which adds the __init/__exit macros to the module_init/
> module_exit functions of the following drivers in media/omap:
> drivers/video/omap/lcd_ams_delta.c
> drivers/video/omap/lcd_mipid.c
>
> Please have a look at the small patch and either pull it through
> your tree, or please ack' it so Jiri can pull it through the trivial tree.
>
> linux version v2.6.32-rc1 - linus git tree, Di 29. Sep 01:10:18 CEST 2009
>
> Signed-off-by: Peter Huewe <[email protected]>

Acked-by: Imre Deak <[email protected]>

> ---
> diff --git a/drivers/video/omap/lcd_ams_delta.c b/drivers/video/omap/lcd_ams_delta.c
> index 1f74399..319a9a2 100644
> --- a/drivers/video/omap/lcd_ams_delta.c
> +++ b/drivers/video/omap/lcd_ams_delta.c
> @@ -123,12 +123,12 @@ struct platform_driver ams_delta_panel_driver = {
> },
> };
>
> -static int ams_delta_panel_drv_init(void)
> +static int __init ams_delta_panel_drv_init(void)
> {
> return platform_driver_register(&ams_delta_panel_driver);
> }
>
> -static void ams_delta_panel_drv_cleanup(void)
> +static void __exit ams_delta_panel_drv_cleanup(void)
> {
> platform_driver_unregister(&ams_delta_panel_driver);
> }
> diff --git a/drivers/video/omap/lcd_mipid.c b/drivers/video/omap/lcd_mipid.c
> index 918ee89..d88a792 100644
> --- a/drivers/video/omap/lcd_mipid.c
> +++ b/drivers/video/omap/lcd_mipid.c
> @@ -607,7 +607,7 @@ static struct spi_driver mipid_spi_driver = {
> .remove = __devexit_p(mipid_spi_remove),
> };
>
> -static int mipid_drv_init(void)
> +static int __init mipid_drv_init(void)
> {
> spi_register_driver(&mipid_spi_driver);
>
> @@ -615,7 +615,7 @@ static int mipid_drv_init(void)
> }
> module_init(mipid_drv_init);
>
> -static void mipid_drv_cleanup(void)
> +static void __exit mipid_drv_cleanup(void)
> {
> spi_unregister_driver(&mipid_spi_driver);
> }

2009-09-29 12:07:47

by Jiri Kosina

Subject: Re: [PATCH] video/omap: adding __init/__exit macros to various drivers

On Tue, 29 Sep 2009, Imre Deak wrote:

> > Trivial patch which adds the __init/__exit macros to the module_init/
> > module_exit functions of the following drivers in media/omap:
> > drivers/video/omap/lcd_ams_delta.c
> > drivers/video/omap/lcd_mipid.c
> >
> > Please have a look at the small patch and either pull it through
> > your tree, or please ack' it so Jiri can pull it through the trivial tree.
> >
> > linux version v2.6.32-rc1 - linus git tree, Di 29. Sep 01:10:18 CEST 2009
> >
> > Signed-off-by: Peter Huewe <[email protected]>
>
> Acked-by: Imre Deak <[email protected]>

Applied, thanks.

--
Jiri Kosina
SUSE Labs, Novell Inc.