2009-10-02 09:17:12

by Stefan Seyfried

Subject: Subject: [PATCH 2.4] Fix Kernel 2.4 build with bash 4

Signed-off-by: Stefan <[email protected]>
---
scripts/Configure | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/Configure b/scripts/Configure
index 1a3af43..7a73423 100644
--- a/scripts/Configure
+++ b/scripts/Configure
@@ -546,9 +546,9 @@ if [ -f $DEFAULTS ]; then
echo "#"
echo "# Using defaults found in" $DEFAULTS
echo "#"
- . $DEFAULTS
+ . ./$DEFAULTS
sed -e 's/# \(CONFIG_[^ ]*\) is not.*/\1=n/' <$DEFAULTS >.config-is-not.$$
- . .config-is-not.$$
+ . ./.config-is-not.$$
rm .config-is-not.$$
else
echo "#"
--
1.6.4.2

2009-10-02 09:25:08

by Willy Tarreau

Subject: Re: Subject: [PATCH 2.4] Fix Kernel 2.4 build with bash 4

Hi Stefan,

On Fri, Oct 02, 2009 at 11:17:11AM +0200, Stefan Seyfried wrote:
>
> Signed-off-by: Stefan <[email protected]>
> ---
> scripts/Configure | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/Configure b/scripts/Configure
> index 1a3af43..7a73423 100644
> --- a/scripts/Configure
> +++ b/scripts/Configure
> @@ -546,9 +546,9 @@ if [ -f $DEFAULTS ]; then
> echo "#"
> echo "# Using defaults found in" $DEFAULTS
> echo "#"
> - . $DEFAULTS
> + . ./$DEFAULTS
> sed -e 's/# \(CONFIG_[^ ]*\) is not.*/\1=n/' <$DEFAULTS >.config-is-not.$$
> - . .config-is-not.$$
> + . ./.config-is-not.$$
> rm .config-is-not.$$
> else
> echo "#"

This is amazing it has ever worked at all ! None of my scripts which use
". $file" without "./" work even in bash 3. Probably this depends on some
PATH variables and maybe your environment has changed since you upgarded
to bash 4.

Thanks for the fix, I'll merge it.
Willy

2009-10-02 09:31:15

by Stefan Seyfried

Subject: Re: Subject: [PATCH 2.4] Fix Kernel 2.4 build with bash 4

On Fri, 2 Oct 2009 11:25:07 +0200
Willy Tarreau <[email protected]> wrote:

> This is amazing it has ever worked at all ! None of my scripts which
> use ". $file" without "./" work even in bash 3. Probably this depends
> on some PATH variables and maybe your environment has changed since
> you upgarded to bash 4.

Well, people started reporting it when distributions (openSUSE FACTORY
and Fedora 11) switched to bash 4. Maybe the shell's defaults are now
just a bit stricter, or the distros abandoned a PATH setting that was
common before, I have no idea.

> Thanks for the fix, I'll merge it.

Thanks! Saves me a local patch ;)

--
Stefan Seyfried

"Any ideas, John?"
"Well, surrounding them's out."