2009-10-07 19:57:24

by Arjan van de Ven

Subject: [PATCH] perf timechart: Work around commit 42e59d7d19dc4b4

>From 07c039ee370f49a0c5fc690ba473d42d27ccb022 Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <[email protected]>
Date: Wed, 7 Oct 2009 12:27:07 -0700
Subject: [PATCH] perf timechart: Work around commit 42e59d7d19dc4b4

Commit 42e59d7d19dc4b4 introduced a sample frequency framework..
.. however it unfortunately changed how perf events get recorded,
and caused timechart to miss events to the point that timechart
became useless.

This patch causes the timechart code to use -F 0 to not use the
new framework when recording timechart data.

Signed-off-by: Arjan van de Ven <[email protected]>
---
tools/perf/builtin-timechart.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c
index 702d8fe..e5bda76 100644
--- a/tools/perf/builtin-timechart.c
+++ b/tools/perf/builtin-timechart.c
@@ -1105,6 +1105,7 @@ static const char *record_args[] = {
"-M",
"-f",
"-c", "1",
+ "-F", "0",
"-e", "power:power_start",
"-e", "power:power_end",
"-e", "power:power_frequency",
--
1.6.0.6



--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org

2009-10-12 07:13:39

by Ingo Molnar

Subject: Re: [PATCH] perf timechart: Work around commit 42e59d7d19dc4b4

* Arjan van de Ven <[email protected]> wrote:

> >From 07c039ee370f49a0c5fc690ba473d42d27ccb022 Mon Sep 17 00:00:00 2001
> From: Arjan van de Ven <[email protected]>
> Date: Wed, 7 Oct 2009 12:27:07 -0700
> Subject: [PATCH] perf timechart: Work around commit 42e59d7d19dc4b4
>
> Commit 42e59d7d19dc4b4 introduced a sample frequency framework..
> .. however it unfortunately changed how perf events get recorded,
> and caused timechart to miss events to the point that timechart
> became useless.
>
> This patch causes the timechart code to use -F 0 to not use the
> new framework when recording timechart data.
>
> Signed-off-by: Arjan van de Ven <[email protected]>
> ---
> tools/perf/builtin-timechart.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

Could you please check latest -tip, does it work fine now?

Mike's commit:

7e4ff9e: perf tools: Fix counter sample frequency breakage

should fix the breakage 42e59d7d19dc4b4 introduced in perf timechart.

Ingo