2009-10-09 09:58:56

by Jiri Kosina

Subject: [PATCH] CRIS: remove code that has been commented out for many years

[ I have already queued this in trivial tree. If you have objections,
please shout ]

Remove the dump_tlb_all() function that has been commented out for
many years.

Signed-off-by: Jiri Kosina <[email protected]>
---
arch/cris/arch-v10/mm/tlb.c | 22 ----------------------
1 files changed, 0 insertions(+), 22 deletions(-)

diff --git a/arch/cris/arch-v10/mm/tlb.c b/arch/cris/arch-v10/mm/tlb.c
index 4a496e4..21d78c5 100644
--- a/arch/cris/arch-v10/mm/tlb.c
+++ b/arch/cris/arch-v10/mm/tlb.c
@@ -134,28 +134,6 @@ void flush_tlb_page(struct vm_area_struct *vma, unsigned long addr)
local_irq_restore(flags);
}

-/* dump the entire TLB for debug purposes */
-
-#if 0
-void
-dump_tlb_all(void)
-{
- int i;
- unsigned long flags;
-
- printk("TLB dump. LO is: pfn | reserved | global | valid | kernel | we |\n");
-
- local_save_flags(flags);
- local_irq_disable();
- for(i = 0; i < NUM_TLB_ENTRIES; i++) {
- *R_TLB_SELECT = ( IO_FIELD(R_TLB_SELECT, index, i) );
- printk("Entry %d: HI 0x%08lx, LO 0x%08lx\n",
- i, *R_TLB_HI, *R_TLB_LO);
- }
- local_irq_restore(flags);
-}
-#endif
-
/*
* Initialize the context related info for a new mm_struct
* instance.
--
1.5.6

2009-10-09 10:54:01

by Jesper Nilsson

Subject: Re: [PATCH] CRIS: remove code that has been commented out for many years

On Fri, Oct 09, 2009 at 11:58:17AM +0200, Jiri Kosina wrote:
> [ I have already queued this in trivial tree. If you have objections,
> please shout ]
>
> Remove the dump_tlb_all() function that has been commented out for
> many years.

I have no objections, the code is obviously old debug.

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]