2009-10-09 08:31:50

by Andrew Morton

[permalink] [raw]
Subject: mmotm 2009-10-09-01-07 uploaded

The mm-of-the-moment snapshot 2009-10-09-01-07 has been uploaded to

http://userweb.kernel.org/~akpm/mmotm/

and will soon be available at

git://git.zen-sources.org/zen/mmotm.git

It contains the following patches against 2.6.32-rc3:

origin.patch
ksm-more-on-default-values.patch
mm-includecheck-fix-vmallocc.patch
fs-includecheck-fix-proc-kcorec.patch
video-includecheck-fix-msm-mddic.patch
video-includecheck-fix-da8xx-fbc.patch
cgroups-update-documentation-of-cgroups-tasks-and-procs-files.patch
pagemap-export-kpf_hwpoison.patch
pagemap-document-kpf_ksm-and-show-it-in-page-types.patch
page-types-add-gpl-note.patch
page-types-introduce-checked_open.patch
page-types-make-standalone-pagemap-kpageflags-read-routines.patch
page-types-make-voffset-local-variables.patch
page-types-introduce-kpageflags_flags.patch
page-types-add-hwpoison-unpoison-feature.patch
mmc-sdio-dont-require-cistpl_vers_1-to-contain-4-strings.patch
lis3lv02d_spi-module-unload-didnt-remove-sysfs-entry.patch
linux-next.patch
next-remove-localversion.patch
i-need-old-gcc.patch
include-linux-compiler-gcc4h-gcc-402-doesnt-understand-__builtin_object_size.patch
kernel-core-add-smp_call_function_any.patch
arch-x86-kernel-cpu-cpufreq-acpi-cpufreqc-avoid-cross-cpu-interrupts-by-using-smp_call_function_any.patch
dell_laptop-when-the-hardware-switch-is-disabled-dont-actually-allow-changing-the-softblock-status.patch
cmpc_acpi-add-support-for-classmate-pc-acpi-devices.patch
cmpc_acpi-add-support-for-classmate-pc-acpi-devices-fix.patch
acpi-clean-up-videoc-boundary-checks-and-types.patch
acpi-annote-acpi_processor_add-with-__cpuinit.patch
eeepc_laptop-properly-annote-eeepc_enable_camera.patch
acpi-reintroduce-acpi_device_ops-shutdown-method.patch
cs5535-gpio-add-amd-cs5535-cs5536-gpio-driver-support.patch
cs5535-gpio-request-function-mask-names-added.patch
alsa-cs5535audio-free-olpc-quirks-from-reliance-on-mgeode_lx-cpu-optimization.patch
agp-correct-missing-cleanup-on-error-in-agp_add_bridge.patch
avr32-convert-to-asm-generic-hardirqh.patch
powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned.patch
hpilo-add-locking-comment.patch
drm-via-add-pci-id-for-via-vx800-chipset.patch
radio-add-support-for-tef6862-tuner.patch
genirq-switch-proc-irq-spurious-to-seq_file.patch
timer-stats-fix-del_timer_sync-and-try_to_del_timer_sync.patch
ia64-use-printk_once.patch
wistron_btnsc-add-dmi-entry-for-medion-wim2030-laptop.patch
kbuild-generate-modulesbuiltin.patch
kbuild-rebuild-fix-for-makefilemodbuiltin.patch
kconfig-cross_compile-option.patch
mfd-adp5520-multifunction-lcd-backlight-and-keypad-input-device-driver.patch
mtdpart-memory-accessor-interface-for-mtd-layer.patch
isdn-hisax-fix-lock-imbalance.patch
hfc_usb-fix-read-buffer-overflow.patch
misdn-fix-reversed-if-in-st_own_ctrl.patch
isdn-eicon-use-offsetof.patch
isdn-eicon-return-on-error.patch
3x59x-fix-pci-resource-management.patch
bluetooth-fix-for-acer-bluetooth-optical-rechargeable-mouse.patch
sunrpc-use-formatting-of-module-name-in-sunrpc.patch
serial-fit-blackfin-uart-over-sport-driver-into-common-uart-infrastructure.patch
jsm-irq-handlers-doesnt-need-to-have-irq_disabled-enabled.patch
jsm-rewriting-a-bad-log-message.patch
jsm-remove-the-ch_custom_speed-field.patch
jsm-remove-ch_old_baud-field.patch
jsm-remove-ch_cpstime-field.patch
jsm-remove-unused-jsm_channel-ch_wopen-field.patch
jsm-remove-the-field-jsm_board-intr_count.patch
drivers-md-introduce-missing-kfree.patch
include-trace-events-lockdeph-fix-do_div-warning.patch
scsi-add-__init-__exit-macros-to-ibmvstgtc.patch
drivers-scsi-fnic-fnic_scsic-clean-up.patch
ibmmca-buffer-overflow.patch
scsi-eata-fix-buffer-overflow.patch
drivers-scsi-gdthc-fix-buffer-overflow.patch
drivers-scsi-u14-34fc-fix-uffer-overflow.patch
drivers-scsi-lpfc-lpfc_vportc-fix-read-buffer-overflow.patch
osst-fix-read-buffer-overflow.patch
scsi-fix-func-names-in-kernel-doc.patch
gdth-unmap-ccb_phys-when-scsi_add_host-fails-in-gdth_eisa_probe_one.patch
zfcp-test-kmalloc-failure-in-scsi_get_vpd_page.patch
st-fix-test-of-value-range-in-st_set_options.patch
drivers-scsi-libsas-use-sam_good.patch
scsi-add-hpsa-driver-for-hp-smart-array-controllers.patch
scsi-add-hpsa-driver-for-hp-smart-array-controllers-fix.patch
drivers-block-dac960c-use-dac960_v2_controller.patch
synaptics-touchscreen-for-htc-dream-check-that-smbus-is-available.patch
drivers-staging-octeon-ethernet-rgmiic-dont-ignore-request_irq-return-code.patch
usb-digi_acceleport-fix-broken-unthrottle.patch
vfs-fix-vfs_rename_dir-for-fs_rename_does_d_move-filesystems.patch
raw-fix-rawctl-compat-ioctls-breakage-on-amd64-and-itanic.patch
vfs-improve-comment-describing-fget_light.patch
ecryptfs-another-lockdep-issue.patch
fs-remove-unneeded-dcache_unhashed-tricks.patch
fs-improve-remountro-vs-buffercache-coherency.patch
vfs-make-real_lookup-do-dentry-revalidation-with-i_mutex-held.patch
vfs-clean-up-real_lookup.patch
xtensa-use-generic-sys_pipe.patch
xtensa-convert-to-asm-generic-hardirqh.patch
xtensa-includecheck-fix-vectorss.patch
percpu-avoid-calling-__pcpu_ptr_to_addrnull.patch
mm.patch
connector-fix-regression-introduced-by-sid-connector.patch
congestion_wait-dont-use-write.patch
elv_iosched_store-fix-strstrip-misuse.patch
cgroup-fix-strstrip-misuse.patch
strstrip-mark-as-as-must_check.patch
rwsem-fix-rwsem_is_locked-bug.patch
cpuidle-always-return-with-interrupts-enabled.patch
dma-debug-allow-dma_bidirectional-mappings-to-be-synced-with-dma_from_device-and.patch
drivers-gpu-drm-i915-i915_dmac-fix-unused-var.patch
drm-make-sure-page-protections-are-updated-after-changing-vm_flags.patch
x86-_end-symbol-missing-from-symbolmap.patch
sched-fix-htmldocs-schedc.patch
scsi_libc-avoid-calling-scsi_device_put-from-under-host_lock.patch
staging-rtl8192e-add-missing-vmalloch-include.patch
hrtimers-remove-the-timer_stats_active-check-when-setting-the-start-info.patch
itimers-fix-racy-writes-to-cpu_itimer-fields.patch
posix-cpu-timers-optimize-and-document-timer_create-callback.patch
x86-fix-kernel-panic-on-i386-machine-when-booting-with-profile=2.patch
vfs-implement-posix-o_sync-and-o_dsync-semantics.patch
vfs-implement-posix-o_sync-and-o_dsync-semantics-checkpatch-fixes.patch
oom-dump-stack-and-vm-state-when-oom-killer-panics.patch
munmap-dont-check-sysctl_max_mapcount.patch
munmap-dont-check-sysctl_max_mapcount-fix.patch
mm-add-notifier-in-pageblock-isolation-for-balloon-drivers.patch
powerpc-make-the-cmm-memory-hotplug-aware.patch
readahead-add-blk_run_backing_dev.patch
mm-warn-once-when-a-page-is-freed-with-pg_mlocked-set.patch
mm-vsmcan-check-shrink_active_list-sc-isolate_pages-return-value.patch
dev-mem-remove-redundant-test-on-len.patch
dev-mem-introduce-size_inside_page.patch
dev-mem-cleanup-unxlate_dev_mem_ptr-calls.patch
dev-mem-cleanup-unxlate_dev_mem_ptr-calls-fix.patch
dev-mem-cleanup-unxlate_dev_mem_ptr-calls-fix-fix.patch
dev-mem-make-size_inside_page-logic-straight.patch
dev-mem-remove-the-written-variable-in-write_kmem.patch
dev-mem-remove-the-written-variable-in-write_kmem-fix.patch
dev-mem-remove-redundant-parameter-from-do_write_kmem.patch
pcmcia-fix-controller-printk-warnings.patch
frv-duplicate-output_buffer-of-e03.patch
frv-duplicate-output_buffer-of-e03-checkpatch-fixes.patch
cris-convert-to-use-arch_gettimeoffset.patch
floppy-add-an-extra-bound-check-on-ioctl-arguments.patch
floppy-add-an-extra-bound-check-on-ioctl-arguments-fix.patch
timecompare-fix-half-y2k38-problem-in-timecompare_update-while-calculating-offset.patch
warn_once-use-bool-for-boolean-flag.patch
dynamic_debugh-kernelh-remove-kbuild_modname-from-dynamic_pr_debug.patch
ad525x_dpot-new-driver-for-ad525x-digital-potentiometers.patch
errh-add-helper-function-to-simplify-pointer-error-checking.patch
errh-add-helper-function-to-simplify-pointer-error-checking-fix.patch
generic-ipi-cleanup-for-generic_smp_call_function_interrupt.patch
maintainers-update-generic-uio-for-pci-devices.patch
maintainers-update-tracing-section.patch
maintainers-update-omap-tony-lindgren-email-name.patch
maintainers-change-atm-mailing-list-to-moderated.patch
maintainers-use-tab-not-spaces-after-field-types.patch
maintainers-update-kernel-janitors-after-mismerge.patch
maintainers-update-score-architecture-name-style-and-add-file-pattern.patch
maintainers-simple-firmware-interface-update-email-style.patch
maintainers-winbond-cir-integrate-p-m-lines-fixup-david-h?rdemans-name.patch
maintainers-fix-up-peripheral-spelling.patch
maintainers-update-wolfson-microelectronics.patch
atmel-mci-change-use-of-dma-slave-interface.patch
mmc-atmel-mci-new-mci2-module-support-in-atmel-mci-driver.patch
davinci-mmc-mmc-sd-controller-driver-for-davinci-family.patch
sdio-recognize-io-card-without-powercycle.patch
hwmon-driver-for-texas-instruments-amc6821-chip.patch
lis3lv02d-axis-remap-and-resource-setup-release.patch
lis3lv02d-i2c-support.patch
xilinx_spi-split-into-generic-of-and-platform-driver-add-support-for-ds570.patch
atmel_spi-fix-dma-addr-calculation-for-len-buffer_size.patch
autofs4-use-helper-functions-for-active-list-handling.patch
autofs4-use-helper-functions-for-expiring-list.patch
autofs4-use-helper-function-for-need-mount-check.patch
autofs4-use-autofs_info-for-pending-flag.patch
autofs4-renamer-unhashed-to-active-in-autofs4_lookup.patch
autofs4-cleanup-active-and-expire-lookup.patch
autofs4-eliminate-d_unhashed-in-path-walk-checks.patch
autofs4-rename-dentry-to-active-in-autofs4_lookup_active.patch
autofs4-rename-dentry-to-expiring-in-autofs4_lookup_expiring.patch
autofs4-always-use-lookup-for-lookup.patch
rtc-cmos-convert-rtc_aie-rtc_uie-to-rtc-irq-api.patch
rtc-set-wakeup-capability-for-i2c-and-spi-rtc-drivers.patch
gpiolib-add-names-file-in-gpio-chip-sysfs.patch
fbdev-bfin-lq035q1-fb-new-blackfin-landscape-lcd-ez-extender-driver.patch
fbdev-bfin-t350mcqb-fb-handle-all-resources-in-suspend-resume.patch
fbdev-bfin-t350mcqb-fb-fix-lcd-dimensions.patch
intelfb-fix-setting-of-active-pipe-with-lvds-displays.patch
hfsplus-identify-journal-info-block-in-volume-header.patch
hfsplus-fix-journal-detection.patch
reiserfs-remove-proc-fs-reiserfs-version.patch
reiserfs-dont-compile-procfso-at-all-if-no-support.patch
reiserfs-truncate-blocks-not-used-by-a-write-v2.patch
fatfs-use-common-time_to_tm-in-fat_time_unix2fat.patch
do_wait-optimization-do-not-place-sub-threads-on-task_struct-children-list.patch
utrace-core.patch
ipc-semc-sem-optimise-undo-list-search.patch
ipc-semc-sem-use-list-operations.patch
ipc-semc-sem-preempt-improve.patch
ipc-semc-optimize-if-semops-fail.patch
ipc-semc-add-a-per-semaphore-pending-list.patch
ipc-semc-optimize-single-semop-operations.patch
ipc-semc-optimize-single-sops-when-semval-is-zero.patch
drivers-char-ipmi-use-kcs_idle_state.patch
elf-kill-use_elf_core_dump.patch
cyclades-allow-overriding-isa-defaults-also-when-the-driver-is-built-in.patch
char-mxser-remove-unnecessary-tty-test.patch
isicomc-use-pr_fmt-and-pr_level.patch
edac-i5100-clean-controller-to-channel-terms.patch
edac-i5100-add-scrubbing.patch
edac-i5100-add-6-ranks-per-channel.patch
sound-core-pcm_timerc-use-lib-gcdc.patch
net-netfilter-ipvs-ip_vs_wrrc-use-lib-gcdc.patch
net-netfilter-ipvs-ip_vs_wrrc-use-lib-gcdc-fix.patch
vfs-take-2add-set_page_dirty_notag.patch
reiser4-vfs-add-super_operationssync_inodes-2.patch
reiser4-export-remove_from_page_cache.patch
reiser4-export-remove_from_page_cache-fix.patch
reiser4-export-find_get_pages.patch
reiser4.patch
reiser4-adjust-to-the-new-aops.patch
reiser4-adjust-to-the-new-aops-fixup.patch
reiser4-remove-simple_prepare_write-usage.patch
reiser4-remove-simple_prepare_write-usage-checkpatch-fixes.patch
fs-symlink-write_begin-allocation-context-fix-reiser4-fix.patch
reiser4-handling-error-returned-by-d_obtain_alias-fixup.patch
reiser4-update-names-of-quota-methods.patch
reiser4-use-set_page_dirty_notag.patch
fs-reiser4-add-parenths-around-x-y.patch
fs-reiser4-contextc-current_is_pdflush-got-removed.patch
reiser4-fix.patch
reiser4-disable.patch
make-sure-nobodys-leaking-resources.patch
journal_add_journal_head-debug.patch
releasing-resources-with-children.patch
make-frame_pointer-default=y.patch
mutex-subsystem-synchro-test-module.patch
slab-leaks3-default-y.patch
put_bh-debug.patch
add-debugging-aid-for-memory-initialisation-problems.patch
keep-track-of-network-interface-renaming.patch
workaround-for-a-pci-restoring-bug.patch
prio_tree-debugging-patch.patch
single_open-seq_release-leak-diagnostics.patch
add-a-refcount-check-in-dput.patch
getblk-handle-2tb-devices.patch
getblk-handle-2tb-devices-fix.patch
undeprecate-pci_find_device.patch
notify_change-callers-must-hold-i_mutex.patch


2009-10-09 10:02:50

by Jiri Slaby

[permalink] [raw]
Subject: [was: mmotm 2009-10-09-01-07 uploaded]

On 10/09/2009 10:07 AM, [email protected] wrote:
> The mm-of-the-moment snapshot 2009-10-09-01-07 has been uploaded to

Hi, build fails with:
ERROR: "cpufreq_get" [arch/x86/kvm/kvm.ko] undefined!
because of
CONFIG_KVM=m
...
# CONFIG_CPU_FREQ is not set

Should cpufreq_get be defined as inline return 0 the same as
cpufreq_quick_get on !CONFIG_CPU_FREQ?

2009-10-09 15:31:12

by Randy Dunlap

[permalink] [raw]
Subject: Re: [was: mmotm 2009-10-09-01-07 uploaded]

On Fri, 09 Oct 2009 12:00:55 +0200 Jiri Slaby wrote:

> On 10/09/2009 10:07 AM, [email protected] wrote:
> > The mm-of-the-moment snapshot 2009-10-09-01-07 has been uploaded to
>
> Hi, build fails with:
> ERROR: "cpufreq_get" [arch/x86/kvm/kvm.ko] undefined!
> because of
> CONFIG_KVM=m
> ...
> # CONFIG_CPU_FREQ is not set
>
> Should cpufreq_get be defined as inline return 0 the same as
> cpufreq_quick_get on !CONFIG_CPU_FREQ?

I submitted a patch for that several days ago, against
linux-next-20091006. (below again)

---
From: Randy Dunlap <[email protected]>

When CONFIG_CPU_FREQ is disabled, cpufreq_get() needs a stub.
Used by kvm (although it looks like a bit of the kvm code could
be omitted when CONFIG_CPU_FREQ is disabled).

arch/x86/built-in.o: In function `kvm_arch_init':
(.text+0x10de7): undefined reference to `cpufreq_get'

Signed-off-by: Randy Dunlap <[email protected]>
Tested-by: Eric Paris <[email protected]>
---
include/linux/cpufreq.h | 7 +++++++
1 file changed, 7 insertions(+)

--- linux-next-20091006.orig/include/linux/cpufreq.h
+++ linux-next-20091006/include/linux/cpufreq.h
@@ -291,8 +291,15 @@ struct global_attr {
int cpufreq_get_policy(struct cpufreq_policy *policy, unsigned int cpu);
int cpufreq_update_policy(unsigned int cpu);

+#ifdef CONFIG_CPU_FREQ
/* query the current CPU frequency (in kHz). If zero, cpufreq couldn't detect it */
unsigned int cpufreq_get(unsigned int cpu);
+#else
+static inline unsigned int cpufreq_get(unsigned int cpu)
+{
+ return 0;
+}
+#endif

/* query the last known CPU freq (in kHz). If zero, cpufreq couldn't detect it */
#ifdef CONFIG_CPU_FREQ

2009-10-09 15:33:11

by Jiri Slaby

[permalink] [raw]
Subject: Re: kvm build failure [was: mmotm 2009-10-09-01-07 uploaded]

On 10/09/2009 05:30 PM, Randy Dunlap wrote:
> I submitted a patch for that several days ago, against
> linux-next-20091006. (below again)

Thanks!

2009-10-09 22:48:14

by Randy Dunlap

[permalink] [raw]
Subject: Re: mmotm 2009-10-09-01-07 uploaded (b43)


In file included from mmotm-2009-1009-0107/drivers/net/wireless/b43/b43.h:12,
from mmotm-2009-1009-0107/drivers/net/wireless/b43/main.c:47:
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: 'struct b43_wl' declared inside parameter list
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: its scope is only this definition or declaration, which is probably not what you want
mmotm-2009-1009-0107/drivers/net/wireless/b43/main.c: In function 'b43_remove':
mmotm-2009-1009-0107/drivers/net/wireless/b43/main.c:5003: warning: passing argument 1 of 'b43_leds_unregister' from incompatible pointer type
In file included from mmotm-2009-1009-0107/drivers/net/wireless/b43/b43.h:12,
from mmotm-2009-1009-0107/drivers/net/wireless/b43/tables.c:28:
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: 'struct b43_wl' declared inside parameter list
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from mmotm-2009-1009-0107/drivers/net/wireless/b43/b43.h:12,
from mmotm-2009-1009-0107/drivers/net/wireless/b43/phy_common.c:34:
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: 'struct b43_wl' declared inside parameter list
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from mmotm-2009-1009-0107/drivers/net/wireless/b43/b43.h:12,
from mmotm-2009-1009-0107/drivers/net/wireless/b43/phy_g.c:29:
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: 'struct b43_wl' declared inside parameter list
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from mmotm-2009-1009-0107/drivers/net/wireless/b43/b43.h:12,
from mmotm-2009-1009-0107/drivers/net/wireless/b43/phy_a.c:29:
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: 'struct b43_wl' declared inside parameter list
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from mmotm-2009-1009-0107/drivers/net/wireless/b43/b43.h:12,
from mmotm-2009-1009-0107/drivers/net/wireless/b43/phy_lp.c:26:
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: 'struct b43_wl' declared inside parameter list
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from mmotm-2009-1009-0107/drivers/net/wireless/b43/b43.h:12,
from mmotm-2009-1009-0107/drivers/net/wireless/b43/tables_lpphy.c:26:
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: 'struct b43_wl' declared inside parameter list
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from mmotm-2009-1009-0107/drivers/net/wireless/b43/b43.h:12,
from mmotm-2009-1009-0107/drivers/net/wireless/b43/sysfs.c:29:
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: 'struct b43_wl' declared inside parameter list
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from mmotm-2009-1009-0107/drivers/net/wireless/b43/b43.h:12,
from mmotm-2009-1009-0107/drivers/net/wireless/b43/main.h:34,
from mmotm-2009-1009-0107/drivers/net/wireless/b43/xmit.h:4,
from mmotm-2009-1009-0107/drivers/net/wireless/b43/xmit.c:30:
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: 'struct b43_wl' declared inside parameter list
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from mmotm-2009-1009-0107/drivers/net/wireless/b43/b43.h:12,
from mmotm-2009-1009-0107/drivers/net/wireless/b43/lo.c:30:
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: 'struct b43_wl' declared inside parameter list
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from mmotm-2009-1009-0107/drivers/net/wireless/b43/b43.h:12,
from mmotm-2009-1009-0107/drivers/net/wireless/b43/wa.c:27:
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: 'struct b43_wl' declared inside parameter list
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from mmotm-2009-1009-0107/drivers/net/wireless/b43/b43.h:12,
from mmotm-2009-1009-0107/drivers/net/wireless/b43/dma.c:30:
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: 'struct b43_wl' declared inside parameter list
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from mmotm-2009-1009-0107/drivers/net/wireless/b43/b43.h:12,
from mmotm-2009-1009-0107/drivers/net/wireless/b43/pio.c:26:
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: 'struct b43_wl' declared inside parameter list
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from mmotm-2009-1009-0107/drivers/net/wireless/b43/b43.h:12,
from mmotm-2009-1009-0107/drivers/net/wireless/b43/rfkill.c:25:
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: 'struct b43_wl' declared inside parameter list
mmotm-2009-1009-0107/drivers/net/wireless/b43/leds.h:79: warning: its scope is only this definition or declaration, which is probably not what you want



config attached.


---
~Randy


Attachments:
config-r2787 (39.55 kB)

2009-10-09 23:13:12

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH -mmotm] cmpc_acpi: depends on ACPI

From: Randy Dunlap <[email protected]>

Fix about 100 build errors/warnings when ACPI is not enabled. E.g.:

drivers/platform/x86/cmpc_acpi.c:50: error: dereferencing pointer to incomplete type
drivers/platform/x86/cmpc_acpi.c:55: error: dereferencing pointer to incomplete type
drivers/platform/x86/cmpc_acpi.c:56: error: dereferencing pointer to incomplete type
drivers/platform/x86/cmpc_acpi.c:72: warning: 'struct acpi_device' declared inside parameter list
drivers/platform/x86/cmpc_acpi.c:77: error: dereferencing pointer to incomplete type
drivers/platform/x86/cmpc_acpi.c:79: error: dereferencing pointer to incomplete type

Signed-off-by: Randy Dunlap <[email protected]>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- mmotm-2009-1009-0107.orig/drivers/platform/x86/Kconfig
+++ mmotm-2009-1009-0107/drivers/platform/x86/Kconfig
@@ -438,7 +438,7 @@ config ACPI_TOSHIBA

config ACPI_CMPC
tristate "CMPC Laptop Extras"
- depends on X86
+ depends on X86 && ACPI
select INPUT
select BACKLIGHT_CLASS_DEVICE
default n

2009-10-09 23:12:15

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH -mmotm] synchro-test: add missing header file

From: Randy Dunlap <[email protected]>

Fix build errors, add <sched.h> header file:

kernel/synchro-test.c: In function 'sched':
kernel/synchro-test.c:220: error: implicit declaration of function 'schedule'
kernel/synchro-test.c: In function 'mutexer':
kernel/synchro-test.c:227: error: implicit declaration of function 'daemonize'
kernel/synchro-test.c:228: error: implicit declaration of function 'set_user_nice'
kernel/synchro-test.c:241: error: dereferencing pointer to incomplete type
kernel/synchro-test.c: In function 'semaphorer':
kernel/synchro-test.c:263: error: dereferencing pointer to incomplete type
kernel/synchro-test.c: In function 'reader':
kernel/synchro-test.c:287: error: dereferencing pointer to incomplete type
kernel/synchro-test.c: In function 'writer':
kernel/synchro-test.c:311: error: dereferencing pointer to incomplete type
kernel/synchro-test.c: In function 'downgrader':
kernel/synchro-test.c:340: error: dereferencing pointer to incomplete type

Signed-off-by: Randy Dunlap <[email protected]>
---
kernel/synchro-test.c | 1 +
1 file changed, 1 insertion(+)

--- mmotm-2009-1009-0107.orig/kernel/synchro-test.c
+++ mmotm-2009-1009-0107/kernel/synchro-test.c
@@ -21,6 +21,7 @@
#include <linux/module.h>
#include <linux/poll.h>
#include <linux/moduleparam.h>
+#include <linux/sched.h>
#include <linux/stat.h>
#include <linux/init.h>
#include <asm/atomic.h>

2009-10-09 23:16:56

by Andrew Morton

[permalink] [raw]
Subject: Re: [was: mmotm 2009-10-09-01-07 uploaded]

On Fri, 9 Oct 2009 08:30:28 -0700
Randy Dunlap <[email protected]> wrote:

> From: Randy Dunlap <[email protected]>
>
> When CONFIG_CPU_FREQ is disabled, cpufreq_get() needs a stub.
> Used by kvm (although it looks like a bit of the kvm code could
> be omitted when CONFIG_CPU_FREQ is disabled).
>
> arch/x86/built-in.o: In function `kvm_arch_init':
> (.text+0x10de7): undefined reference to `cpufreq_get'
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Tested-by: Eric Paris <[email protected]>
> ---
> include/linux/cpufreq.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> --- linux-next-20091006.orig/include/linux/cpufreq.h
> +++ linux-next-20091006/include/linux/cpufreq.h
> @@ -291,8 +291,15 @@ struct global_attr {
> int cpufreq_get_policy(struct cpufreq_policy *policy, unsigned int cpu);
> int cpufreq_update_policy(unsigned int cpu);
>
> +#ifdef CONFIG_CPU_FREQ
> /* query the current CPU frequency (in kHz). If zero, cpufreq couldn't detect it */
> unsigned int cpufreq_get(unsigned int cpu);
> +#else
> +static inline unsigned int cpufreq_get(unsigned int cpu)
> +{
> + return 0;
> +}
> +#endif

Thanks. I'll merge this into mainline in the next batch I think. It's
only needed by the KVM development tree but it's the correct thing to
do anyway and having it in minaline will simplify life for everyone.

2009-10-10 00:13:39

by Valdis Klētnieks

[permalink] [raw]
Subject: mmotm 2009-10-09-01-07 - iwl3945 fails to do firmware load request

On Fri, 09 Oct 2009 01:07:49 PDT, [email protected] said:
> The mm-of-the-moment snapshot 2009-10-09-01-07 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/

Broke my iwl3945 wireless card:

Good (2.6.31-mmotm0917)
Oct 8 09:55:33 turing-police kernel: [ 0.809101] iwl3945: Intel(R) PRO/Wireless 3945ABG/BG Network Connection driver for Linux, 1.2.26ks
Oct 8 09:55:33 turing-police kernel: [ 0.809106] iwl3945: Copyright(c) 2003-2009 Intel Corporation
Oct 8 09:55:33 turing-police kernel: [ 0.809201] iwl3945 0000:0c:00.0: PCI INT A -> GSI 17 (level, low) -> IRQ 17
Oct 8 09:55:33 turing-police kernel: [ 0.879463] iwl3945 0000:0c:00.0: Tunable channels: 11 802.11bg, 13 802.11a channels
Oct 8 09:55:33 turing-police kernel: [ 0.879466] iwl3945 0000:0c:00.0: Detected Intel Wireless WiFi Link 3945ABG
...
Oct 8 09:55:35 turing-police kernel: [ 31.599751] iwl3945 0000:0c:00.0: firmware: requesting iwlwifi-3945-2.ucode
Oct 8 09:55:35 turing-police kernel: [ 31.697046] iwl3945 0000:0c:00.0: loaded firmware version 15.28.2.8
Oct 8 09:55:35 turing-police kernel: [ 31.777214] Registered led device: iwl-phy0::radio
Oct 8 09:55:35 turing-police kernel: [ 31.777430] Registered led device: iwl-phy0::assoc
Oct 8 09:55:35 turing-police kernel: [ 31.777545] Registered led device: iwl-phy0::RX
Oct 8 09:55:35 turing-police kernel: [ 31.777676] Registered led device: iwl-phy0::TX
Oct 8 09:55:35 turing-police kernel: [ 31.789446] ADDRCONF(NETDEV_UP): wlan0: link is not ready
(and then wpa-supplicant is able to bring the card up when it finally gets launched by initscripts)

Bad 2.6.32-rc3-mmotm1009:

Oct 9 13:50:19 turing-police kernel: [ 0.931788] iwl3945: Intel(R) PRO/Wireless 3945ABG/BG Network Connection driver for Linux, 1.2.26ks
Oct 9 13:50:19 turing-police kernel: [ 0.944678] iwl3945: Copyright(c) 2003-2009 Intel Corporation
Oct 9 13:50:19 turing-police kernel: [ 0.957831] iwl3945 0000:0c:00.0: PCI INT A -> GSI 17 (level, low) -> IRQ 17
Oct 9 13:50:19 turing-police kernel: [ 1.038946] iwl3945 0000:0c:00.0: Tunable channels: 11 802.11bg, 13 802.11a channels
Oct 9 13:50:19 turing-police kernel: [ 1.038950] iwl3945 0000:0c:00.0: Detected Intel Wireless WiFi Link 3945ABG

We never see the firmware load request, and of course everything goes
pear-shaped after that doesn't happen....

Kernel is built with:

% zgrep -i iwl /proc/config.gz
CONFIG_IWLWIFI=y
CONFIG_IWLWIFI_SPECTRUM_MEASUREMENT=y
# CONFIG_IWLWIFI_DEBUG is not set
CONFIG_IWLWIFI_DEVICE_TRACING=y
# CONFIG_IWLAGN is not set
CONFIG_IWL3945=y
CONFIG_IWL3945_SPECTRUM_MEASUREMENT=y


Attachments:
(No filename) (227.00 B)

2009-10-10 00:43:14

by Zhu Yi

[permalink] [raw]
Subject: Re: mmotm 2009-10-09-01-07 - iwl3945 fails to do firmware load request

On Sat, 2009-10-10 at 08:12 +0800, [email protected] wrote:
> On Fri, 09 Oct 2009 01:07:49 PDT, [email protected] said:
> > The mm-of-the-moment snapshot 2009-10-09-01-07 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
>
> Broke my iwl3945 wireless card:
>
> Good (2.6.31-mmotm0917)
> Oct 8 09:55:33 turing-police kernel: [ 0.809101] iwl3945: Intel(R) PRO/Wireless 3945ABG/BG Network Connection driver for Linux, 1.2.26ks
> Oct 8 09:55:33 turing-police kernel: [ 0.809106] iwl3945: Copyright(c) 2003-2009 Intel Corporation
> Oct 8 09:55:33 turing-police kernel: [ 0.809201] iwl3945 0000:0c:00.0: PCI INT A -> GSI 17 (level, low) -> IRQ 17
> Oct 8 09:55:33 turing-police kernel: [ 0.879463] iwl3945 0000:0c:00.0: Tunable channels: 11 802.11bg, 13 802.11a channels
> Oct 8 09:55:33 turing-police kernel: [ 0.879466] iwl3945 0000:0c:00.0: Detected Intel Wireless WiFi Link 3945ABG
> ...
> Oct 8 09:55:35 turing-police kernel: [ 31.599751] iwl3945 0000:0c:00.0: firmware: requesting iwlwifi-3945-2.ucode
> Oct 8 09:55:35 turing-police kernel: [ 31.697046] iwl3945 0000:0c:00.0: loaded firmware version 15.28.2.8
> Oct 8 09:55:35 turing-police kernel: [ 31.777214] Registered led device: iwl-phy0::radio
> Oct 8 09:55:35 turing-police kernel: [ 31.777430] Registered led device: iwl-phy0::assoc
> Oct 8 09:55:35 turing-police kernel: [ 31.777545] Registered led device: iwl-phy0::RX
> Oct 8 09:55:35 turing-police kernel: [ 31.777676] Registered led device: iwl-phy0::TX
> Oct 8 09:55:35 turing-police kernel: [ 31.789446] ADDRCONF(NETDEV_UP): wlan0: link is not ready
> (and then wpa-supplicant is able to bring the card up when it finally gets launched by initscripts)
>
> Bad 2.6.32-rc3-mmotm1009:
>
> Oct 9 13:50:19 turing-police kernel: [ 0.931788] iwl3945: Intel(R) PRO/Wireless 3945ABG/BG Network Connection driver for Linux, 1.2.26ks
> Oct 9 13:50:19 turing-police kernel: [ 0.944678] iwl3945: Copyright(c) 2003-2009 Intel Corporation
> Oct 9 13:50:19 turing-police kernel: [ 0.957831] iwl3945 0000:0c:00.0: PCI INT A -> GSI 17 (level, low) -> IRQ 17
> Oct 9 13:50:19 turing-police kernel: [ 1.038946] iwl3945 0000:0c:00.0: Tunable channels: 11 802.11bg, 13 802.11a channels
> Oct 9 13:50:19 turing-police kernel: [ 1.038950] iwl3945 0000:0c:00.0: Detected Intel Wireless WiFi Link 3945ABG
>
> We never see the firmware load request, and of course everything goes
> pear-shaped after that doesn't happen....

The firmware loading happens when the user space brings the interface
up. Can you check NM is running for the bad case?

Thanks,
-yi

2009-10-10 03:56:30

by Larry Finger

[permalink] [raw]
Subject: Re: mmotm 2009-10-09-01-07 uploaded (b43)

On 10/09/2009 05:47 PM, Randy Dunlap wrote:
>
> In file included from mmotm-2009-1009-0107/drivers/net/wireless/b43/b43.h:12,
> from mmotm-2009-1009-0107/drivers/net/wireless/b43/main.c:47:

These warnings occur because CONFIG_B43_LEDS is not set, probably
because CONFIG_MAC80211_LEDS is not set. See the patch in
http://marc.info/?l=linux-wireless&m=125509895406304&w=2.

Larry

2009-10-10 05:23:22

by Valdis Klētnieks

[permalink] [raw]
Subject: Re: mmotm 2009-10-09-01-07 - iwl3945 fails to do firmware load request

On Sat, 10 Oct 2009 08:42:35 +0800, Zhu Yi said:

> The firmware loading happens when the user space brings the interface
> up. Can you check NM is running for the bad case?

I'm not using NM, because I've never figured out how to get it to DTRT for
my network config, so I run wpa_supplicant directly. It's looking like
a bad update to dbus was the actual root cause.

(Did I mention how I loath dbus? Or at least the fact that if it breaks,
everything from wireless to pulseaudio immediately craps out too. That and
'hald' are my two favorite "only on this laptop because stuff refuses to
work without them"....)


Attachments:
(No filename) (227.00 B)
Subject: Re: [PATCH -mmotm] cmpc_acpi: depends on ACPI

On Fri, Oct 09, 2009 at 04:10:36PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> Fix about 100 build errors/warnings when ACPI is not enabled. E.g.:
>
> drivers/platform/x86/cmpc_acpi.c:50: error: dereferencing pointer to incomplete type
> drivers/platform/x86/cmpc_acpi.c:55: error: dereferencing pointer to incomplete type
> drivers/platform/x86/cmpc_acpi.c:56: error: dereferencing pointer to incomplete type
> drivers/platform/x86/cmpc_acpi.c:72: warning: 'struct acpi_device' declared inside parameter list
> drivers/platform/x86/cmpc_acpi.c:77: error: dereferencing pointer to incomplete type
> drivers/platform/x86/cmpc_acpi.c:79: error: dereferencing pointer to incomplete type
>
> Signed-off-by: Randy Dunlap <[email protected]>

Acked-by: Thadeu Lima de Souza Cascardo <[email protected]>

> ---
> drivers/platform/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- mmotm-2009-1009-0107.orig/drivers/platform/x86/Kconfig
> +++ mmotm-2009-1009-0107/drivers/platform/x86/Kconfig
> @@ -438,7 +438,7 @@ config ACPI_TOSHIBA
>
> config ACPI_CMPC
> tristate "CMPC Laptop Extras"
> - depends on X86
> + depends on X86 && ACPI
> select INPUT
> select BACKLIGHT_CLASS_DEVICE
> default n


Attachments:
(No filename) (1.25 kB)
signature.asc (197.00 B)
Digital signature
Download all attachments

2009-10-12 10:51:56

by David Howells

[permalink] [raw]
Subject: Re: [PATCH -mmotm] synchro-test: add missing header file

Randy Dunlap <[email protected]> wrote:

> From: Randy Dunlap <[email protected]>
>
> Fix build errors, add <sched.h> header file:
>
> kernel/synchro-test.c: In function 'sched':
> kernel/synchro-test.c:220: error: implicit declaration of function 'schedule'
> kernel/synchro-test.c: In function 'mutexer':
> kernel/synchro-test.c:227: error: implicit declaration of function 'daemonize'
> kernel/synchro-test.c:228: error: implicit declaration of function 'set_user_nice'
> kernel/synchro-test.c:241: error: dereferencing pointer to incomplete type
> kernel/synchro-test.c: In function 'semaphorer':
> kernel/synchro-test.c:263: error: dereferencing pointer to incomplete type
> kernel/synchro-test.c: In function 'reader':
> kernel/synchro-test.c:287: error: dereferencing pointer to incomplete type
> kernel/synchro-test.c: In function 'writer':
> kernel/synchro-test.c:311: error: dereferencing pointer to incomplete type
> kernel/synchro-test.c: In function 'downgrader':
> kernel/synchro-test.c:340: error: dereferencing pointer to incomplete type
>
> Signed-off-by: Randy Dunlap <[email protected]>

Acked-by: David Howells <[email protected]>

2009-10-12 23:21:20

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH -mmotm] synchro-test: add missing header file

On Mon, 12 Oct 2009 11:51:18 +0100
David Howells <[email protected]> wrote:

> Randy Dunlap <[email protected]> wrote:
>
> > From: Randy Dunlap <[email protected]>
> >
> > Fix build errors, add <sched.h> header file:
> >
> > kernel/synchro-test.c: In function 'sched':
> > kernel/synchro-test.c:220: error: implicit declaration of function 'schedule'
> > kernel/synchro-test.c: In function 'mutexer':
> > kernel/synchro-test.c:227: error: implicit declaration of function 'daemonize'
> > kernel/synchro-test.c:228: error: implicit declaration of function 'set_user_nice'
> > kernel/synchro-test.c:241: error: dereferencing pointer to incomplete type
> > kernel/synchro-test.c: In function 'semaphorer':
> > kernel/synchro-test.c:263: error: dereferencing pointer to incomplete type
> > kernel/synchro-test.c: In function 'reader':
> > kernel/synchro-test.c:287: error: dereferencing pointer to incomplete type
> > kernel/synchro-test.c: In function 'writer':
> > kernel/synchro-test.c:311: error: dereferencing pointer to incomplete type
> > kernel/synchro-test.c: In function 'downgrader':
> > kernel/synchro-test.c:340: error: dereferencing pointer to incomplete type
> >
> > Signed-off-by: Randy Dunlap <[email protected]>
>
> Acked-by: David Howells <[email protected]>

kernel/synchro-test.c has mysteriously vanished from linux-next so I
can't merge this and don't know who should. Ingo, perhaps?

2009-10-13 02:25:39

by Stephen Rothwell

[permalink] [raw]
Subject: Re: [PATCH -mmotm] synchro-test: add missing header file

Hi Andrew,

On Mon, 12 Oct 2009 16:20:15 -0700 Andrew Morton <[email protected]> wrote:
>
> kernel/synchro-test.c has mysteriously vanished from linux-next so I

That would be because it was never in linux-next :-)

See your patch mutex-subsystem-synchro-test-module.patch

--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/


Attachments:
(No filename) (385.00 B)
(No filename) (198.00 B)
Download all attachments

2009-10-13 02:35:03

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH -mmotm] synchro-test: add missing header file

On Tue, 13 Oct 2009 13:24:54 +1100 Stephen Rothwell <[email protected]> wrote:

> Hi Andrew,
>
> On Mon, 12 Oct 2009 16:20:15 -0700 Andrew Morton <[email protected]> wrote:
> >
> > kernel/synchro-test.c has mysteriously vanished from linux-next so I
>
> That would be because it was never in linux-next :-)
>
> See your patch mutex-subsystem-synchro-test-module.patch

geeze, I've been sitting on that for 3-1/2 years. I wonder how much
use it's getting.

http://userweb.kernel.org/~akpm/mmotm/broken-out/mutex-subsystem-synchro-test-module.patch