2009-10-12 03:24:15

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: manual merge of the i7core_edac tree with Linus' tree

Hi Mauro,

Today's linux-next merge of the i7core_edac tree got a conflict in
arch/x86/kernel/cpu/mcheck/mce.c between commit
f436f8bb73138bc74eb1c6527723e00988ad8a8a ("x86: EDAC: MCE: Fix MCE
decoding callback logic") from Linus' tree and commit
699a7dbe1ffdf4b25c1475e45590b181c3e23087 ("edac_mce: Add an interface
driver to report mce errors via edac") from the i7core_edac tree.

I don't know how to resolve these two commits so I have dropped the
i7core_edac tree for today.

--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/


Attachments:
(No filename) (584.00 B)
(No filename) (198.00 B)
Download all attachments

2009-10-12 05:06:18

by Borislav Petkov

[permalink] [raw]
Subject: Re: linux-next: manual merge of the i7core_edac tree with Linus' tree

On Mon, Oct 12, 2009 at 02:23:28PM +1100, Stephen Rothwell wrote:
> Today's linux-next merge of the i7core_edac tree got a conflict in
> arch/x86/kernel/cpu/mcheck/mce.c between commit
> f436f8bb73138bc74eb1c6527723e00988ad8a8a ("x86: EDAC: MCE: Fix MCE
> decoding callback logic") from Linus' tree and commit
> 699a7dbe1ffdf4b25c1475e45590b181c3e23087 ("edac_mce: Add an interface
> driver to report mce errors via edac") from the i7core_edac tree.

The current way Ingo suggested is using an atomic notifier instead
from within print_mce to convey MCE info to an EDAC driver, see
http://marc.info/?l=linux-kernel&m=125455310112745&w=2

Ingo, what are your plans with that? I'm guessing the .33 timeframe?

Thanks.

--
Regards/Gruss,
Boris.

2009-10-12 10:25:42

by Ingo Molnar

[permalink] [raw]
Subject: Re: linux-next: manual merge of the i7core_edac tree with Linus' tree


* Borislav Petkov <[email protected]> wrote:

> On Mon, Oct 12, 2009 at 02:23:28PM +1100, Stephen Rothwell wrote:
> > Today's linux-next merge of the i7core_edac tree got a conflict in
> > arch/x86/kernel/cpu/mcheck/mce.c between commit
> > f436f8bb73138bc74eb1c6527723e00988ad8a8a ("x86: EDAC: MCE: Fix MCE
> > decoding callback logic") from Linus' tree and commit
> > 699a7dbe1ffdf4b25c1475e45590b181c3e23087 ("edac_mce: Add an interface
> > driver to report mce errors via edac") from the i7core_edac tree.
>
> The current way Ingo suggested is using an atomic notifier instead
> from within print_mce to convey MCE info to an EDAC driver, see
> http://marc.info/?l=linux-kernel&m=125455310112745&w=2
>
> Ingo, what are your plans with that? I'm guessing the .33 timeframe?

yeah, that looks like .33 material. (unless it fixes a regression)
I have queued it up in tip:x86/mce.

Thanks,

Ingo

2009-10-13 11:51:12

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: linux-next: manual merge of the i7core_edac tree with Linus' tree


----- "Stephen Rothwell" <[email protected]> escreveu:

> Hi Mauro,
>
> Today's linux-next merge of the i7core_edac tree got a conflict in
> arch/x86/kernel/cpu/mcheck/mce.c between commit
> f436f8bb73138bc74eb1c6527723e00988ad8a8a ("x86: EDAC: MCE: Fix MCE
> decoding callback logic") from Linus' tree and commit
> 699a7dbe1ffdf4b25c1475e45590b181c3e23087 ("edac_mce: Add an interface
> driver to report mce errors via edac") from the i7core_edac tree.
>
> I don't know how to resolve these two commits so I have dropped the
> i7core_edac tree for today.

Thanks for letting me know. I've rebased it fixing the merge conflict. For now,
I just removed the call to edac_mce_parse() for Uncorrected Errors, since I'll
eventually replace that part of the code with something better.

You should now be able to merge it without merging conflicts.

Cheers,
Mauro.

2009-10-13 11:53:47

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: manual merge of the i7core_edac tree with Linus' tree

Hi Mauro,

On Tue, 13 Oct 2009 07:50:36 -0400 (EDT) Mauro Carvalho Chehab <[email protected]> wrote:
>
> Thanks for letting me know. I've rebased it fixing the merge conflict. For now,
> I just removed the call to edac_mce_parse() for Uncorrected Errors, since I'll
> eventually replace that part of the code with something better.
>
> You should now be able to merge it without merging conflicts.

OK, thanks.

--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/


Attachments:
(No filename) (517.00 B)
(No filename) (198.00 B)
Download all attachments