2009-10-18 22:25:47

by Steven King

Subject: [PATCH] fix section mismatch in fec.c

fec_enet_init is called by both fec_probe and fec_resume, so it shouldn't
be marked as __init.

Signed-off-by: Steven King <[email protected]>


diff --git a/drivers/net/fec.c b/drivers/net/fec.c
index 2923438..e8218a3 100644
--- a/drivers/net/fec.c
+++ b/drivers/net/fec.c
@@ -1654,7 +1654,8 @@ static const struct net_device_ops fec_netdev_ops = {
*
* index is only used in legacy code
*/
-int __init fec_enet_init(struct net_device *dev, int index)
+static int
+fec_enet_init(struct net_device *dev, int index)
{
struct fec_enet_private *fep = netdev_priv(dev);
struct bufdesc *cbd_base;

--
Steven King -- sfking at fdwdc dot com

2009-10-19 04:26:59

by David Miller

Subject: Re: [PATCH] fix section mismatch in fec.c

From: Steven King <[email protected]>
Date: Sun, 18 Oct 2009 15:25:48 -0700

> */
> -int __init fec_enet_init(struct net_device *dev, int index)
> +static int
> +fec_enet_init(struct net_device *dev, int index)
> {

Don't change coding style when fixing a bug.

Fix this up and resubmit your fix, thanks.