2009-10-19 17:11:43

by Arnaldo Carvalho de Melo

Subject: [PATCH] perf tools: Add missing tools/perf/util/include/string.h

To cure a bunch of:

In file included from util/include/linux/bitmap.h:1,
from util/header.h:8,
from builtin-trace.c:7:
util/include/../../../../include/linux/bitmap.h:8:26: error: linux/string.h: No such file or directory
make: *** [builtin-trace.o] Error 1
make: *** Waiting for unfinished jobs....

Cc: Steven Rostedt <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/Makefile | 1 +
tools/perf/util/include/linux/string.h | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
create mode 100644 tools/perf/util/include/linux/string.h

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index db89a6d..3b154f1 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -329,6 +329,7 @@ LIB_H += ../../include/linux/perf_event.h
LIB_H += ../../include/linux/rbtree.h
LIB_H += ../../include/linux/list.h
LIB_H += util/include/linux/list.h
+LIB_H += util/include/linux/string.h
LIB_H += perf.h
LIB_H += util/event.h
LIB_H += util/types.h
diff --git a/tools/perf/util/include/linux/string.h b/tools/perf/util/include/linux/string.h
new file mode 100644
index 0000000..3b2f590
--- /dev/null
+++ b/tools/perf/util/include/linux/string.h
@@ -0,0 +1 @@
+#include <string.h>
--
1.5.5.1

2009-10-19 17:47:33

by Frederic Weisbecker

Subject: Re: [PATCH] perf tools: Add missing tools/perf/util/include/string.h

On Mon, Oct 19, 2009 at 03:11:36PM -0200, Arnaldo Carvalho de Melo wrote:
> To cure a bunch of:
>
> In file included from util/include/linux/bitmap.h:1,
> from util/header.h:8,
> from builtin-trace.c:7:
> util/include/../../../../include/linux/bitmap.h:8:26: error: linux/string.h: No such file or directory
> make: *** [builtin-trace.o] Error 1
> make: *** Waiting for unfinished jobs....



Hmm, while exporting some headers, I saw that some kernel headers inclusion didn't
triggered any warning although they were including headers for which I hadn't
put any stub, so they couldn't find it.

So it looks like my gcc is sometimes missing such problems. Sorry.

Thanks.

2009-10-24 01:04:38

by Arnaldo Carvalho de Melo

Subject: [tip:branch?] perf tools: Add missing tools/perf/util/include/string.h

Commit-ID: 20639c15d2e78f180d398a6b6422880fac3258bb
Gitweb: http://git.kernel.org/tip/20639c15d2e78f180d398a6b6422880fac3258bb
Author: Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Mon, 19 Oct 2009 15:11:36 -0200
Committer: Ingo Molnar <[email protected]>
CommitDate: Tue, 20 Oct 2009 02:59:34 +0200

perf tools: Add missing tools/perf/util/include/string.h

To cure a bunch of:

In file included from util/include/linux/bitmap.h:1,
from util/header.h:8,
from builtin-trace.c:7:
util/include/../../../../include/linux/bitmap.h:8:26: error:
linux/string.h: No such file or directory make: ***
[builtin-trace.o] Error 1 make: *** Waiting for unfinished
jobs....

Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Acked-by: Frederic Weisbecker <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Peter Zijlstra <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
---
tools/perf/Makefile | 1 +
tools/perf/util/include/linux/string.h | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index db89a6d..3b154f1 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -329,6 +329,7 @@ LIB_H += ../../include/linux/perf_event.h
LIB_H += ../../include/linux/rbtree.h
LIB_H += ../../include/linux/list.h
LIB_H += util/include/linux/list.h
+LIB_H += util/include/linux/string.h
LIB_H += perf.h
LIB_H += util/event.h
LIB_H += util/types.h
diff --git a/tools/perf/util/include/linux/string.h b/tools/perf/util/include/linux/string.h
new file mode 100644
index 0000000..3b2f590
--- /dev/null
+++ b/tools/perf/util/include/linux/string.h
@@ -0,0 +1 @@
+#include <string.h>