Hi Dave,
Today's linux-next build (powerpc ppc44x_defconfig) produced these
warnings:
In file included from net/socket.c:94:
include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
include/net/compat.h:45: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/core/scm.c:36:
include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
include/net/compat.h:45: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/ip_sockglue.c:37:
include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
include/net/compat.h:45: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/ipv6_sockglue.c:53:
include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
include/net/compat.h:45: warning: its scope is only this definition or declaration, which is probably not what you want
CONFIG_COMPAT is not set.
Caused by commit a2e2725541fad72416326798c2d7fa4dafb7d337 ("net:
Introduce recvmmsg socket syscall").
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
Hi Dave,
On Wed, 14 Oct 2009 15:20:00 +1100 Stephen Rothwell <[email protected]> wrote:
>
> Today's linux-next build (powerpc ppc44x_defconfig) produced these
> warnings:
>
> In file included from net/socket.c:94:
> include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
> include/net/compat.h:45: warning: its scope is only this definition or declaration, which is probably not what you want
> In file included from net/core/scm.c:36:
> include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
> include/net/compat.h:45: warning: its scope is only this definition or declaration, which is probably not what you want
> In file included from net/ipv4/ip_sockglue.c:37:
> include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
> include/net/compat.h:45: warning: its scope is only this definition or declaration, which is probably not what you want
> In file included from net/ipv6/ipv6_sockglue.c:53:
> include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
> include/net/compat.h:45: warning: its scope is only this definition or declaration, which is probably not what you want
>
> CONFIG_COMPAT is not set.
>
> Caused by commit a2e2725541fad72416326798c2d7fa4dafb7d337 ("net:
> Introduce recvmmsg socket syscall").
I also get these for i386 and sparc32 defconfig builds.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell <[email protected]>
Date: Wed, 14 Oct 2009 15:34:50 +1100
> On Wed, 14 Oct 2009 15:20:00 +1100 Stephen Rothwell <[email protected]> wrote:
>>
>> Today's linux-next build (powerpc ppc44x_defconfig) produced these
>> warnings:
>>
>> In file included from net/socket.c:94:
>> include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
>>
>> CONFIG_COMPAT is not set.
>>
>> Caused by commit a2e2725541fad72416326798c2d7fa4dafb7d337 ("net:
>> Introduce recvmmsg socket syscall").
...
>
> I also get these for i386 and sparc32 defconfig builds.
I've asked Arnaldo to work on fixing this.
Thanks!
Em Wed, Oct 14, 2009 at 03:11:37PM -0700, David Miller escreveu:
> From: Stephen Rothwell <[email protected]>
> Date: Wed, 14 Oct 2009 15:34:50 +1100
>
> > On Wed, 14 Oct 2009 15:20:00 +1100 Stephen Rothwell <[email protected]> wrote:
> >>
> >> Today's linux-next build (powerpc ppc44x_defconfig) produced these
> >> warnings:
> >>
> >> In file included from net/socket.c:94:
> >> include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
> >>
> >> CONFIG_COMPAT is not set.
> >>
> >> Caused by commit a2e2725541fad72416326798c2d7fa4dafb7d337 ("net:
> >> Introduce recvmmsg socket syscall").
> ...
> >
> > I also get these for i386 and sparc32 defconfig builds.
>
> I've asked Arnaldo to work on fixing this.
I'll fix that early tomorrow.
- Arnaldo
Em Wed, Oct 14, 2009 at 03:11:37PM -0700, David Miller escreveu:
> From: Stephen Rothwell <[email protected]>
> Date: Wed, 14 Oct 2009 15:34:50 +1100
> > On Wed, 14 Oct 2009 15:20:00 +1100 Stephen Rothwell <[email protected]> wrote:
> >> Today's linux-next build (powerpc ppc44x_defconfig) produced these
> >> warnings:
> >> In file included from net/socket.c:94:
> >> include/net/compat.h:45: warning: 'struct compat_mmsghdr' declared inside parameter list
> >> CONFIG_COMPAT is not set.
> >> Caused by commit a2e2725541fad72416326798c2d7fa4dafb7d337 ("net:
> >> Introduce recvmmsg socket syscall").
> > I also get these for i386 and sparc32 defconfig builds.
This one should fix it, thanks for the report!
- Arnaldo
>From ea9776634ed9b0b4a92c53002ea225bca143f47e Mon Sep 17 00:00:00 2001
From: Arnaldo Carvalho de Melo <[email protected]>
Date: Fri, 16 Oct 2009 23:07:15 -0300
Subject: [PATCH] net: Avoid compiler warning for mmsghdr when CONFIG_COMPAT is not selected
Reported-by: Stephen Rothwell <[email protected]>
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
include/net/compat.h | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/include/net/compat.h b/include/net/compat.h
index 9679f05..3c7d4e3 100644
--- a/include/net/compat.h
+++ b/include/net/compat.h
@@ -33,7 +33,11 @@ extern int compat_sock_get_timestamp(struct sock *, struct timeval __user *);
extern int compat_sock_get_timestampns(struct sock *, struct timespec __user *);
#else /* defined(CONFIG_COMPAT) */
-#define compat_msghdr msghdr /* to avoid compiler warnings */
+/*
+ * To avoid compiler warnings:
+ */
+#define compat_msghdr msghdr
+#define compat_mmsghdr mmsghdr
#endif /* defined(CONFIG_COMPAT) */
extern int get_compat_msghdr(struct msghdr *, struct compat_msghdr __user *);
--
1.6.2.5
From: Arnaldo Carvalho de Melo <[email protected]>
Date: Fri, 16 Oct 2009 23:10:24 -0300
> Subject: [PATCH] net: Avoid compiler warning for mmsghdr when CONFIG_COMPAT is not selected
>
> Reported-by: Stephen Rothwell <[email protected]>
> Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Applied, please CC: networking patches to netdev in the future.
Thanks.
Hi Dave,
On Tue, 20 Oct 2009 01:09:43 -0700 (PDT) David Miller <[email protected]> wrote:
>
> Applied, please CC: networking patches to netdev in the future.
Should I maybe cc all the linux-next emails about the net tree to netdev?
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell <[email protected]>
Date: Tue, 20 Oct 2009 19:14:57 +1100
> On Tue, 20 Oct 2009 01:09:43 -0700 (PDT) David Miller <[email protected]> wrote:
>>
>> Applied, please CC: networking patches to netdev in the future.
>
> Should I maybe cc all the linux-next emails about the net tree to netdev?
Sure, that would help me track things.
On Tue, 20 Oct 2009 01:18:16 -0700 (PDT) David Miller <[email protected]> wrote:
>
> From: Stephen Rothwell <[email protected]>
> >
> > Should I maybe cc all the linux-next emails about the net tree to netdev?
>
> Sure, that would help me track things.
Done.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/