2009-10-14 06:39:08

by Andrey Rahmatullin

[permalink] [raw]
Subject: drivers/staging/rt2860 doesn't compile

drivers/staging/rt2860/common/cmm_info.c: In function
'RTMPIoctlGetSiteSurvey':
drivers/staging/rt2860/common/cmm_info.c:1817: error: 'TASK_INTERRUPTIBLE'
undeclared (first use in this function)
drivers/staging/rt2860/common/cmm_info.c:1817: error: (Each undeclared
identifier is reported only once
drivers/staging/rt2860/common/cmm_info.c:1817: error: for each function it
appears in.)
drivers/staging/rt2860/common/cmm_info.c:1817: error: implicit declaration
of function 'signal_pending'
drivers/staging/rt2860/common/cmm_info.c:1817: error: implicit declaration
of function 'schedule_timeout'

drivers/staging/rt2860/rt_linux.h doesn't include <linux/sched.h>. It
includes <linux/interrupt.h>, which included <linux/sched.h> until
d43c36dc6b357fa1806800f18aa30123c747a6d1

--
WBR, wRAR (ALT Linux Team)


Attachments:
(No filename) (1.00 kB)
signature.asc (490.00 B)
Digital signature
Download all attachments

2009-10-14 18:28:10

by Andrey Rahmatullin

[permalink] [raw]
Subject: Re: drivers/staging/rt2860 doesn't compile

Even after trivial fix (including <linux/sched.h> into
drivers/staging/rt2860/rt_linux.h) the driver doesn't compile:

drivers/staging/rt2860/rt_main_dev.c: In function 'rt_ieee80211_if_setup':
drivers/staging/rt2860/rt_main_dev.c:691: error: 'struct net_device' has
no member named 'wireless_handlers'

--
WBR, wRAR (ALT Linux Team)


Attachments:
(No filename) (335.00 B)
signature.asc (490.00 B)
Digital signature
Download all attachments

2009-10-14 19:16:38

by Greg KH

[permalink] [raw]
Subject: Re: drivers/staging/rt2860 doesn't compile

On Thu, Oct 15, 2009 at 12:27:29AM +0600, Andrey Rahmatullin wrote:
> Even after trivial fix (including <linux/sched.h> into
> drivers/staging/rt2860/rt_linux.h) the driver doesn't compile:
>
> drivers/staging/rt2860/rt_main_dev.c: In function 'rt_ieee80211_if_setup':
> drivers/staging/rt2860/rt_main_dev.c:691: error: 'struct net_device' has
> no member named 'wireless_handlers'

This is already fixed in my tree.

thanks,

greg k-h

2009-10-16 08:58:25

by Andrey Rahmatullin

[permalink] [raw]
Subject: Re: drivers/staging/rt2860 doesn't compile

On Thu, Oct 15, 2009 at 12:27:29AM +0600, Andrey Rahmatullin wrote:
> Even after trivial fix (including <linux/sched.h> into
> drivers/staging/rt2860/rt_linux.h) the driver doesn't compile:
>
> drivers/staging/rt2860/rt_main_dev.c: In function 'rt_ieee80211_if_setup':
> drivers/staging/rt2860/rt_main_dev.c:691: error: 'struct net_device' has
> no member named 'wireless_handlers'
For the archives: it just means that CONFIG_WIRELESS_EXT should be enabled.


--
WBR, wRAR (ALT Linux Team)


Attachments:
(No filename) (492.00 B)
signature.asc (490.00 B)
Digital signature
Download all attachments

2009-10-16 19:00:59

by Roland Dreier

[permalink] [raw]
Subject: Re: drivers/staging/rt2860 doesn't compile


> For the archives: it just means that CONFIG_WIRELESS_EXT should be enabled.

Which means the driver should probably do "select WIRELESS_EXT" in
Kconfig. Would be an easy patch to send if you can test it....

2009-10-20 06:24:15

by Andrey Rahmatullin

[permalink] [raw]
Subject: Re: drivers/staging/rt2860 doesn't compile

On Fri, Oct 16, 2009 at 12:00:58PM -0700, Roland Dreier wrote:
> > For the archives: it just means that CONFIG_WIRELESS_EXT should be enabled.
> Which means the driver should probably do "select WIRELESS_EXT" in
> Kconfig.
Yes.

> Would be an easy patch to send if you can test it....
Of course I can :)

--
WBR, wRAR (ALT Linux Team)


Attachments:
(No filename) (337.00 B)
signature.asc (490.00 B)
Digital signature
Download all attachments