2009-10-28 05:14:21

by Jie Yang

Subject: [patch net-next]atl1c: duplicate atl1c_get_tpd

From: Jie Yang <[email protected]>

remove duplicate atl1c_get_tpd, it may cause hardware to send wrong packets.

Signed-off-by: Jie Yang <[email protected]>

---

drivers/net/atl1c/atl1c_main.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/atl1c/atl1c_main.c b/drivers/net/atl1c/atl1c_main.c
index 1372e9a..3b8801a 100644
--- a/drivers/net/atl1c/atl1c_main.c
+++ b/drivers/net/atl1c/atl1c_main.c
@@ -1981,8 +1981,6 @@ static void atl1c_tx_map(struct atl1c_adapter *adapter,
else {
use_tpd = atl1c_get_tpd(adapter, type);
memcpy(use_tpd, tpd, sizeof(struct atl1c_tpd_desc));
- use_tpd = atl1c_get_tpd(adapter, type);
- memcpy(use_tpd, tpd, sizeof(struct atl1c_tpd_desc));
}
buffer_info = atl1c_get_tx_buffer(adapter, use_tpd);
buffer_info->length = buf_len - mapped_len;

2009-10-28 05:31:04

by David Miller

Subject: Re: [patch net-next]atl1c: duplicate atl1c_get_tpd

From: <[email protected]>
Date: Wed, 28 Oct 2009 13:14:15 +0800

> From: Jie Yang <[email protected]>
>
> remove duplicate atl1c_get_tpd, it may cause hardware to send wrong packets.
>
> Signed-off-by: Jie Yang <[email protected]>

Applied, thanks.