2009-11-03 04:36:16

by Hitoshi Mitake

Subject: [RFC][PATCH 1/7] Adding general performance benchmarking subsystem to perf.

Adding general performance benchmarking subsystem to perf.
This patch modifies Makefile of perf to build new source files.

Signed-off-by: Hitoshi Mitake <[email protected]>
Cc: Rusty Russell <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Mike Galbraith <[email protected]>
---
tools/perf/Makefile | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 7e190d5..f6f7a6b 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -391,6 +391,9 @@ BUILTIN_OBJS += builtin-stat.o
BUILTIN_OBJS += builtin-timechart.o
BUILTIN_OBJS += builtin-top.o
BUILTIN_OBJS += builtin-trace.o
+BUILTIN_OBJS += builtin-bench.o
+BUILTIN_OBJS += builtin-bench-messaging.o
+BUILTIN_OBJS += builtin-bench-pipe.o

PERFLIBS = $(LIB_FILE)

--
1.5.6.5

2009-11-03 07:34:10

by Ingo Molnar

Subject: Re: [RFC][PATCH 1/7] Adding general performance benchmarking subsystem to perf.

* Hitoshi Mitake <[email protected]> wrote:

>
> Adding general performance benchmarking subsystem to perf.
> This patch modifies Makefile of perf to build new source files.
>
> Signed-off-by: Hitoshi Mitake <[email protected]>
> Cc: Rusty Russell <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Peter Zijlstra <[email protected]>
> Cc: Mike Galbraith <[email protected]>
> ---
> tools/perf/Makefile | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 7e190d5..f6f7a6b 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -391,6 +391,9 @@ BUILTIN_OBJS += builtin-stat.o
> BUILTIN_OBJS += builtin-timechart.o
> BUILTIN_OBJS += builtin-top.o
> BUILTIN_OBJS += builtin-trace.o
> +BUILTIN_OBJS += builtin-bench.o
> +BUILTIN_OBJS += builtin-bench-messaging.o
> +BUILTIN_OBJS += builtin-bench-pipe.o

The series should be bisectable (i.e. build at every step) - so i'd
suggest to add this Makefile bit to the patch that adds the .c, or move
the .c addition before the Makefile addition patch.

Ingo