2009-11-10 16:38:36

by Ali Gholami Rudi

Subject: [PATCH] ixgbe: r_idx not used in ixgbe_msix_clean_rx()

The values of r_idx and rx_ring are not used after the last time they
are set in ixgbe_msix_clean_rx(), so they can be removed.

Signed-off-by: Ali Gholami Rudi <[email protected]>
---
drivers/net/ixgbe/ixgbe_main.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 5bd9e6b..6541c80 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -1344,8 +1344,6 @@ static irqreturn_t ixgbe_msix_clean_rx(int irq, void *data)
if (!q_vector->rxr_count)
return IRQ_HANDLED;

- r_idx = find_first_bit(q_vector->rxr_idx, adapter->num_rx_queues);
- rx_ring = &(adapter->rx_ring[r_idx]);
/* disable interrupts on this vector only */
ixgbe_irq_disable_queues(adapter, ((u64)1 << q_vector->v_idx));
napi_schedule(&q_vector->napi);

2009-11-10 16:45:11

by Waskiewicz Jr, Peter P

Subject: Re: [PATCH] ixgbe: r_idx not used in ixgbe_msix_clean_rx()

On Tue, 2009-11-10 at 08:40 -0800, Ali Gholami Rudi wrote:
> The values of r_idx and rx_ring are not used after the last time they
> are set in ixgbe_msix_clean_rx(), so they can be removed.
>

Thanks for cleaning this up.

Acked-by: Peter P Waskiewicz Jr <[email protected]>

> Signed-off-by: Ali Gholami Rudi <[email protected]>
> ---
> drivers/net/ixgbe/ixgbe_main.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
> index 5bd9e6b..6541c80 100644
> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -1344,8 +1344,6 @@ static irqreturn_t ixgbe_msix_clean_rx(int irq, void *data)
> if (!q_vector->rxr_count)
> return IRQ_HANDLED;
>
> - r_idx = find_first_bit(q_vector->rxr_idx, adapter->num_rx_queues);
> - rx_ring = &(adapter->rx_ring[r_idx]);
> /* disable interrupts on this vector only */
> ixgbe_irq_disable_queues(adapter, ((u64)1 << q_vector->v_idx));
> napi_schedule(&q_vector->napi);