Which is why I have always preferred sizeof(struct foo) over
sizeof(var).
Signed-off-by: Jean Delvare <[email protected]>
Cc: Richard Purdie <[email protected]>
---
Stable team, this one applies to 2.6.31, 2.6.30 and 2.6.27.
drivers/video/backlight/lcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.32-rc1.orig/drivers/video/backlight/lcd.c 2009-06-10 05:05:27.000000000 +0200
+++ linux-2.6.32-rc1/drivers/video/backlight/lcd.c 2009-10-02 10:18:49.000000000 +0200
@@ -56,7 +56,7 @@ static int fb_notifier_callback(struct n
static int lcd_register_fb(struct lcd_device *ld)
{
- memset(&ld->fb_notif, 0, sizeof(&ld->fb_notif));
+ memset(&ld->fb_notif, 0, sizeof(ld->fb_notif));
ld->fb_notif.notifier_call = fb_notifier_callback;
return fb_register_client(&ld->fb_notif);
}
--
Jean Delvare
On Fri, 2009-10-02 at 11:28 +0200, Jean Delvare wrote:
> Which is why I have always preferred sizeof(struct foo) over
> sizeof(var).
>
> Signed-off-by: Jean Delvare <[email protected]>
> Cc: Richard Purdie <[email protected]>
> ---
> Stable team, this one applies to 2.6.31, 2.6.30 and 2.6.27.
Queued in the backlight tree. I'll wait to see if any other fixes appear
for backlights send to Linus in a few days.
Cheers,
Richard
--
Richard Purdie
Intel Open Source Technology Centre
On Sat, 03 Oct 2009 18:01:49 +0100, Richard Purdie wrote:
> On Fri, 2009-10-02 at 11:28 +0200, Jean Delvare wrote:
> > Which is why I have always preferred sizeof(struct foo) over
> > sizeof(var).
> >
> > Signed-off-by: Jean Delvare <[email protected]>
> > Cc: Richard Purdie <[email protected]>
> > ---
> > Stable team, this one applies to 2.6.31, 2.6.30 and 2.6.27.
>
> Queued in the backlight tree. I'll wait to see if any other fixes appear
> for backlights send to Linus in a few days.
Please don't wait too much before sending this for to Linus.
--
Jean Delvare
On Thu, 15 Oct 2009 11:59:37 +0200, Jean Delvare wrote:
> On Sat, 03 Oct 2009 18:01:49 +0100, Richard Purdie wrote:
> > On Fri, 2009-10-02 at 11:28 +0200, Jean Delvare wrote:
> > > Which is why I have always preferred sizeof(struct foo) over
> > > sizeof(var).
> > >
> > > Signed-off-by: Jean Delvare <[email protected]>
> > > Cc: Richard Purdie <[email protected]>
> > > ---
> > > Stable team, this one applies to 2.6.31, 2.6.30 and 2.6.27.
> >
> > Queued in the backlight tree. I'll wait to see if any other fixes appear
> > for backlights send to Linus in a few days.
>
> Please don't wait too much before sending this for to Linus.
Richard, I still don't see this fix upstream? Would be nice to have it
in 2.6.32.
Thanks,
--
Jean Delvare