2009-11-12 05:34:51

by Nikanth Karthikesan

Subject: [BUILD FAILURE][PATCH] Export symbol log_start_commit. ext3 needs it.

The linus git fails to build with the message
ERROR: "log_start_commit" [fs/ext3/ext3.ko] undefined!
Top commit id: aa021baa3295fa6e3f367d80f8955dd5176656eb

Export log_start_commit to modules. ext3 needs it to be built
as a module.

Signed-off-by: Nikanth Karthikesan <[email protected]>

---

diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index 49d5cd6..2e13cf3 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -72,6 +72,7 @@ EXPORT_SYMBOL(journal_abort);
EXPORT_SYMBOL(journal_errno);
EXPORT_SYMBOL(journal_ack_err);
EXPORT_SYMBOL(journal_clear_err);
+EXPORT_SYMBOL(log_start_commit);
EXPORT_SYMBOL(log_wait_commit);
EXPORT_SYMBOL(journal_start_commit);
EXPORT_SYMBOL(journal_force_commit_nested);

2009-11-12 09:37:30

by Jan Kara

Subject: Re: [BUILD FAILURE][PATCH] Export symbol log_start_commit. ext3 needs it.

On Thu 12-11-09 11:06:52, Nikanth Karthikesan wrote:
> The linus git fails to build with the message
> ERROR: "log_start_commit" [fs/ext3/ext3.ko] undefined!
> Top commit id: aa021baa3295fa6e3f367d80f8955dd5176656eb
>
> Export log_start_commit to modules. ext3 needs it to be built
> as a module.
>
> Signed-off-by: Nikanth Karthikesan <[email protected]>
Thanks! I've already merged a fix.

Honza
>
> ---
>
> diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
> index 49d5cd6..2e13cf3 100644
> --- a/fs/jbd/journal.c
> +++ b/fs/jbd/journal.c
> @@ -72,6 +72,7 @@ EXPORT_SYMBOL(journal_abort);
> EXPORT_SYMBOL(journal_errno);
> EXPORT_SYMBOL(journal_ack_err);
> EXPORT_SYMBOL(journal_clear_err);
> +EXPORT_SYMBOL(log_start_commit);
> EXPORT_SYMBOL(log_wait_commit);
> EXPORT_SYMBOL(journal_start_commit);
> EXPORT_SYMBOL(journal_force_commit_nested);
--
Jan Kara <[email protected]>
SUSE Labs, CR