2009-11-12 01:36:30

by tip-bot for Livio Soares

Subject: [PATCH] ext3/jdb log_start_commit export symbol issue

Hi Jan and all,

It seems like the below patch is necessary when trying to compile ext3 as
a module. I don't know if this is the correct fix (that's up to you), but
without ext3 does not link. The following commit caused the problem:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fe8bc91c4c30122b357d197117705cfd4fabaf28

Cheers,

Livio

Signed-off-by: Livio Soares <[email protected]>

diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index 49d5cd6..4160afa 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -73,6 +73,7 @@ EXPORT_SYMBOL(journal_errno);
EXPORT_SYMBOL(journal_ack_err);
EXPORT_SYMBOL(journal_clear_err);
EXPORT_SYMBOL(log_wait_commit);
+EXPORT_SYMBOL(log_start_commit);
EXPORT_SYMBOL(journal_start_commit);
EXPORT_SYMBOL(journal_force_commit_nested);
EXPORT_SYMBOL(journal_wipe);

2009-11-12 11:24:34

by Jan Kara

Subject: Re: [PATCH] ext3/jdb log_start_commit export symbol issue

On Wed 11-11-09 19:35:45, Livio Soares wrote:
>
> Hi Jan and all,
>
> It seems like the below patch is necessary when trying to compile ext3 as
> a module. I don't know if this is the correct fix (that's up to you), but
> without ext3 does not link. The following commit caused the problem:
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fe8bc91c4c30122b357d197117705cfd4fabaf28
Thanks for notifying me, I've already merged the fix.

Honza
>
> Cheers,
>
> Livio
>
> Signed-off-by: Livio Soares <[email protected]>
>
> diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
> index 49d5cd6..4160afa 100644
> --- a/fs/jbd/journal.c
> +++ b/fs/jbd/journal.c
> @@ -73,6 +73,7 @@ EXPORT_SYMBOL(journal_errno);
> EXPORT_SYMBOL(journal_ack_err);
> EXPORT_SYMBOL(journal_clear_err);
> EXPORT_SYMBOL(log_wait_commit);
> +EXPORT_SYMBOL(log_start_commit);
> EXPORT_SYMBOL(journal_start_commit);
> EXPORT_SYMBOL(journal_force_commit_nested);
> EXPORT_SYMBOL(journal_wipe);
--
Jan Kara <[email protected]>
SUSE Labs, CR