2009-11-13 18:00:15

by Marin Mitov

[permalink] [raw]
Subject: [PATCH]remove deprecated and not used: print_mac()

Hi all,

The function print_mac in net/ethernet/eth.c is marked __deprecated
and not used. Remove it.

The patch is against 2.6.32-rc7.

Signed-off-by: Marin Mitov <[email protected]>

=====================================================================
--- a/include/linux/if_ether.h 2009-11-13 19:16:15.000000000 +0200
+++ b/include/linux/if_ether.h 2009-11-13 19:18:25.000000000 +0200
@@ -136,10 +136,6 @@

extern ssize_t sysfs_format_mac(char *buf, const unsigned char *addr, int len);

-/*
- * Display a 6 byte device address (MAC) in a readable format.
- */
-extern char *print_mac(char *buf, const unsigned char *addr) __deprecated;
#define MAC_FMT "%02x:%02x:%02x:%02x:%02x:%02x"
#define MAC_BUF_SIZE 18
#define DECLARE_MAC_BUF(var) char var[MAC_BUF_SIZE]

--- a/net/ethernet/eth.c 2009-11-13 19:16:30.000000000 +0200
+++ b/net/ethernet/eth.c 2009-11-13 19:20:31.000000000 +0200
@@ -393,10 +393,3 @@
return ((ssize_t) l);
}
EXPORT_SYMBOL(sysfs_format_mac);
-
-char *print_mac(char *buf, const unsigned char *addr)
-{
- _format_mac_addr(buf, MAC_BUF_SIZE, addr, ETH_ALEN);
- return buf;
-}
-EXPORT_SYMBOL(print_mac);


2009-11-16 06:22:42

by David Miller

[permalink] [raw]
Subject: Re: [PATCH]remove deprecated and not used: print_mac()

From: Marin Mitov <[email protected]>
Date: Fri, 13 Nov 2009 19:58:41 +0200

> The function print_mac in net/ethernet/eth.c is marked __deprecated
> and not used. Remove it.
>
> The patch is against 2.6.32-rc7.
>
> Signed-off-by: Marin Mitov <[email protected]>

Applied, thanks.