2009-11-12 16:41:20

by Roel Kluin

Subject: [PATCH] mISDN: fix error return in HFCmulti_init()

The returned error should stay negative

Signed-off-by: Roel Kluin <[email protected]>
---
drivers/isdn/hardware/mISDN/hfcmulti.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c b/drivers/isdn/hardware/mISDN/hfcmulti.c
index faed794..a6624ad 100644
--- a/drivers/isdn/hardware/mISDN/hfcmulti.c
+++ b/drivers/isdn/hardware/mISDN/hfcmulti.c
@@ -5481,7 +5481,7 @@ HFCmulti_init(void)
if (err) {
printk(KERN_ERR "error registering embedded driver: "
"%x\n", err);
- return -err;
+ return err;
}
HFC_cnt++;
printk(KERN_INFO "%d devices registered\n", HFC_cnt);

2009-11-13 12:17:17

by Karsten Keil

Subject: Re: [PATCH] mISDN: fix error return in HFCmulti_init()

On Donnerstag, 12. November 2009 17:53:25 Roel Kluin wrote:
The returned error should stay negative

Signed-off-by: Roel Kluin <[email protected]>
Acked-by: Karsten Keil <[email protected]>
---
drivers/isdn/hardware/mISDN/hfcmulti.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c
b/drivers/isdn/hardware/mISDN/hfcmulti.c index faed794..a6624ad 100644
--- a/drivers/isdn/hardware/mISDN/hfcmulti.c
+++ b/drivers/isdn/hardware/mISDN/hfcmulti.c
@@ -5481,7 +5481,7 @@ HFCmulti_init(void)
if (err) {
printk(KERN_ERR "error registering embedded driver: "
"%x\n", err);
- return -err;
+ return err;
}
HFC_cnt++;
printk(KERN_INFO "%d devices registered\n", HFC_cnt);

2009-11-16 05:18:05

by David Miller

Subject: Re: [PATCH] mISDN: fix error return in HFCmulti_init()

From: Karsten Keil <[email protected]>
Date: Fri, 13 Nov 2009 13:17:10 +0100

> On Donnerstag, 12. November 2009 17:53:25 Roel Kluin wrote:
> The returned error should stay negative
>
> Signed-off-by: Roel Kluin <[email protected]>
> Acked-by: Karsten Keil <[email protected]>

Applied.