2009-11-24 11:16:40

by Mark Brown

Subject: [PATCH] mfd: Remove build time warning for WM835x register default tables

Systems using the WM835x need to choose which of the default register
settings are required on the system. Currently there is a compile time
warning as well as a runtime error intended to flag up to users that
this is required but this also triggers for people building the driver
in order to obtain build coverage.

Remove the build warning, leaving only the runtime error, in order to
reduce noise for people doing generic kernel work.

Signed-off-by: Mark Brown <[email protected]>
---
drivers/mfd/wm8350-regmap.c | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/drivers/mfd/wm8350-regmap.c b/drivers/mfd/wm8350-regmap.c
index 7ccc1ea..e965139 100644
--- a/drivers/mfd/wm8350-regmap.c
+++ b/drivers/mfd/wm8350-regmap.c
@@ -3170,14 +3170,6 @@ const u16 wm8352_mode3_defaults[] = {
};
#endif

-/* The register defaults for the config mode used must be compiled in but
- * due to the impact on kernel size it is possible to disable
- */
-#ifndef WM8350_HAVE_CONFIG_MODE
-#warning No WM8350 config modes supported - select at least one of the
-#warning MFD_WM8350_CONFIG_MODE_n options from the board driver.
-#endif
-
/*
* Access masks.
*/
--
1.6.3.3

2009-11-24 23:18:44

by Samuel Ortiz

Subject: Re: [PATCH] mfd: Remove build time warning for WM835x register default tables

On Tue, Nov 24, 2009 at 11:16:45AM +0000, Mark Brown wrote:
> Systems using the WM835x need to choose which of the default register
> settings are required on the system. Currently there is a compile time
> warning as well as a runtime error intended to flag up to users that
> this is required but this also triggers for people building the driver
> in order to obtain build coverage.
Patch applied, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/