2009-11-25 17:18:26

by Youquan Song

Subject: [PATCH]crypto: Fix ghash pclmulqdqni algorithm without test

when load ghash-clmulni-intel driver,kernel will report no test for some algorithm
with PCLMULQDQ NI. The strange information as following:

alg: No test for __ghash (__ghash-pclmulqdqni)
alg: No test for __ghash (cryptd(__ghash-pclmulqdqni))

crypto_alg's cra_name is use to descript algorithm itself, do not care the
concrete implement. So this patch unify them and also can fix the algorithm
implementation without test.

Signed-off-by: Youquan, Song <[email protected]>
---

diff --git a/arch/x86/crypto/ghash-clmulni-intel_glue.c b/arch/x86/crypto/ghash-clmulni-intel_glue.c
index cbcc8d8..3fab6cb 100644
--- a/arch/x86/crypto/ghash-clmulni-intel_glue.c
+++ b/arch/x86/crypto/ghash-clmulni-intel_glue.c
@@ -141,7 +141,7 @@ static struct shash_alg ghash_alg = {
.setkey = ghash_setkey,
.descsize = sizeof(struct ghash_desc_ctx),
.base = {
- .cra_name = "__ghash",
+ .cra_name = "ghash",
.cra_driver_name = "__ghash-pclmulqdqni",
.cra_priority = 0,
.cra_flags = CRYPTO_ALG_TYPE_SHASH,

2009-11-26 00:14:12

by Herbert Xu

Subject: Re: [PATCH]crypto: Fix ghash pclmulqdqni algorithm without test

On Wed, Nov 25, 2009 at 07:46:33PM -0500, Youquan,Song wrote:
> when load ghash-clmulni-intel driver,kernel will report no test for some algorithm
> with PCLMULQDQ NI. The strange information as following:
>
> alg: No test for __ghash (__ghash-pclmulqdqni)
> alg: No test for __ghash (cryptd(__ghash-pclmulqdqni))
>
> crypto_alg's cra_name is use to descript algorithm itself, do not care the
> concrete implement. So this patch unify them and also can fix the algorithm
> implementation without test.
>
> Signed-off-by: Youquan, Song <[email protected]>

Please talk to Huang Ying who wrote these patches. Thanks!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt