2009-12-02 08:10:15

by Xiao Guangrong

Subject: [PATCH] perf_event: fix compile error

cc1: warnings being treated as errors
builtin-probe.c: In function ‘cmd_probe’:
builtin-probe.c:163: error: unused variable ‘fd’

Signed-off-by: Xiao Guangrong <[email protected]>
---
tools/perf/builtin-probe.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
index b5d15cf..64ea038 100644
--- a/tools/perf/builtin-probe.c
+++ b/tools/perf/builtin-probe.c
@@ -160,7 +160,8 @@ static const struct option options[] = {

int cmd_probe(int argc, const char **argv, const char *prefix __used)
{
- int i, j, fd, ret;
+ int i, j, ret;
+ int fd __used;
struct probe_point *pp;

argc = parse_options(argc, argv, options, probe_usage,
--
1.6.1.2

2009-12-02 08:17:45

by Ingo Molnar

Subject: Re: [PATCH] perf_event: fix compile error

* Xiao Guangrong <[email protected]> wrote:

> cc1: warnings being treated as errors
> builtin-probe.c: In function ???cmd_probe???:
> builtin-probe.c:163: error: unused variable ???fd???
>
> Signed-off-by: Xiao Guangrong <[email protected]>
> ---
> tools/perf/builtin-probe.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
> index b5d15cf..64ea038 100644
> --- a/tools/perf/builtin-probe.c
> +++ b/tools/perf/builtin-probe.c
> @@ -160,7 +160,8 @@ static const struct option options[] = {
>
> int cmd_probe(int argc, const char **argv, const char *prefix __used)
> {
> - int i, j, fd, ret;
> + int i, j, ret;
> + int fd __used;
> struct probe_point *pp;

i think it's better to initialize it to -1 instead of turning off the
warning.

Ingo

2009-12-02 08:23:25

by Xiao Guangrong

Subject: Re: [PATCH] perf_event: fix compile error

Ingo Molnar wrote:
> * Xiao Guangrong <[email protected]> wrote:
>
>> cc1: warnings being treated as errors
>> builtin-probe.c: In function ???cmd_probe???:
>> builtin-probe.c:163: error: unused variable ???fd???
>>
>> Signed-off-by: Xiao Guangrong <[email protected]>
>> ---
>> tools/perf/builtin-probe.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
>> index b5d15cf..64ea038 100644
>> --- a/tools/perf/builtin-probe.c
>> +++ b/tools/perf/builtin-probe.c
>> @@ -160,7 +160,8 @@ static const struct option options[] = {
>>
>> int cmd_probe(int argc, const char **argv, const char *prefix __used)
>> {
>> - int i, j, fd, ret;
>> + int i, j, ret;
>> + int fd __used;
>> struct probe_point *pp;
>
> i think it's better to initialize it to -1 instead of turning off the
> warning.
>

Hi Ingo,

I have try this way but the error still exists :-(

Thanks,
Xiao

2009-12-02 08:28:10

by Ingo Molnar

Subject: Re: [PATCH] perf_event: fix compile error

* Xiao Guangrong <[email protected]> wrote:

> Ingo Molnar wrote:
> > * Xiao Guangrong <[email protected]> wrote:
> >
> >> cc1: warnings being treated as errors
> >> builtin-probe.c: In function ???cmd_probe???:
> >> builtin-probe.c:163: error: unused variable ???fd???
> >>
> >> Signed-off-by: Xiao Guangrong <[email protected]>
> >> ---
> >> tools/perf/builtin-probe.c | 3 ++-
> >> 1 files changed, 2 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
> >> index b5d15cf..64ea038 100644
> >> --- a/tools/perf/builtin-probe.c
> >> +++ b/tools/perf/builtin-probe.c
> >> @@ -160,7 +160,8 @@ static const struct option options[] = {
> >>
> >> int cmd_probe(int argc, const char **argv, const char *prefix __used)
> >> {
> >> - int i, j, fd, ret;
> >> + int i, j, ret;
> >> + int fd __used;
> >> struct probe_point *pp;
> >
> > i think it's better to initialize it to -1 instead of turning off the
> > warning.
> >
>
> Hi Ingo,
>
> I have try this way but the error still exists :-(

ah - unused, not uninitialized.

Then the right fix is to use NO_LIBDWARF, not __used annotation. I've
changed it to that and committed your fix - thanks!

Ingo

2009-12-02 08:32:04

by Xiao Guangrong

Subject: [tip:perf/core] perf_event: Fix compile error

Commit-ID: bdad0db7dbdb37d0bb3c7d0f65cd3ff599ea6ecb
Gitweb: http://git.kernel.org/tip/bdad0db7dbdb37d0bb3c7d0f65cd3ff599ea6ecb
Author: Xiao Guangrong <[email protected]>
AuthorDate: Wed, 2 Dec 2009 16:08:41 +0800
Committer: Ingo Molnar <[email protected]>
CommitDate: Wed, 2 Dec 2009 09:27:01 +0100

perf_event: Fix compile error

Fix:

cc1: warnings being treated as errors
builtin-probe.c: In function 'cmd_probe':
builtin-probe.c:163: error: unused variable 'fd'

Signed-off-by: Xiao Guangrong <[email protected]>
Cc: Masami Hiramatsu <[email protected]>
Cc: Peter Zijlstra <[email protected]>
LKML-Reference: <[email protected]>
[ v2: use NO_LIBDWARF instead of __used ]
Signed-off-by: Ingo Molnar <[email protected]>
---
tools/perf/builtin-probe.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
index b5d15cf..a58e11b 100644
--- a/tools/perf/builtin-probe.c
+++ b/tools/perf/builtin-probe.c
@@ -160,7 +160,10 @@ static const struct option options[] = {

int cmd_probe(int argc, const char **argv, const char *prefix __used)
{
- int i, j, fd, ret;
+ int i, j, ret;
+#ifndef NO_LIBDWARF
+ int fd;
+#endif
struct probe_point *pp;

argc = parse_options(argc, argv, options, probe_usage,