Michel, Darrick,
Apparently you are using the therm_adt746x driver, so maybe you would
be interested in testing and carrying the following patch. I've sent it
to Colin Leroy, who is listed as the maintainer for this driver, 1.5
month ago, but did not hear back.
* * * * *
The ADT746x don't have any register at sub-address 0, so better use an
existing register for the initial test read.
Signed-off-by: Jean Delvare <[email protected]>
Tested-by: Tim Shepard <[email protected]>
Cc: Colin Leroy <[email protected]>
Cc: Benjamin Herrenschmidt <[email protected]>
Cc: Paul Mackerras <[email protected]>
---
drivers/macintosh/therm_adt746x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.32-rc4.orig/drivers/macintosh/therm_adt746x.c 2009-10-12 11:53:59.000000000 +0200
+++ linux-2.6.32-rc4/drivers/macintosh/therm_adt746x.c 2009-10-14 17:27:46.000000000 +0200
@@ -387,7 +387,7 @@ static int probe_thermostat(struct i2c_c
i2c_set_clientdata(client, th);
th->clt = client;
- rc = read_reg(th, 0);
+ rc = read_reg(th, CONFIG_REG);
if (rc < 0) {
dev_err(&client->dev, "Thermostat failed to read config!\n");
kfree(th);
--
Jean Delvare
On Wed, 2009-12-02 at 09:19 +0100, Jean Delvare wrote:
> Michel, Darrick,
>
> Apparently you are using the therm_adt746x driver, so maybe you would
> be interested in testing and carrying the following patch. I've sent it
> to Colin Leroy, who is listed as the maintainer for this driver, 1.5
> month ago, but did not hear back.
The driver seems to load and work fine here (on a PowerBook5,8) with the
patch, so feel free to add a Tested-By: line for me.
> * * * * *
>
> The ADT746x don't have any register at sub-address 0, so better use an
> existing register for the initial test read.
>
> Signed-off-by: Jean Delvare <[email protected]>
> Tested-by: Tim Shepard <[email protected]>
> Cc: Colin Leroy <[email protected]>
> Cc: Benjamin Herrenschmidt <[email protected]>
> Cc: Paul Mackerras <[email protected]>
> ---
> drivers/macintosh/therm_adt746x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.32-rc4.orig/drivers/macintosh/therm_adt746x.c 2009-10-12 11:53:59.000000000 +0200
> +++ linux-2.6.32-rc4/drivers/macintosh/therm_adt746x.c 2009-10-14 17:27:46.000000000 +0200
> @@ -387,7 +387,7 @@ static int probe_thermostat(struct i2c_c
> i2c_set_clientdata(client, th);
> th->clt = client;
>
> - rc = read_reg(th, 0);
> + rc = read_reg(th, CONFIG_REG);
> if (rc < 0) {
> dev_err(&client->dev, "Thermostat failed to read config!\n");
> kfree(th);
>
>
--
Earthling Michel Dänzer | http://www.vmware.com
Libre software enthusiast | Debian, X and DRI developer
On Wed, 02 Dec 2009 09:54:02 +0100, Michel D?nzer wrote:
> On Wed, 2009-12-02 at 09:19 +0100, Jean Delvare wrote:
> > Michel, Darrick,
> >
> > Apparently you are using the therm_adt746x driver, so maybe you would
> > be interested in testing and carrying the following patch. I've sent it
> > to Colin Leroy, who is listed as the maintainer for this driver, 1.5
> > month ago, but did not hear back.
>
> The driver seems to load and work fine here (on a PowerBook5,8) with the
> patch, so feel free to add a Tested-By: line for me.
Will do, thanks.
BTW, I also have i2c-powermac patches queued for 2.6.33 if you want to
give them a try:
ftp://ftp.kernel.org/pub/linux/kernel/people/jdelvare/linux-2.6/jdelvare-i2c/i2c-powermac-*.patch
(Don't look for patch 5/6, it was broken so I discarded it.)
--
Jean Delvare
On Wed, 2009-12-02 at 10:10 +0100, Jean Delvare wrote:
> On Wed, 02 Dec 2009 09:54:02 +0100, Michel Dänzer wrote:
> > On Wed, 2009-12-02 at 09:19 +0100, Jean Delvare wrote:
> > > Michel, Darrick,
> > >
> > > Apparently you are using the therm_adt746x driver, so maybe you would
> > > be interested in testing and carrying the following patch. I've sent it
> > > to Colin Leroy, who is listed as the maintainer for this driver, 1.5
> > > month ago, but did not hear back.
> >
> > The driver seems to load and work fine here (on a PowerBook5,8) with the
> > patch, so feel free to add a Tested-By: line for me.
>
> Will do, thanks.
>
> BTW, I also have i2c-powermac patches queued for 2.6.33 if you want to
> give them a try:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/jdelvare/linux-2.6/jdelvare-i2c/i2c-powermac-*.patch
>
> (Don't look for patch 5/6, it was broken so I discarded it.)
My PowerBook5,8 boots and works fine with all of these applied and
CONFIG_I2C_POWERMAC=y, so for all of them:
Tested-by: Michel Dänzer <[email protected]>
--
Earthling Michel Dänzer | http://www.vmware.com
Libre software enthusiast | Debian, X and DRI developer
On Thu, 03 Dec 2009 11:24:06 +0100, Michel Dänzer wrote:
> On Wed, 2009-12-02 at 10:10 +0100, Jean Delvare wrote:
> > BTW, I also have i2c-powermac patches queued for 2.6.33 if you want to
> > give them a try:
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/jdelvare/linux-2.6/jdelvare-i2c/i2c-powermac-*.patch
> >
> > (Don't look for patch 5/6, it was broken so I discarded it.)
>
> My PowerBook5,8 boots and works fine with all of these applied and
> CONFIG_I2C_POWERMAC=y, so for all of them:
>
> Tested-by: Michel Dänzer <[email protected]>
Very nice, thank you!
--
Jean Delvare
On Wed, 2009-12-02 at 09:19 +0100, Jean Delvare wrote:
> Michel, Darrick,
>
> Apparently you are using the therm_adt746x driver, so maybe you would
> be interested in testing and carrying the following patch. I've sent it
> to Colin Leroy, who is listed as the maintainer for this driver, 1.5
> month ago, but did not hear back.
I will take it.
Basic rule is: CC to [email protected] ;-)
That way it gets picked up by patchwork and doesn't get lost. Even if it
goes low on my priority list it will not be lost and I'll eventually
pick it up.
Cheers,
Ben.
> * * * * *
>
> The ADT746x don't have any register at sub-address 0, so better use an
> existing register for the initial test read.
>
> Signed-off-by: Jean Delvare <[email protected]>
> Tested-by: Tim Shepard <[email protected]>
> Cc: Colin Leroy <[email protected]>
> Cc: Benjamin Herrenschmidt <[email protected]>
> Cc: Paul Mackerras <[email protected]>
> ---
> drivers/macintosh/therm_adt746x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.32-rc4.orig/drivers/macintosh/therm_adt746x.c 2009-10-12 11:53:59.000000000 +0200
> +++ linux-2.6.32-rc4/drivers/macintosh/therm_adt746x.c 2009-10-14 17:27:46.000000000 +0200
> @@ -387,7 +387,7 @@ static int probe_thermostat(struct i2c_c
> i2c_set_clientdata(client, th);
> th->clt = client;
>
> - rc = read_reg(th, 0);
> + rc = read_reg(th, CONFIG_REG);
> if (rc < 0) {
> dev_err(&client->dev, "Thermostat failed to read config!\n");
> kfree(th);
>
>
Hi Benjamin,
On Fri, 04 Dec 2009 13:40:54 +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2009-12-02 at 09:19 +0100, Jean Delvare wrote:
> > Michel, Darrick,
> >
> > Apparently you are using the therm_adt746x driver, so maybe you would
> > be interested in testing and carrying the following patch. I've sent it
> > to Colin Leroy, who is listed as the maintainer for this driver, 1.5
> > month ago, but did not hear back.
>
> I will take it.
Thanks.
> Basic rule is: CC to [email protected] ;-)
>
> That way it gets picked up by patchwork and doesn't get lost. Even if it
> goes low on my priority list it will not be lost and I'll eventually
> pick it up.
I've sent it to [email protected] on October 14th. This is the
address which is listed 22 times in MAINTAINERS. If it isn't correct,
then please update MAINTAINERS.
Also note that:
$ scripts/get_maintainer.pl --file drivers/macintosh/therm_adt746x.c
Colin Leroy <[email protected]>
Grant Likely <[email protected]>
[email protected]
[email protected]
This lists Colin Leroy, who apparently doesn't exactly care about the
driver, but not linuxppc-dev@*ozlabs.org where you say patches should
be sent.
--
Jean Delvare
On Fri, 2009-12-04 at 10:34 +0100, Jean Delvare wrote:
>
> I've sent it to [email protected] on October 14th. This is the
> address which is listed 22 times in MAINTAINERS. If it isn't correct,
> then please update MAINTAINERS.
No it's fine both shoul work. Your patches are there, just waiting for
me to pick them up, I was just firing a reminder to the rest of the CC
list :-) (and I do remember fwd'ing a couple of your patches to the
list, for some reason they didn't make it to patchwork back then, that
was a few month ago).
Anyways, I've been stretched thin with all sort of stuff lately, so bear
with me if I'm a bit slow at taking or testing stuff, I'm doing my best.
Cheers,
Ben.
On Fri, 4 Dec 2009 10:34:34 +0100, Jean Delvare wrote:
Hi,
> $ scripts/get_maintainer.pl --file drivers/macintosh/therm_adt746x.c
> Colin Leroy <[email protected]>
> Grant Likely <[email protected]>
> [email protected]
> [email protected]
>
> This lists Colin Leroy, who apparently doesn't exactly care about the
> driver, but not linuxppc-dev@*ozlabs.org where you say patches should
> be sent.
I'm sorry, I thought I wasn't listed as a maintainer anymore for
this... I don't have the hardware anymore.
--
Colin
Hi Colin,
On Fri, 4 Dec 2009 11:20:00 +0100, Colin Leroy wrote:
> On Fri, 4 Dec 2009 10:34:34 +0100, Jean Delvare wrote:
> > $ scripts/get_maintainer.pl --file drivers/macintosh/therm_adt746x.c
> > Colin Leroy <[email protected]>
> > Grant Likely <[email protected]>
> > [email protected]
> > [email protected]
> >
> > This lists Colin Leroy, who apparently doesn't exactly care about the
> > driver, but not linuxppc-dev@*ozlabs.org where you say patches should
> > be sent.
>
> I'm sorry, I thought I wasn't listed as a maintainer anymore for
> this... I don't have the hardware anymore.
Care to submit a patch removing the "ADT746X FAN DRIVER" entry from
MAINTAINERS then? Unless someone volunteers quickly to take over.
--
Jean Delvare
On Fri, 2009-12-04 at 20:59 +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2009-12-04 at 10:34 +0100, Jean Delvare wrote:
> > I've sent it to [email protected] on October 14th. This is the
> > address which is listed 22 times in MAINTAINERS. If it isn't correct,
> > then please update MAINTAINERS.
> No it's fine both shoul work. Your patches are there, just waiting for
> me to pick them up, I was just firing a reminder to the rest of the CC
> list :-) (and I do remember fwd'ing a couple of your patches to the
> list, for some reason they didn't make it to patchwork back then, that
> was a few month ago).
> Anyways, I've been stretched thin with all sort of stuff lately, so bear
> with me if I'm a bit slow at taking or testing stuff, I'm doing my best.
Adding patterns to the PowerPC sections of MAINTAINERS is useful.
Signed-off-by: Joe Perches <[email protected]>
diff --git a/MAINTAINERS b/MAINTAINERS
index 4f96ac8..c7f8e5a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3193,6 +3193,7 @@ LINUX FOR IBM pSERIES (RS/6000)
M: Paul Mackerras <[email protected]>
W: http://www.ibm.com/linux/ltc/projects/ppc
S: Supported
+F: arch/powerpc/boot/rs6000.h
LINUX FOR POWERPC (32-BIT AND 64-BIT)
M: Benjamin Herrenschmidt <[email protected]>
@@ -3201,18 +3202,24 @@ W: http://www.penguinppc.org/
L: [email protected]
T: git git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git
S: Supported
+F: Documentation/powerpc/
+F: arch/powerpc/
LINUX FOR POWER MACINTOSH
M: Benjamin Herrenschmidt <[email protected]>
W: http://www.penguinppc.org/
L: [email protected]
S: Maintained
+F: arch/powerpc/platforms/powermac/
+F: drivers/macintosh/
LINUX FOR POWERPC EMBEDDED MPC5XXX
M: Grant Likely <[email protected]>
L: [email protected]
T: git git://git.secretlab.ca/git/linux-2.6.git
S: Maintained
+F: arch/powerpc/platforms/512x/
+F: arch/powerpc/platforms/52xx/
LINUX FOR POWERPC EMBEDDED PPC4XX
M: Josh Boyer <[email protected]>
@@ -3221,6 +3228,8 @@ W: http://www.penguinppc.org/
L: [email protected]
T: git git://git.kernel.org/pub/scm/linux/kernel/git/jwboyer/powerpc-4xx.git
S: Maintained
+F: arch/powerpc/platforms/40x/
+F: arch/powerpc/platforms/44x/
LINUX FOR POWERPC EMBEDDED XILINX VIRTEX
M: Grant Likely <[email protected]>
@@ -3228,6 +3237,8 @@ W: http://wiki.secretlab.ca/index.php/Linux_on_Xilinx_Virtex
L: [email protected]
T: git git://git.secretlab.ca/git/linux-2.6.git
S: Maintained
+F: arch/powerpc/*/*virtex*
+F: arch/powerpc/*/*/*virtex*
LINUX FOR POWERPC EMBEDDED PPC8XX
M: Vitaly Bordug <[email protected]>
@@ -3241,12 +3252,16 @@ M: Kumar Gala <[email protected]>
W: http://www.penguinppc.org/
L: [email protected]
S: Maintained
+F: arch/powerpc/platforms/83xx/
LINUX FOR POWERPC PA SEMI PWRFICIENT
M: Olof Johansson <[email protected]>
W: http://www.pasemi.com/
L: [email protected]
S: Supported
+F: arch/powerpc/platforms/pasemi/
+F: drivers/*/*pasemi*
+F: drivers/*/*/*pasemi*
LINUX SECURITY MODULE (LSM) FRAMEWORK
M: Chris Wright <[email protected]>
On Fri, Dec 04, 2009 at 09:16:59AM -0800, Joe Perches wrote:
> LINUX FOR POWERPC EMBEDDED PPC4XX
> M: Josh Boyer <[email protected]>
>@@ -3221,6 +3228,8 @@ W: http://www.penguinppc.org/
> L: [email protected]
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/jwboyer/powerpc-4xx.git
> S: Maintained
>+F: arch/powerpc/platforms/40x/
>+F: arch/powerpc/platforms/44x/
This is mostly complete. There are a few files under arch/powerpc/sysdev/, and
arch/powerpc/boot/ as well, but I don't think they're entirely necessary.
For the 4xx parts:
Acked-by: Josh Boyer <[email protected]>
josh
On Fri, Dec 4, 2009 at 10:39 AM, Josh Boyer <[email protected]> wrote:
> On Fri, Dec 04, 2009 at 09:16:59AM -0800, Joe Perches wrote:
>> LINUX FOR POWERPC EMBEDDED PPC4XX
>> M: ? ?Josh Boyer <[email protected]>
>>@@ -3221,6 +3228,8 @@ W: ? ? ? http://www.penguinppc.org/
>> L: ? [email protected]
>> T: ? ?git git://git.kernel.org/pub/scm/linux/kernel/git/jwboyer/powerpc-4xx.git
>> S: ? ?Maintained
>>+F: ? ?arch/powerpc/platforms/40x/
>>+F: ? ?arch/powerpc/platforms/44x/
>
> This is mostly complete. ?There are a few files under arch/powerpc/sysdev/, and
> arch/powerpc/boot/ as well, but I don't think they're entirely necessary.
>
> For the 4xx parts:
>
> Acked-by: Josh Boyer <[email protected]>
Acked-by: Grant Likely <[email protected]>
On Fri, Dec 04, 2009 at 09:16:59AM -0800, Joe Perches wrote:
> On Fri, 2009-12-04 at 20:59 +1100, Benjamin Herrenschmidt wrote:
> > On Fri, 2009-12-04 at 10:34 +0100, Jean Delvare wrote:
> > > I've sent it to [email protected] on October 14th. This is the
> > > address which is listed 22 times in MAINTAINERS. If it isn't correct,
> > > then please update MAINTAINERS.
> > No it's fine both shoul work. Your patches are there, just waiting for
> > me to pick them up, I was just firing a reminder to the rest of the CC
> > list :-) (and I do remember fwd'ing a couple of your patches to the
> > list, for some reason they didn't make it to patchwork back then, that
> > was a few month ago).
> > Anyways, I've been stretched thin with all sort of stuff lately, so bear
> > with me if I'm a bit slow at taking or testing stuff, I'm doing my best.
>
> Adding patterns to the PowerPC sections of MAINTAINERS is useful.
>
> Signed-off-by: Joe Perches <[email protected]>
Acked-by: Olof Johansson <[email protected]>
There are a few other files under arch/powerpc that's not under platforms
that belongs to the pasemi code but it's not a big deal to not include
them. This goes most of the way.
-Olof
On Thu, Dec 03, 2009 at 11:24:06AM +0100, Michel D?nzer wrote:
> On Wed, 2009-12-02 at 10:10 +0100, Jean Delvare wrote:
> > On Wed, 02 Dec 2009 09:54:02 +0100, Michel D?nzer wrote:
> > > On Wed, 2009-12-02 at 09:19 +0100, Jean Delvare wrote:
> > > > Michel, Darrick,
> > > >
> > > > Apparently you are using the therm_adt746x driver, so maybe you would
> > > > be interested in testing and carrying the following patch. I've sent it
> > > > to Colin Leroy, who is listed as the maintainer for this driver, 1.5
> > > > month ago, but did not hear back.
> > >
> > > The driver seems to load and work fine here (on a PowerBook5,8) with the
> > > patch, so feel free to add a Tested-By: line for me.
> >
> > Will do, thanks.
> >
> > BTW, I also have i2c-powermac patches queued for 2.6.33 if you want to
> > give them a try:
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/jdelvare/linux-2.6/jdelvare-i2c/i2c-powermac-*.patch
> >
> > (Don't look for patch 5/6, it was broken so I discarded it.)
>
> My PowerBook5,8 boots and works fine with all of these applied and
> CONFIG_I2C_POWERMAC=y, so for all of them:
>
> Tested-by: Michel D?nzer <[email protected]>
Patch set seems to work with CONFIG_I2C_POWERMAC=y just fine on my
PowerBook6,3, so
Tested-by: Darrick J. Wong <[email protected]>
--D
On Fri, 2009-12-04 at 09:16 -0800, Joe Perches wrote:
> On Fri, 2009-12-04 at 20:59 +1100, Benjamin Herrenschmidt wrote:
> > On Fri, 2009-12-04 at 10:34 +0100, Jean Delvare wrote:
> > > I've sent it to [email protected] on October 14th. This is the
> > > address which is listed 22 times in MAINTAINERS. If it isn't correct,
> > > then please update MAINTAINERS.
> > No it's fine both shoul work. Your patches are there, just waiting for
> > me to pick them up, I was just firing a reminder to the rest of the CC
> > list :-) (and I do remember fwd'ing a couple of your patches to the
> > list, for some reason they didn't make it to patchwork back then, that
> > was a few month ago).
> > Anyways, I've been stretched thin with all sort of stuff lately, so bear
> > with me if I'm a bit slow at taking or testing stuff, I'm doing my best.
>
> Adding patterns to the PowerPC sections of MAINTAINERS is useful.
>
> Signed-off-by: Joe Perches <[email protected]>
Acked-by: Benjamin Herrenschmidt <[email protected]>
---
Are you going to submit that yourself or do you want me to carry it in
the powerpc tree ?
Cheers,
Ben.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4f96ac8..c7f8e5a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3193,6 +3193,7 @@ LINUX FOR IBM pSERIES (RS/6000)
> M: Paul Mackerras <[email protected]>
> W: http://www.ibm.com/linux/ltc/projects/ppc
> S: Supported
> +F: arch/powerpc/boot/rs6000.h
>
> LINUX FOR POWERPC (32-BIT AND 64-BIT)
> M: Benjamin Herrenschmidt <[email protected]>
> @@ -3201,18 +3202,24 @@ W: http://www.penguinppc.org/
> L: [email protected]
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git
> S: Supported
> +F: Documentation/powerpc/
> +F: arch/powerpc/
>
> LINUX FOR POWER MACINTOSH
> M: Benjamin Herrenschmidt <[email protected]>
> W: http://www.penguinppc.org/
> L: [email protected]
> S: Maintained
> +F: arch/powerpc/platforms/powermac/
> +F: drivers/macintosh/
>
> LINUX FOR POWERPC EMBEDDED MPC5XXX
> M: Grant Likely <[email protected]>
> L: [email protected]
> T: git git://git.secretlab.ca/git/linux-2.6.git
> S: Maintained
> +F: arch/powerpc/platforms/512x/
> +F: arch/powerpc/platforms/52xx/
>
> LINUX FOR POWERPC EMBEDDED PPC4XX
> M: Josh Boyer <[email protected]>
> @@ -3221,6 +3228,8 @@ W: http://www.penguinppc.org/
> L: [email protected]
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/jwboyer/powerpc-4xx.git
> S: Maintained
> +F: arch/powerpc/platforms/40x/
> +F: arch/powerpc/platforms/44x/
>
> LINUX FOR POWERPC EMBEDDED XILINX VIRTEX
> M: Grant Likely <[email protected]>
> @@ -3228,6 +3237,8 @@ W: http://wiki.secretlab.ca/index.php/Linux_on_Xilinx_Virtex
> L: [email protected]
> T: git git://git.secretlab.ca/git/linux-2.6.git
> S: Maintained
> +F: arch/powerpc/*/*virtex*
> +F: arch/powerpc/*/*/*virtex*
>
> LINUX FOR POWERPC EMBEDDED PPC8XX
> M: Vitaly Bordug <[email protected]>
> @@ -3241,12 +3252,16 @@ M: Kumar Gala <[email protected]>
> W: http://www.penguinppc.org/
> L: [email protected]
> S: Maintained
> +F: arch/powerpc/platforms/83xx/
>
> LINUX FOR POWERPC PA SEMI PWRFICIENT
> M: Olof Johansson <[email protected]>
> W: http://www.pasemi.com/
> L: [email protected]
> S: Supported
> +F: arch/powerpc/platforms/pasemi/
> +F: drivers/*/*pasemi*
> +F: drivers/*/*/*pasemi*
>
> LINUX SECURITY MODULE (LSM) FRAMEWORK
> M: Chris Wright <[email protected]>
>
On Tue, 2009-12-08 at 15:56 +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2009-12-04 at 09:16 -0800, Joe Perches wrote:
> > Adding patterns to the PowerPC sections of MAINTAINERS is useful.
> > Signed-off-by: Joe Perches <[email protected]>
> Acked-by: Benjamin Herrenschmidt <[email protected]>
> Are you going to submit that yourself or do you want me to carry it in
> the powerpc tree ?
It'd be better if you carry it.
cheers, Joe