2009-12-07 13:29:56

by Roel Kluin

Subject: [PATCH] s390: PTR_ERR return of wrong pointer in fallback_init_cip()

Return the PTR_ERR of the correct pointer.

Signed-off-by: Roel Kluin <[email protected]>
---
arch/s390/crypto/aes_s390.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/s390/crypto/aes_s390.c b/arch/s390/crypto/aes_s390.c
index 6118890..6be4503 100644
--- a/arch/s390/crypto/aes_s390.c
+++ b/arch/s390/crypto/aes_s390.c
@@ -174,7 +174,7 @@ static int fallback_init_cip(struct crypto_tfm *tfm)
if (IS_ERR(sctx->fallback.cip)) {
pr_err("Allocating AES fallback algorithm %s failed\n",
name);
- return PTR_ERR(sctx->fallback.blk);
+ return PTR_ERR(sctx->fallback.cip);
}

return 0;

2009-12-07 14:03:18

by Martin Schwidefsky

Subject: Re: [PATCH] s390: PTR_ERR return of wrong pointer in fallback_init_cip()

On Mon, 07 Dec 2009 14:31:05 +0100
Roel Kluin <[email protected]> wrote:

> Return the PTR_ERR of the correct pointer.
>
> Signed-off-by: Roel Kluin <[email protected]>
> ---
> arch/s390/crypto/aes_s390.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/s390/crypto/aes_s390.c b/arch/s390/crypto/aes_s390.c
> index 6118890..6be4503 100644
> --- a/arch/s390/crypto/aes_s390.c
> +++ b/arch/s390/crypto/aes_s390.c
> @@ -174,7 +174,7 @@ static int fallback_init_cip(struct crypto_tfm *tfm)
> if (IS_ERR(sctx->fallback.cip)) {
> pr_err("Allocating AES fallback algorithm %s failed\n",
> name);
> - return PTR_ERR(sctx->fallback.blk);
> + return PTR_ERR(sctx->fallback.cip);
> }
>
> return 0;

Added to my queue, thanks.

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.