2009-12-05 19:01:37

by Tilman Schmidt

[permalink] [raw]
Subject: [PATCH] gigaset: don't enable any debugging output by default

When built with debugging support, the Gigaset driver enabled some
debugging messages by default. Change the default to "all off".

Impact: cosmetic
Signed-off-by: Tilman Schmidt <[email protected]>
---

Please merge for 2.6.33 so I can in good conscience encourage people to
build the driver with CONFIG_GIGASET_DEBUG=y. ;-)

Thanks, Tilman

drivers/isdn/gigaset/common.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c
index c438cfc..a0b85d1 100644
--- a/drivers/isdn/gigaset/common.c
+++ b/drivers/isdn/gigaset/common.c
@@ -29,7 +29,7 @@
#endif

/* Module parameters */
-int gigaset_debuglevel = DEBUG_DEFAULT;
+int gigaset_debuglevel;
EXPORT_SYMBOL_GPL(gigaset_debuglevel);
module_param_named(debug, gigaset_debuglevel, int, S_IRUGO|S_IWUSR);
MODULE_PARM_DESC(debug, "debug level");
--
1.6.5.3.298.g39add


2009-12-09 04:30:51

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] gigaset: don't enable any debugging output by default

From: Tilman Schmidt <[email protected]>
Date: Sat, 5 Dec 2009 18:52:19 +0100 (CET)

> When built with debugging support, the Gigaset driver enabled some
> debugging messages by default. Change the default to "all off".
>
> Signed-off-by: Tilman Schmidt <[email protected]>

Applied.