2009-12-14 05:42:27

by tip-bot for Wenji Huang

Subject: [PATCH] tracing: remove unnecessary variable in print_graph_return

Remove the local variable of the same name cpu in branch.

Signed-off-by: Wenji Huang <[email protected]>
---
kernel/trace/trace_functions_graph.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
index a43d009..51d071c 100644
--- a/kernel/trace/trace_functions_graph.c
+++ b/kernel/trace/trace_functions_graph.c
@@ -858,7 +858,6 @@ print_graph_return(struct ftrace_graph_ret *trace, struct trace_seq *s,
int i;

if (data) {
- int cpu = iter->cpu;
int *depth = &(per_cpu_ptr(data->cpu_data, cpu)->depth);

/*
--
1.5.6

2009-12-14 11:51:00

by Frederic Weisbecker

Subject: Re: [PATCH] tracing: remove unnecessary variable in print_graph_return

On Mon, Dec 14, 2009 at 01:39:32PM +0800, Wenji Huang wrote:
> Remove the local variable of the same name cpu in branch.
>
> Signed-off-by: Wenji Huang <[email protected]>
> ---
> kernel/trace/trace_functions_graph.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
> index a43d009..51d071c 100644
> --- a/kernel/trace/trace_functions_graph.c
> +++ b/kernel/trace/trace_functions_graph.c
> @@ -858,7 +858,6 @@ print_graph_return(struct ftrace_graph_ret *trace, struct trace_seq *s,
> int i;
>
> if (data) {
> - int cpu = iter->cpu;
> int *depth = &(per_cpu_ptr(data->cpu_data, cpu)->depth);
>
> /*


Acked-by: Frederic Weisbecker <[email protected]>