Hi Len,
Today's linux-next build (x86_64 allmodconfig) failed like this:
ERROR: "pnpacpi_protocol" [drivers/char/ipmi/ipmi_si.ko] undefined!
Caused by commit e80b594fd69039387339e75b4f75c58da74676ae ("PNP: add
interface to retrieve ACPI device from a PNPACPI device").
I have used the acpi tree form next-20091211 for today.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
On Mon, 2009-12-14 at 12:20 +1100, Stephen Rothwell wrote:
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> ERROR: "pnpacpi_protocol" [drivers/char/ipmi/ipmi_si.ko] undefined!
>
> Caused by commit e80b594fd69039387339e75b4f75c58da74676ae ("PNP: add
> interface to retrieve ACPI device from a PNPACPI device").
Here's the fix:
commit 28b07e816ecc25567c8ff25e5a0c52f57e55b91f
Author: Bjorn Helgaas <[email protected]>
Date: Mon Dec 14 21:41:17 2009 -0700
PNP: export pnpacpi_protocol (for pnp_acpi_device() test)
In e80b594f, I added an exported interface, pnp_acpi_device(), but
I neglected to export the underlying pnpacpi_protocol symbol.
Signed-off-by: Bjorn Helgaas <[email protected]>
diff --git a/drivers/pnp/pnpacpi/core.c b/drivers/pnp/pnpacpi/core.c
index 8dd0f37..5314bf6 100644
--- a/drivers/pnp/pnpacpi/core.c
+++ b/drivers/pnp/pnpacpi/core.c
@@ -154,6 +154,7 @@ struct pnp_protocol pnpacpi_protocol = {
.resume = pnpacpi_resume,
#endif
};
+EXPORT_SYMBOL(pnpacpi_protocol);
static int __init pnpacpi_add_device(struct acpi_device *device)
{
i merged bjorn's fix into the original offending patch in acpi-test
thanks,
Len Brown, Intel Open Source Technology Center
Hi Len, Bjorn,
On Tue, 15 Dec 2009 17:37:21 -0500 (EST) Len Brown <[email protected]> wrote:
>
> i merged bjorn's fix into the original offending patch in acpi-test
Thanks.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
Hi Len,
On Tue, 15 Dec 2009 17:37:21 -0500 (EST) Len Brown <[email protected]> wrote:
>
> i merged bjorn's fix into the original offending patch in acpi-test
That didn't seem to be in what I fetched for linux-next today.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/