2009-12-16 13:00:37

by Roel Kluin

Subject: [PATCH] broadcom: bcm54xx_shadow_read() errors ignored in bcm54xx_adjust_rxrefclk()

If not signed read errors are ignored.

Signed-off-by: Roel Kluin <[email protected]>
---
Found using coccinelle: http://coccinelle.lip6.fr/

diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
index f63c96a..c13cf64 100644
--- a/drivers/net/phy/broadcom.c
+++ b/drivers/net/phy/broadcom.c
@@ -326,7 +326,8 @@ error:

static void bcm54xx_adjust_rxrefclk(struct phy_device *phydev)
{
- u32 val, orig;
+ u32 orig;
+ int val;
bool clk125en = true;

/* Abort if we are using an untested phy. */

2009-12-18 01:41:50

by Matt Carlson

Subject: Re: [PATCH] broadcom: bcm54xx_shadow_read() errors ignored in bcm54xx_adjust_rxrefclk()

On Wed, Dec 16, 2009 at 05:02:26AM -0800, Roel Kluin wrote:
> If not signed read errors are ignored.
>
> Signed-off-by: Roel Kluin <[email protected]>

Acked-by: Matt Carlson <[email protected]>

> ---
> Found using coccinelle: http://coccinelle.lip6.fr/
>
> diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
> index f63c96a..c13cf64 100644
> --- a/drivers/net/phy/broadcom.c
> +++ b/drivers/net/phy/broadcom.c
> @@ -326,7 +326,8 @@ error:
>
> static void bcm54xx_adjust_rxrefclk(struct phy_device *phydev)
> {
> - u32 val, orig;
> + u32 orig;
> + int val;
> bool clk125en = true;
>
> /* Abort if we are using an untested phy. */
>

2009-12-19 04:16:20

by David Miller

Subject: Re: [PATCH] broadcom: bcm54xx_shadow_read() errors ignored in bcm54xx_adjust_rxrefclk()

From: "Matt Carlson" <[email protected]>
Date: Thu, 17 Dec 2009 17:41:39 -0800

> On Wed, Dec 16, 2009 at 05:02:26AM -0800, Roel Kluin wrote:
>> If not signed read errors are ignored.
>>
>> Signed-off-by: Roel Kluin <[email protected]>
>
> Acked-by: Matt Carlson <[email protected]>

Applied, thanks.