2009-12-30 03:35:08

by Gui, Jianfeng/归 剑峰

[permalink] [raw]
Subject: [PATCH] block: blk_rq_err_sectors cleanup

blk_rq_err_sectors() seems useless, get rid of it.

Signed-off-by: Gui Jianfeng <[email protected]>
---
include/linux/blkdev.h | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 221cecd..fcbb9e2 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -843,7 +843,6 @@ static inline void blk_run_address_space(struct address_space *mapping)
* blk_rq_err_bytes() : bytes left till the next error boundary
* blk_rq_sectors() : sectors left in the entire request
* blk_rq_cur_sectors() : sectors left in the current segment
- * blk_rq_err_sectors() : sectors left till the next error boundary
*/
static inline sector_t blk_rq_pos(const struct request *rq)
{
@@ -872,11 +871,6 @@ static inline unsigned int blk_rq_cur_sectors(const struct request *rq)
return blk_rq_cur_bytes(rq) >> 9;
}

-static inline unsigned int blk_rq_err_sectors(const struct request *rq)
-{
- return blk_rq_err_bytes(rq) >> 9;
-}
-
/*
* Request issue related functions.
*/
--
1.5.4.rc3


2009-12-30 07:39:20

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] block: blk_rq_err_sectors cleanup

On Wed, Dec 30 2009, Gui Jianfeng wrote:
> blk_rq_err_sectors() seems useless, get rid of it.

Indeed, it's currently unused. Applied.

--
Jens Axboe