2010-01-04 01:16:09

by Jonathan Woithe

[permalink] [raw]
Subject: Re: 2.9.29.2: ide-tape: panic when probing device at boot

Hi

> Borislav Petkov wrote:
> > Hi,
> >
> > On Sat, May 09, 2009 at 05:57:49PM +0200, Bartlomiej Zolnierkiewicz wrote:
> >> [ cc:ing linux-ide and knowledgeable people ]
> >>
> >> Borislav/Tejun:
> >>
> >> Is the 2.6.29 problem the same thing that was fixed recently?
> >
> > I'll let Tejun answer that one since I don't get an oops. However, now
> > that I have an ide-tape hardware here, I do get something DMA-related
> > failing during boot:
> >
> > [ 1.677012] hdb: Seagate STT8000A, ATAPI TAPE drive
> >
> > ..
> >
> > [ 1.701097] hdb: host max PIO4 wanted PIO255(auto-tune) selected PIO4
> > [ 1.708289] hdb: bad DMA info in identify block
> > [ 1.712872] hdb: host max PIO4 wanted PIO255(auto-tune) selected PIO4
> >
> > ..
> >
> > [ 3.450381] Uniform CD-ROM driver Revision: 3.20
> > [ 5.467347] ide-tape: hdb <-> ht0: Seagate STT8000A rev 5.44
> > [ 5.484852] ide-tape: hdb <-> ht0: 88KBps, 14*26kB buffer, 400ms tDS
> >
> > and more specifically the bad DMA info in identify block thing above. I
> > haven't looked into it yet but its next on my TODO.
>
> Yeah, I've been seeing that too (before and after my changes).
> Haven't investigated it yet. Good that it's on your todo list. :-)
>
> >> Should I just push commit 1e75540ec5202cae63cd238c86bd880e3d496546
> >> ("ide-tape: remove back-to-back REQUEST_SENSE detection") to Linus
> >> or there is more needed to bring ide-tape to the world of living?
> >
> > ... and I'm afraid we'll have to do some serious bugfixing since this
> > driver is behaving really funny :). Stay tuned, I'm on it.
>
> Cool.

Has there been any movement on this in recent months? I gave 2.6.30 a whirl
on the machine when that was released but it still gave major problems with
the ide-tape driver. Is 2.6.32 likely to be improved? If so I'll make
arrangements to test that version.

Presently I'm stuck with 2.6.24.x on this system since ide-tape holds
together enough on this version to work. I really want to upgrade to a more
recent kernel but obviously I can't until ide-tape is functional again.

Regards
jonathan


2010-01-04 05:47:51

by Borislav Petkov

[permalink] [raw]
Subject: Re: 2.9.29.2: ide-tape: panic when probing device at boot

On Mon, Jan 04, 2010 at 11:45:12AM +1030, Jonathan Woithe wrote:
> Has there been any movement on this in recent months? I gave 2.6.30 a whirl
> on the machine when that was released but it still gave major problems with
> the ide-tape driver. Is 2.6.32 likely to be improved? If so I'll make
> arrangements to test that version.

Yes, please do test 2.6.32 to see whether it fixes your problem. If you still
get that oops, please apply the following patch and send me the _whole_ dmesg
output of the machine.

Thanks.

--
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 6a0e625..e4c3ffd 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -49,7 +49,7 @@
#include <linux/mtio.h>

/* define to see debug info */
-#undef IDETAPE_DEBUG_LOG
+#define IDETAPE_DEBUG_LOG

#ifdef IDETAPE_DEBUG_LOG
#define ide_debug_log(lvl, fmt, args...) __ide_debug_log(lvl, fmt, ## args)
@@ -1737,6 +1737,8 @@ static void idetape_setup(ide_drive_t *drive, idetape_tape_t *tape, int minor)
int buffer_size;
u16 *ctl = (u16 *)&tape->caps[12];

+ drive->debug_mask = 0xffffffff;
+
ide_debug_log(IDE_DBG_FUNC, "minor: %d", minor);

drive->pc_callback = ide_tape_callback;


--
Regards/Gruss,
Boris.

2010-01-04 05:52:37

by Robert Hancock

[permalink] [raw]
Subject: Re: 2.9.29.2: ide-tape: panic when probing device at boot

On 01/03/2010 07:15 PM, Jonathan Woithe wrote:
>>>> Should I just push commit 1e75540ec5202cae63cd238c86bd880e3d496546
>>>> ("ide-tape: remove back-to-back REQUEST_SENSE detection") to Linus
>>>> or there is more needed to bring ide-tape to the world of living?
>>>
>>> ... and I'm afraid we'll have to do some serious bugfixing since this
>>> driver is behaving really funny :). Stay tuned, I'm on it.
>>
>> Cool.
>
> Has there been any movement on this in recent months? I gave 2.6.30 a whirl
> on the machine when that was released but it still gave major problems with
> the ide-tape driver. Is 2.6.32 likely to be improved? If so I'll make
> arrangements to test that version.
>
> Presently I'm stuck with 2.6.24.x on this system since ide-tape holds
> together enough on this version to work. I really want to upgrade to a more
> recent kernel but obviously I can't until ide-tape is functional again.

You could also try using libata instead of IDE drivers and see if they
work any better for you..

2010-01-05 05:38:58

by Jonathan Woithe

[permalink] [raw]
Subject: Re: 2.9.29.2: ide-tape: panic when probing device at boot

> On Mon, Jan 04, 2010 at 11:45:12AM +1030, Jonathan Woithe wrote:
> > Has there been any movement on this in recent months? I gave 2.6.30 a whirl
> > on the machine when that was released but it still gave major problems with
> > the ide-tape driver. Is 2.6.32 likely to be improved? If so I'll make
> > arrangements to test that version.
>
> Yes, please do test 2.6.32 to see whether it fixes your problem. If you still
> get that oops, please apply the following patch and send me the _whole_ dmesg
> output of the machine.

Ok, will do. Since it is a production machine and I've got linux.conf.au
coming up it may be a couple of weeks before I get to do the test. I'll
advise the outcome once I have tested it.

Robert Hancock wrote:
> You could also try using libata instead of IDE drivers and see if they
> work any better for you..

Yes, a good suggestion (I'm not sure why I neglected to try that initially).
I'll test that too and report back.

Regards
jonathan