2009-12-16 13:40:08

by Roel Kluin

Subject: [PATCH] mfd: Fix test of unsigned in twl4030_configure_resource()

devgroup is unsigned so the test did not work.

Signed-off-by: Roel Kluin <[email protected]>
---
Found using coccinelle: http://coccinelle.lip6.fr/

see
vi arch/arm/mach-omap2/board-rx51-peripherals.c +512

diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
index d423e0c..f207e28 100644
--- a/drivers/mfd/twl4030-power.c
+++ b/drivers/mfd/twl4030-power.c
@@ -335,7 +335,7 @@ static int __init twl4030_configure_resource(struct twl4030_resconfig *rconfig)
return err;
}

- if (rconfig->devgroup >= 0) {
+ if (rconfig->devgroup != -1) {
grp &= ~DEVGROUP_MASK;
grp |= rconfig->devgroup << DEVGROUP_SHIFT;
err = twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER,

2009-12-16 13:42:23

by Roel Kluin

Subject: Re: [PATCH] mfd: Fix test of unsigned in twl4030_configure_resource()

devgroup is unsigned so the test did not work.

Signed-off-by: Roel Kluin <[email protected]>
---
Found using coccinelle: http://coccinelle.lip6.fr/

see
vi arch/arm/mach-omap2/board-rx51-peripherals.c +512

Oops, missed some in previous patch.

Roel

diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
index d423e0c..cc984a5 100644
--- a/drivers/mfd/twl4030-power.c
+++ b/drivers/mfd/twl4030-power.c
@@ -335,7 +335,7 @@ static int __init twl4030_configure_resource(struct twl4030_resconfig *rconfig)
return err;
}

- if (rconfig->devgroup >= 0) {
+ if (rconfig->devgroup != -1) {
grp &= ~DEVGROUP_MASK;
grp |= rconfig->devgroup << DEVGROUP_SHIFT;
err = twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER,
@@ -355,12 +355,12 @@ static int __init twl4030_configure_resource(struct twl4030_resconfig *rconfig)
return err;
}

- if (rconfig->type >= 0) {
+ if (rconfig->type != -1) {
type &= ~TYPE_MASK;
type |= rconfig->type << TYPE_SHIFT;
}

- if (rconfig->type2 >= 0) {
+ if (rconfig->type2 != -1) {
type &= ~TYPE2_MASK;
type |= rconfig->type2 << TYPE2_SHIFT;
}

2010-01-05 19:21:26

by Samuel Ortiz

Subject: Re: [PATCH] mfd: Fix test of unsigned in twl4030_configure_resource()

Hi Roel,

On Wed, Dec 16, 2009 at 02:44:15PM +0100, Roel Kluin wrote:
> devgroup is unsigned so the test did not work.
This one was fixed with commit 56baa667973e53d6d38af2ad3731d558566d818b.

Cheers,
Samuel.


> Signed-off-by: Roel Kluin <[email protected]>
> ---
> Found using coccinelle: http://coccinelle.lip6.fr/
>
> see
> vi arch/arm/mach-omap2/board-rx51-peripherals.c +512
>
> Oops, missed some in previous patch.
>
> Roel
>
> diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> index d423e0c..cc984a5 100644
> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -335,7 +335,7 @@ static int __init twl4030_configure_resource(struct twl4030_resconfig *rconfig)
> return err;
> }
>
> - if (rconfig->devgroup >= 0) {
> + if (rconfig->devgroup != -1) {
> grp &= ~DEVGROUP_MASK;
> grp |= rconfig->devgroup << DEVGROUP_SHIFT;
> err = twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER,
> @@ -355,12 +355,12 @@ static int __init twl4030_configure_resource(struct twl4030_resconfig *rconfig)
> return err;
> }
>
> - if (rconfig->type >= 0) {
> + if (rconfig->type != -1) {
> type &= ~TYPE_MASK;
> type |= rconfig->type << TYPE_SHIFT;
> }
>
> - if (rconfig->type2 >= 0) {
> + if (rconfig->type2 != -1) {
> type &= ~TYPE2_MASK;
> type |= rconfig->type2 << TYPE2_SHIFT;
> }

--
Intel Open Source Technology Centre
http://oss.intel.com/