2010-01-05 17:05:46

by Hartley Sweeten

Subject: [PATCH] drivers/net/atl1c/atl1c_main.c: use %pM to show MAC address

Use the %pM kernel extension to display the MAC address.

The only difference in the output is that the MAC address is
shown in the usual colon-separated hex notation.

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: David S. Miller <[email protected]>

---

Repost due to merge issues.

diff --git a/drivers/net/atl1c/atl1c_main.c b/drivers/net/atl1c/atl1c_main.c
index 2f4be59..77cde85 100644
--- a/drivers/net/atl1c/atl1c_main.c
+++ b/drivers/net/atl1c/atl1c_main.c
@@ -2596,11 +2596,8 @@ static int __devinit atl1c_probe(struct pci_dev *pdev,
memcpy(netdev->dev_addr, adapter->hw.mac_addr, netdev->addr_len);
memcpy(netdev->perm_addr, adapter->hw.mac_addr, netdev->addr_len);
if (netif_msg_probe(adapter))
- dev_dbg(&pdev->dev,
- "mac address : %02x-%02x-%02x-%02x-%02x-%02x\n",
- adapter->hw.mac_addr[0], adapter->hw.mac_addr[1],
- adapter->hw.mac_addr[2], adapter->hw.mac_addr[3],
- adapter->hw.mac_addr[4], adapter->hw.mac_addr[5]);
+ dev_dbg(&pdev->dev, "mac address : %pM\n",
+ adapter->hw.mac_addr);

atl1c_hw_set_mac_addr(&adapter->hw);
INIT_WORK(&adapter->common_task, atl1c_common_task);

2010-01-07 09:21:54

by David Miller

Subject: Re: [PATCH] drivers/net/atl1c/atl1c_main.c: use %pM to show MAC address

From: H Hartley Sweeten <[email protected]>
Date: Tue, 5 Jan 2010 09:54:01 -0700

> Use the %pM kernel extension to display the MAC address.
>
> The only difference in the output is that the MAC address is
> shown in the usual colon-separated hex notation.
>
> Signed-off-by: H Hartley Sweeten <[email protected]>

Applied.