2010-01-13 01:01:52

by Jeff Mahoney

Subject:

Subject: [patch 1/6] smsc47m1: Fix section mismatch
References: <[email protected]>
Content-Disposition: inline; filename=patches.rpmify/smsc47m1-fix-section-mismatch

smsc47m1_restore is called from sm_smsc47m1_exit, which is an __exit
function, so it can't be __init.

Signed-off-by: Jeff Mahoney <[email protected]>
---
drivers/hwmon/smsc47m1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/hwmon/smsc47m1.c
+++ b/drivers/hwmon/smsc47m1.c
@@ -488,7 +488,7 @@ static int __init smsc47m1_find(unsigned
}

/* Restore device to its initial state */
-static void __init smsc47m1_restore(const struct smsc47m1_sio_data *sio_data)
+static void smsc47m1_restore(const struct smsc47m1_sio_data *sio_data)
{
if ((sio_data->activate & 0x01) == 0) {
superio_enter();

2010-01-13 10:44:56

by Jean Delvare

Subject: Re: [PATCH] hwmon: (smsc47m1) Fix section mismatch

Hi Jeff,

On Tue, 12 Jan 2010 19:48:56 -0500, Jeff Mahoney wrote:
> Subject: [patch 1/6] smsc47m1: Fix section mismatch
> References: <[email protected]>
> Content-Disposition: inline; filename=patches.rpmify/smsc47m1-fix-section-mismatch
>
> smsc47m1_restore is called from sm_smsc47m1_exit, which is an __exit
> function, so it can't be __init.
>
> Signed-off-by: Jeff Mahoney <[email protected]>
> ---
> drivers/hwmon/smsc47m1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/hwmon/smsc47m1.c
> +++ b/drivers/hwmon/smsc47m1.c
> @@ -488,7 +488,7 @@ static int __init smsc47m1_find(unsigned
> }
>
> /* Restore device to its initial state */
> -static void __init smsc47m1_restore(const struct smsc47m1_sio_data *sio_data)
> +static void smsc47m1_restore(const struct smsc47m1_sio_data *sio_data)
> {
> if ((sio_data->activate & 0x01) == 0) {
> superio_enter();
>

Good catch, thanks for reporting. I do not get any warning about this
one, even though I build the driver as a module and with hotplug
support enabled. I don't get it.

Anyway, patch applied, thanks.

--
Jean Delvare