Hi all!
As part of the VAMOS[0] research project at the University of
Erlangen we're checking referential integrity between kernel KConfig
options and in-code Conditional blocks.
While working on this we detected a spelling error in
drivers/mfd/ab3100-otp.c which can be corrected using the attached
patch.
Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.
Regards
Christoph Egger
[0] http://vamos1.informatik.uni-erlangen.de/
On Wed, 13 Jan 2010, Christoph Egger wrote:
> Hi all!
>
> As part of the VAMOS[0] research project at the University of
> Erlangen we're checking referential integrity between kernel KConfig
> options and in-code Conditional blocks.
>
> While working on this we detected a spelling error in
> drivers/mfd/ab3100-otp.c which can be corrected using the attached
> patch.
>
> Please keep me informed of this patch getting confirmed /
> merged so we can keep track of it.
>
> Regards
>
> Christoph Egger
>
> [0] http://vamos1.informatik.uni-erlangen.de/
just FYI, the same information can be found where i post the output
from my kernel scanning scripts. specifically, that very typo is
already documented here:
http://www.crashcourse.ca/wiki/index.php/Badref_CONFIG_variables#mfd
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
On Wed, 13 Jan 2010, Christoph Egger wrote:
> Hi all!
>
> As part of the VAMOS[0] research project at the University of
> Erlangen we're checking referential integrity between kernel KConfig
> options and in-code Conditional blocks.
>
> While working on this we detected a spelling error in
> drivers/mfd/ab3100-otp.c which can be corrected using the attached
> patch.
>
> Please keep me informed of this patch getting confirmed /
> merged so we can keep track of it.
>
> Regards
>
> Christoph Egger
>
> [0] http://vamos1.informatik.uni-erlangen.de/
by the way, if you're rooting around in the drivers/mfd directory,
feel free to correct this obvious typo in twl-core.c:
...
#if defined(CONFIG_INPUT_TWL4030_PWRBUTTON) \
|| defined(CONFIG_INPUT_TWL4030_PWBUTTON_MODULE)
^ missing "R"
...
there's also the test of the non-existent
CONFIG_TWL4030_BCI_BATTERY variable in twl-core.c and, well, you get
the idea.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
On Wed, 13 Jan 2010, Christoph Egger wrote:
> On Wed, Jan 13, 2010 at 07:05:33AM -0500, Robert P. J. Day wrote:
> >
> > just FYI, the same information can be found where i post the
> > output from my kernel scanning scripts. specifically, that very
> > typo is already documented here:
> >
> > http://www.crashcourse.ca/wiki/index.php/Badref_CONFIG_variables#mfd
> >
> > rday
>
> Jep I stumbled upon your reports while having a closer look at
> what we found. Strangely while you did find somewhere around 250
> such Issues we are at 90[0] if you count #define-ed CONFIG_* to the
> errors. I'll probably try to look at the difference between our
> results.
>
> [0] http://vamos1.informatik.uni-erlangen.de/graph.html
it's entirely possible that i have false positives in my listings;
anyone who wants to look at them is responsible for checking them out
more carefully, but i believe i catch most of the errors.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
On Wed, Jan 13, 2010 at 07:05:33AM -0500, Robert P. J. Day wrote:
>
> just FYI, the same information can be found where i post the output
> from my kernel scanning scripts. specifically, that very typo is
> already documented here:
>
> http://www.crashcourse.ca/wiki/index.php/Badref_CONFIG_variables#mfd
>
> rday
Jep I stumbled upon your reports while having a closer look at
what we found. Strangely while you did find somewhere around 250 such
Issues we are at 90[0] if you count #define-ed CONFIG_* to the
errors. I'll probably try to look at the difference between our
results.
[0] http://vamos1.informatik.uni-erlangen.de/graph.html
On Wed, 13 Jan 2010, Christoph Egger wrote:
> On Wed, Jan 13, 2010 at 07:05:33AM -0500, Robert P. J. Day wrote:
> >
> > just FYI, the same information can be found where i post the output
> > from my kernel scanning scripts. specifically, that very typo is
> > already documented here:
> >
> > http://www.crashcourse.ca/wiki/index.php/Badref_CONFIG_variables#mfd
> >
> > rday
>
> Jep I stumbled upon your reports while having a closer look at
> what we found. Strangely while you did find somewhere around 250
> such Issues we are at 90[0] if you count #define-ed CONFIG_* to the
> errors. I'll probably try to look at the difference between our
> results.
regarding that last point, there's still a lot of explicit
CONFIG_-prefixed macros, which are massively discouraged since all
CONFIG_-prefixed symbols are supposed to be reserved solely for the
Kconfig namespace.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
2010/1/13 Christoph Egger <[email protected]>:
> ? ? ? ?While working on this we detected a spelling error in
> drivers/mfd/ab3100-otp.c which can be corrected using the attached
> patch.
Acked-by: Linus Walleij <[email protected]>
Linus Walleij
On Thu, 14 Jan 2010, Linus Walleij wrote:
> 2010/1/13 Christoph Egger <[email protected]>:
>
> > ? ? ? ?While working on this we detected a spelling error in
> > drivers/mfd/ab3100-otp.c which can be corrected using the attached
> > patch.
>
> Acked-by: Linus Walleij <[email protected]>
The original patch misses a Signed-off-by. Please resend it to
[email protected] with this line, so that it could be applied.
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
On Fri, 15 Jan 2010, Jiri Kosina wrote:
> > 2010/1/13 Christoph Egger <[email protected]>:
> >
> > > ? ? ? ?While working on this we detected a spelling error in
> > > drivers/mfd/ab3100-otp.c which can be corrected using the attached
> > > patch.
> >
> > Acked-by: Linus Walleij <[email protected]>
>
> The original patch misses a Signed-off-by. Please resend it to
> [email protected] with this line, so that it could be applied.
... and has this been tested at all?
drivers/mfd/ab3100-otp.c: In function ?show_otp?:
drivers/mfd/ab3100-otp.c:101: error: dereferencing pointer to incomplete type
drivers/mfd/ab3100-otp.c:104: error: implicit declaration of function ?seq_printf?
drivers/mfd/ab3100-otp.c:102: warning: unused variable ?err?
drivers/mfd/ab3100-otp.c: In function ?ab3100_otp_open?:
drivers/mfd/ab3100-otp.c:116: error: implicit declaration of function ?single_open?
drivers/mfd/ab3100-otp.c:116: error: ?ab3100_otp_show? undeclared (first use in this function)
drivers/mfd/ab3100-otp.c:116: error: (Each undeclared identifier is reported only once
drivers/mfd/ab3100-otp.c:116: error: for each function it appears in.)
drivers/mfd/ab3100-otp.c: At top level:
drivers/mfd/ab3100-otp.c:121: error: ?seq_read? undeclared here (not in a function)
drivers/mfd/ab3100-otp.c:122: error: ?seq_lseek? undeclared here (not in a function)
drivers/mfd/ab3100-otp.c:123: error: ?single_release? undeclared here (not in a function)
drivers/mfd/ab3100-otp.c: In function ?ab3100_otp_init_debugfs?:
drivers/mfd/ab3100-otp.c:134: error: ?err? undeclared (first use in this function)
drivers/mfd/ab3100-otp.c: In function ?ab3100_otp_exit_debugfs?:
drivers/mfd/ab3100-otp.c:140: error: implicit declaration of function ?debugfs_remove_file?
So looks like the debugfs code might need some more surgery.
--
Jiri Kosina
SUSE Labs, Novell Inc.