2010-01-13 20:45:40

by Marin Mitov

Subject: [PATCH] Section mismatch: acpi_early_processor_set_pdc()

Hi all,

kernel-2.6.33-rc4, compiler output:

WARNING: Section mismatch in reference from the function
acpi_early_processor_set_pdc() to the variable .cpuinit.data:processor_idle_dmi_table
The function acpi_early_processor_set_pdc() references
the variable __cpuinitdata processor_idle_dmi_table.
This is often because acpi_early_processor_set_pdc lacks a __cpuinitdata
annotation or the annotation of processor_idle_dmi_table is wrong.

acpi_early_processor_set_pdc() is invoked only from __init acpi_bus_init()
Mark it __cpuinit.

The patch is against 2.6.33-rc4

Signed-off-by: Marin Mitov <[email protected]>

===========================================================================
--- a/drivers/acpi/processor_pdc.c 2010-01-13 21:53:14.000000000 +0200
+++ b/drivers/acpi/processor_pdc.c 2010-01-13 21:58:39.000000000 +0200
@@ -151,7 +151,7 @@
return AE_OK;
}

-void acpi_early_processor_set_pdc(void)
+void __cpuinit acpi_early_processor_set_pdc(void)
{
/*
* Check whether the system is DMI table. If yes, OSPM

2010-01-16 07:07:09

by Len Brown

Subject: Re: [PATCH] Section mismatch: acpi_early_processor_set_pdc()

I think tony's patch (in my tree) to change this to __init is correct.

thanks,
Len Brown, Intel Open Source Technology Center

On Wed, 13 Jan 2010, Marin Mitov wrote:

> Hi all,
>
> kernel-2.6.33-rc4, compiler output:
>
> WARNING: Section mismatch in reference from the function
> acpi_early_processor_set_pdc() to the variable .cpuinit.data:processor_idle_dmi_table
> The function acpi_early_processor_set_pdc() references
> the variable __cpuinitdata processor_idle_dmi_table.
> This is often because acpi_early_processor_set_pdc lacks a __cpuinitdata
> annotation or the annotation of processor_idle_dmi_table is wrong.
>
> acpi_early_processor_set_pdc() is invoked only from __init acpi_bus_init()
> Mark it __cpuinit.
>
> The patch is against 2.6.33-rc4
>
> Signed-off-by: Marin Mitov <[email protected]>
>
> ===========================================================================
> --- a/drivers/acpi/processor_pdc.c 2010-01-13 21:53:14.000000000 +0200
> +++ b/drivers/acpi/processor_pdc.c 2010-01-13 21:58:39.000000000 +0200
> @@ -151,7 +151,7 @@
> return AE_OK;
> }
>
> -void acpi_early_processor_set_pdc(void)
> +void __cpuinit acpi_early_processor_set_pdc(void)
> {
> /*
> * Check whether the system is DMI table. If yes, OSPM
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>