2010-01-15 12:08:40

by Christoph Egger

[permalink] [raw]
Subject: [PATCH] obsolete config in kernel source (DVB_DIBCOM_DEBUG)

Hi all!

As part of the VAMOS[0] research project at the University of
Erlangen we're checking referential integrity between kernel KConfig
options and in-code Conditional blocks.

By this we discovered the config Option DVB_DIBCOM_DEBUG,
which was dropped while removing the dibusb driver in favor of dvb-usb
in 2005. However it remaind existant at some places of the kernel
config.

Probably one should be a bit more agressive here as the dprintk
macro now expands to a do{}while(0) unconditionally so all blocks
using them can also be dropped to remove in-tree cruft but the patch
does a first cleanup.

Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.

Regards

Christoph Egger

[0] http://vamos1.informatik.uni-erlangen.de/


Attachments:
(No filename) (778.00 B)
0004-remove-obsolete-conditionalizing-on-DVB_DIBCOM_DEBUG.patch (2.38 kB)
Download all attachments

2010-01-25 12:22:13

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [PATCH] obsolete config in kernel source (DVB_DIBCOM_DEBUG)

Hi Patrick,

Could you please take a look on this patch? It makes sense or to apply it
or to add an option to enable debug messages at the drivers.

Cheers,
Mauro

Christoph Egger wrote:
> Hi all!
>
> As part of the VAMOS[0] research project at the University of
> Erlangen we're checking referential integrity between kernel KConfig
> options and in-code Conditional blocks.
>
> By this we discovered the config Option DVB_DIBCOM_DEBUG,
> which was dropped while removing the dibusb driver in favor of dvb-usb
> in 2005. However it remaind existant at some places of the kernel
> config.
>
> Probably one should be a bit more agressive here as the dprintk
> macro now expands to a do{}while(0) unconditionally so all blocks
> using them can also be dropped to remove in-tree cruft but the patch
> does a first cleanup.
>
> Please keep me informed of this patch getting confirmed /
> merged so we can keep track of it.
>
> Regards
>
> Christoph Egger
>
> [0] http://vamos1.informatik.uni-erlangen.de/
>