hi all,
i read the driver/staging/hv code, why it will apply into kernel tree
that it not fellow the kernel codingstyle?
it ruin the kernel tree, it had better let the author rewrite it fellow
the "linux kernel CodingStyle".
see Documentation/CodingStyle.
Best,
Figo.zhang
hi all,
i read the driver/staging/hv code, why it will apply into kernel tree
that it not follow the kernel codingstyle? it all of "Hungarian
notation".
see Documentation/CodingStyle. In this document,(line 254) it says:
"Encoding the type of a function into the name (so-called Hungarian
notation) is brain damaged".
so it ruin the kernel tree, it had better let the author rewrite it
follow the "linux kernel CodingStyle".
Best,
Figo.zhang
On 12/01/2010, at 6:08 PM, Figo.zhang wrote:
> hi all,
>
> i read the driver/staging/hv code, why it will apply into kernel tree that it not follow the kernel codingstyle?
Drivers in the staging/ tree are there because they aren't clean and neat enough for the rest of the kernel tree. By the time it gets promoted to /virt (or where ever) it will have been fixed.
If the state of hv worries you, send patches!
--Ben.-
On Fri, Jan 15, 2010 at 10:04:13PM +0800, figo.zhang wrote:
>
> Now it has made the Codingstyle rule, anyone should follow it , right?
Patches are always gladly accepted to fix this stuff up.
thanks,
greg k-h
> > i am not familiar with the Hyper-V. But happy to see Greg Kroah-Hartman to push
> > the author to motify it follow the Kernel Codingstyle, or apply to merge to main tree
> > until it follow it.
> > Now it has made the Codingstyle rule, anyone should follow it , right?
local variable and function use like "ThisVariableIsATemporaryCounter"
is very very ugly and brain damaged (only Microsoft use it).
Best,
Figo.zhang
Henan University of Science and Technology