2010-01-16 20:53:20

by Arjan van de Ven

[permalink] [raw]
Subject: [PATCH] perf timechart: Use tid not pid for COMM change

>From 3e519cea7bbc7c6a3c07e3a24e9f33bf15305516 Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <[email protected]>
Date: Sat, 16 Jan 2010 12:51:30 -0800
Subject: [PATCH] perf timechart: Use tid not pid for COMM change

A process that changes its comm field, does this on a per kernel
task struct basis. The timechart tool used, incorrectly, the pid to track
this, and should have used the tid instead...

Signed-off-by: Arjan van de Ven <[email protected]>
CC: [email protected]
---
tools/perf/builtin-timechart.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c
index a589a43..3f8bbcf 100644
--- a/tools/perf/builtin-timechart.c
+++ b/tools/perf/builtin-timechart.c
@@ -280,7 +280,7 @@ static u64 cpus_pstate_state[MAX_CPUS];

static int process_comm_event(event_t *event, struct perf_session *session __used)
{
- pid_set_comm(event->comm.pid, event->comm.comm);
+ pid_set_comm(event->comm.tid, event->comm.comm);
return 0;
}

--
1.6.2.5



--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org


2010-01-17 07:00:50

by Arjan van de Ven

[permalink] [raw]
Subject: [tip:perf/urgent] perf timechart: Use tid not pid for COMM change

Commit-ID: 8f06d7e6e1bbfb32698d6d455583ab7460c090e2
Gitweb: http://git.kernel.org/tip/8f06d7e6e1bbfb32698d6d455583ab7460c090e2
Author: Arjan van de Ven <[email protected]>
AuthorDate: Sat, 16 Jan 2010 12:53:19 -0800
Committer: Ingo Molnar <[email protected]>
CommitDate: Sun, 17 Jan 2010 07:16:36 +0100

perf timechart: Use tid not pid for COMM change

A process that changes its comm field, does this on a per kernel
task struct basis. The timechart tool used, incorrectly, the pid
to track this, and should have used the tid instead...

Signed-off-by: Arjan van de Ven <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Mike Galbraith <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
CC: <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
---
tools/perf/builtin-timechart.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c
index a589a43..3f8bbcf 100644
--- a/tools/perf/builtin-timechart.c
+++ b/tools/perf/builtin-timechart.c
@@ -280,7 +280,7 @@ static u64 cpus_pstate_state[MAX_CPUS];

static int process_comm_event(event_t *event, struct perf_session *session __used)
{
- pid_set_comm(event->comm.pid, event->comm.comm);
+ pid_set_comm(event->comm.tid, event->comm.comm);
return 0;
}