2010-01-18 02:57:40

by Peter Huewe

Subject: [PATCH] arch/sh: Fix build failure caused by missing semicolon / missing include

From: Peter Huewe <[email protected]>
Date: Mon, 18 Jan 2010 03:48:31 +0100

This patch fixes a build failure[1][2] for all sh configs, by fixing a
missing semicolon and a missing include file.

Build failure was introduced by the patch
sh: fixed PMB mode refactoring [3]
of Wed, 13 Jan 2010 09:31:48 +0000 (18:31 +0900)

References:
[1] http://kisskb.ellerman.id.au/kisskb/buildresult/2019836/
[2] http://kisskb.ellerman.id.au/kisskb/compiler/16/
[3] http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commit;h=a0ab36689a36e583b6e736f1c99ac8c9aebdad59

Signed-off-by: Peter Huewe <[email protected]>
---
Patch against linux-next tree of 20100114
KernelVersion: next-20100114

arch/sh/include/asm/mmu.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/sh/include/asm/mmu.h b/arch/sh/include/asm/mmu.h
index 4b0882b..c5313e2 100644
--- a/arch/sh/include/asm/mmu.h
+++ b/arch/sh/include/asm/mmu.h
@@ -1,5 +1,6 @@
#ifndef __MMU_H
#define __MMU_H
+#include <linux/errno.h>

/*
* Privileged Space Mapping Buffer (PMB) definitions
@@ -75,7 +76,7 @@ int pmb_init(void);
static inline long pmb_remap(unsigned long virt, unsigned long phys,
unsigned long size, unsigned long flags)
{
- return -EINVAL
+ return -EINVAL;
}

static inline void pmb_unmap(unsigned long addr)
--
1.6.4.4

2010-01-18 04:03:13

by Paul Mundt

Subject: Re: [PATCH] arch/sh: Fix build failure caused by missing semicolon / missing include

On Mon, Jan 18, 2010 at 03:57:31AM +0100, Peter Huewe wrote:
> From: Peter Huewe <[email protected]>
> Date: Mon, 18 Jan 2010 03:48:31 +0100
>
> This patch fixes a build failure[1][2] for all sh configs, by fixing a
> missing semicolon and a missing include file.
>
> Build failure was introduced by the patch
> sh: fixed PMB mode refactoring [3]
> of Wed, 13 Jan 2010 09:31:48 +0000 (18:31 +0900)
>
This was already caught and corrected, thanks anyways.