2010-01-20 13:31:28

by Christoph Egger

[permalink] [raw]
Subject: [PATCH] Obsolete config in kernel source (USE_MIXARTLOADER)

Hi all!

As part of the VAMOS[0] research project at the University of
Erlangen we're checking referential integrity between kernel KConfig
options and in-code Conditional blocks.

The config Variable USE_MIXARTLOADER has been non-existent for
all git based linux kernels (2.6.12-rc) and seems to be no longer
relevant. It is only referenced at one place in the Code
(sound/pci/mixart/mixart_hwdep.c).

The attached patch makes the behaviour more obvious as it is
equivalent to the old one when assuming CONFIG_MIXARTLOADER as not
defined.

Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.

Regards

Christoph Egger


Attachments:
(No filename) (666.00 B)
0001-config-USE_MIXARTLOADER-has-never-existed-in-KConfig.patch (1.11 kB)
Download all attachments

2010-01-20 13:38:32

by Christoph Egger

[permalink] [raw]
Subject: Re: [PATCH] Obsolete config in kernel source (USE_MIXARTLOADER)

On Wed, Jan 20, 2010 at 02:31:44PM +0100, Christoph Egger wrote:
> Hi all!
>
> As part of the VAMOS[0] research project at the University of
> Erlangen we're checking referential integrity between kernel KConfig
> options and in-code Conditional blocks.
>
> The config Variable USE_MIXARTLOADER has been non-existent for
> all git based linux kernels (2.6.12-rc) and seems to be no longer
> relevant. It is only referenced at one place in the Code
> (sound/pci/mixart/mixart_hwdep.c).
>
> The attached patch makes the behaviour more obvious as it is
> equivalent to the old one when assuming CONFIG_MIXARTLOADER as not
> defined.
>
> Please keep me informed of this patch getting confirmed /
> merged so we can keep track of it.

Same is, of course, true for USE_PCXHRLOADER. Attached is a
patch doing the same for both of them.

Regards

Christoph Egger



Attachments:
(No filename) (868.00 B)
0001-config-USE_MIXARTLOADER-has-never-existed-in-KConfig.patch (1.67 kB)
Download all attachments

2010-01-20 13:57:56

by Christoph Egger

[permalink] [raw]
Subject: Re: [PATCH] Obsolete config in kernel source (USE_MIXARTLOADER)

On Wed, Jan 20, 2010 at 02:31:44PM +0100, Christoph Egger wrote:
> Hi all!
>
> As part of the VAMOS[0] research project at the University of
> Erlangen we're checking referential integrity between kernel KConfig
> options and in-code Conditional blocks.
>
> The config Variable USE_MIXARTLOADER has been non-existent for
> all git based linux kernels (2.6.12-rc) and seems to be no longer
> relevant. It is only referenced at one place in the Code
> (sound/pci/mixart/mixart_hwdep.c).
>
> The attached patch makes the behaviour more obvious as it is
> equivalent to the old one when assuming CONFIG_MIXARTLOADER as not
> defined.
>
> Please keep me informed of this patch getting confirmed /
> merged so we can keep track of it.

Sorry, it seems I'm a bit unconcentrated today there are three
of them actually. Attached the new patch fixing all 3 of them.

Regards

Christoph Egger



Attachments:
(No filename) (894.00 B)
0001-config-USE_MIXARTLOADER-has-never-existed-in-KConfig.patch (2.21 kB)
Download all attachments

2010-01-20 14:36:15

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH] Obsolete config in kernel source (USE_MIXARTLOADER)

At Wed, 20 Jan 2010 14:31:44 +0100,
Christoph Egger wrote:
>
> Hi all!
>
> As part of the VAMOS[0] research project at the University of
> Erlangen we're checking referential integrity between kernel KConfig
> options and in-code Conditional blocks.
>
> The config Variable USE_MIXARTLOADER has been non-existent for
> all git based linux kernels (2.6.12-rc) and seems to be no longer
> relevant. It is only referenced at one place in the Code
> (sound/pci/mixart/mixart_hwdep.c).
>
> The attached patch makes the behaviour more obvious as it is
> equivalent to the old one when assuming CONFIG_MIXARTLOADER as not
> defined.

Well, these all are basically hacks for building modules from the
external alsa-driver tree. Since this is fairly harmless, I'd like to
keep them.


thanks,

Takashi