Hi all!
As part of the VAMOS[0] research project at the University of
Erlangen we're checking referential integrity between kernel KConfig
options and in-code Conditional blocks.
Similar to the config Option USB_HCD_STAT there's another
Zombi called USB_HCD_DMA only present in
./drivers/usb/host/isp1362-hcd.c The attached patch would just drop
the unreachable parts if you agree that's the correct solution.
Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.
Regards
Christoph Egger
Hello.
Christoph Egger wrote:
> From 2e5a8a322a6cd74ecb77eda8f0a09a0a01c6dbc6 Mon Sep 17 00:00:00 2001
> From: Christoph Egger <[email protected]>
> Date: Wed, 20 Jan 2010 13:32:36 +0100
> Subject: [PATCH] The configuration Option USB_HCD_DMA is not reachable in KConfig so
> this piece of Code is effectively dead and useless. Remove it to avoid
> confusion.
>
The patch's subject should be a terse description of change, not the
substitute for the lengthy description as in your case.
WBR, Sergei
On Wed, 20 Jan 2010 17:20:18 +0300 Sergei Shtylyov wrote:
> Hello.
>
> Christoph Egger wrote:
>
> > From 2e5a8a322a6cd74ecb77eda8f0a09a0a01c6dbc6 Mon Sep 17 00:00:00 2001
> > From: Christoph Egger <[email protected]>
> > Date: Wed, 20 Jan 2010 13:32:36 +0100
> > Subject: [PATCH] The configuration Option USB_HCD_DMA is not reachable in KConfig so
> > this piece of Code is effectively dead and useless. Remove it to avoid
> > confusion.
> >
>
> The patch's subject should be a terse description of change, not the
> substitute for the lengthy description as in your case.
Also please insert patches inline in the email body instead of using
attachments. mutt can surely do this -- people do it all the time
(though I don't use mutt, so please don't ask me how).
---
~Randy
On Wed, Jan 20, 2010 at 08:38:06AM -0800, Randy Dunlap wrote:
> On Wed, 20 Jan 2010 17:20:18 +0300 Sergei Shtylyov wrote:
> >
> > The patch's subject should be a terse description of change, not the
> > substitute for the lengthy description as in your case.
>
> Also please insert patches inline in the email body instead of using
> attachments. mutt can surely do this -- people do it all the time
> (though I don't use mutt, so please don't ask me how).
---
>From 2e5a8a322a6cd74ecb77eda8f0a09a0a01c6dbc6 Mon Sep 17 00:00:00 2001
From: Christoph Egger <[email protected]>
Date: Wed, 20 Jan 2010 13:32:36 +0100
Subject: [PATCH] remove code block depending on unreferenced config item USB_HCD_DMA
The configuration Option USB_HCD_DMA is not reachable in KConfig so
this piece of Code is effectively dead and useless. Remove it to avoid
confusion.
Signed-off-by: Christoph Egger <[email protected]>
---
drivers/usb/host/isp1362-hcd.c | 13 -------------
1 files changed, 0 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/host/isp1362-hcd.c b/drivers/usb/host/isp1362-hcd.c
index 73352f3..341db2c 100644
--- a/drivers/usb/host/isp1362-hcd.c
+++ b/drivers/usb/host/isp1362-hcd.c
@@ -2716,24 +2716,11 @@ static int __init isp1362_probe(struct platform_device *pdev)
goto err1;
}
-#ifdef CONFIG_USB_HCD_DMA
- if (pdev->dev.dma_mask) {
- struct resource *dma_res = platform_get_resource(pdev, IORESOURCE_MEM, 2);
-
- if (!dma_res) {
- retval = -ENODEV;
- goto err1;
- }
- isp1362_hcd->data_dma = dma_res->start;
- isp1362_hcd->max_dma_size = resource_len(dma_res);
- }
-#else
if (pdev->dev.dma_mask) {
DBG(1, "won't do DMA");
retval = -ENODEV;
goto err1;
}
-#endif
if (!request_mem_region(addr->start, resource_len(addr), hcd_name)) {
retval = -EBUSY;
--
1.6.3.3