2010-01-22 04:22:00

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: spi tree build failure

---

Hi Grant,

Today's linux-next build (x86_64 allmodconfig) failed like this:

ERROR: "clk_get_rate" [drivers/spi/dw_spi_mmio.ko] undefined!
ERROR: "clk_enable" [drivers/spi/dw_spi_mmio.ko] undefined!
ERROR: "clk_get" [drivers/spi/dw_spi_mmio.ko] undefined!
ERROR: "clk_put" [drivers/spi/dw_spi_mmio.ko] undefined!
ERROR: "clk_disable" [drivers/spi/dw_spi_mmio.ko] undefined!

Caused by commit f7b6fd6d1d3833529f1626c761ba7e338586d35e ("Memory-mapped
dw_spi driver").

I have used the spi tree from next-20100120 again for today.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/

---

Attachments:

(No filename) (631.00 B)
(No filename) (198.00 B)
Download all attachments

2010-01-22 04:27:18

by Ben Dooks

[permalink] [raw]

Subject: Re: linux-next: spi tree build failure

---

On Fri, Jan 22, 2010 at 03:21:52PM +1100, Stephen Rothwell wrote:
> Hi Grant,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> ERROR: "clk_get_rate" [drivers/spi/dw_spi_mmio.ko] undefined!
> ERROR: "clk_enable" [drivers/spi/dw_spi_mmio.ko] undefined!
> ERROR: "clk_get" [drivers/spi/dw_spi_mmio.ko] undefined!
> ERROR: "clk_put" [drivers/spi/dw_spi_mmio.ko] undefined!
> ERROR: "clk_disable" [drivers/spi/dw_spi_mmio.ko] undefined!
>
> Caused by commit f7b6fd6d1d3833529f1626c761ba7e338586d35e ("Memory-mapped
> dw_spi driver").

sounds like someone forgot to tmake the driver dependant on HAVE_CLK

> I have used the spi tree from next-20100120 again for today.
> --
> Cheers,
> Stephen Rothwell [email protected]
> http://www.canb.auug.org.au/~sfr/



--
--
Ben

Q: What's a light-year?
A: One-third less calories than a regular year.

2010-01-22 17:37:33

by Grant Likely

[permalink] [raw]

Subject: Re: linux-next: spi tree build failure

---

On Thu, Jan 21, 2010 at 9:27 PM, Ben Dooks <[email protected]> wrote:
> On Fri, Jan 22, 2010 at 03:21:52PM +1100, Stephen Rothwell wrote:
>> Hi Grant,
>>
>> Today's linux-next build (x86_64 allmodconfig) failed like this:
>>
>> ERROR: "clk_get_rate" [drivers/spi/dw_spi_mmio.ko] undefined!
>> ERROR: "clk_enable" [drivers/spi/dw_spi_mmio.ko] undefined!
>> ERROR: "clk_get" [drivers/spi/dw_spi_mmio.ko] undefined!
>> ERROR: "clk_put" [drivers/spi/dw_spi_mmio.ko] undefined!
>> ERROR: "clk_disable" [drivers/spi/dw_spi_mmio.ko] undefined!
>>
>> Caused by commit f7b6fd6d1d3833529f1626c761ba7e338586d35e ("Memory-mapped
>> dw_spi driver").
>
> sounds like someone forgot to tmake the driver dependant on HAVE_CLK

Gah! I did a test build of the module with allmodconfig, but I didn't
let it get to the modpost stage ('cause I'm building on my dinky
laptop which takes forever). Sorry. I've picked up the fix and
pushed out. Today's tree should be better. I'm not picking up
anything new today.

g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.