2010-01-25 05:52:39

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: input tree build failure

---

Hi Dmitry,

Today's linux-next build (powerpc ppc44x_defconfig) failed like this:

drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe':
drivers/input/serio/xilinx_ps2.c:273: error: incompatible type for argument 1 of 'resource_size'
include/linux/ioport.h:132: note: expected 'const struct resource *' but argument is of type 'struct resource'
drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_remove':
drivers/input/serio/xilinx_ps2.c:347: error: incompatible type for argument 1 of 'resource_size'
include/linux/ioport.h:132: note: expected 'const struct resource *' but argument is of type 'struct resource'

Please at least build test this stuff ...

Caused by commit cc7bbfa322b48be82b1c86a104433d4ac349da79 ("Input:
xilinx_ps2 - use resource_size").

I have reverted that commit for today.

--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/

---

Attachments:

(No filename) (915.00 B)
(No filename) (198.00 B)
Download all attachments

2010-01-25 06:46:12

by Dmitry Torokhov

[permalink] [raw]

Subject: Re: linux-next: input tree build failure

---

On Mon, Jan 25, 2010 at 04:52:19PM +1100, Stephen Rothwell wrote:
> Hi Dmitry,
>
> Today's linux-next build (powerpc ppc44x_defconfig) failed like this:
>
> drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe':
> drivers/input/serio/xilinx_ps2.c:273: error: incompatible type for argument 1 of 'resource_size'
> include/linux/ioport.h:132: note: expected 'const struct resource *' but argument is of type 'struct resource'
> drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_remove':
> drivers/input/serio/xilinx_ps2.c:347: error: incompatible type for argument 1 of 'resource_size'
> include/linux/ioport.h:132: note: expected 'const struct resource *' but argument is of type 'struct resource'
>
> Please at least build test this stuff ...
>
> Caused by commit cc7bbfa322b48be82b1c86a104433d4ac349da79 ("Input:
> xilinx_ps2 - use resource_size").
>
> I have reverted that commit for today.
>

Argh, sorry about that. I adjusted the commit; John, Tobias, please
verify (next branch in my tree).

Thanks.

--
Dmitry

2010-01-25 07:26:38

by Tobias Klauser

[permalink] [raw]

Subject: Re: linux-next: input tree build failure

---

On 2010-01-25 at 07:46:03 +0100, Dmitry Torokhov <[email protected]> wrote:
> On Mon, Jan 25, 2010 at 04:52:19PM +1100, Stephen Rothwell wrote:
> > Hi Dmitry,
> >
> > Today's linux-next build (powerpc ppc44x_defconfig) failed like this:
> >
> > drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_probe':
> > drivers/input/serio/xilinx_ps2.c:273: error: incompatible type for argument 1 of 'resource_size'
> > include/linux/ioport.h:132: note: expected 'const struct resource *' but argument is of type 'struct resource'
> > drivers/input/serio/xilinx_ps2.c: In function 'xps2_of_remove':
> > drivers/input/serio/xilinx_ps2.c:347: error: incompatible type for argument 1 of 'resource_size'
> > include/linux/ioport.h:132: note: expected 'const struct resource *' but argument is of type 'struct resource'
> >
> > Please at least build test this stuff ...
> >
> > Caused by commit cc7bbfa322b48be82b1c86a104433d4ac349da79 ("Input:
> > xilinx_ps2 - use resource_size").
> >
> > I have reverted that commit for today.
> >
>
> Argh, sorry about that. I adjusted the commit; John, Tobias, please
> verify (next branch in my tree).

Sorry, that was completely my fault. I didn't have the appropriate build
environment to at least build test it.

The adjusted commit looks fine to me.

Sorry again,
Tobias