2010-01-09 12:05:05

by Roel Kluin

Subject: [PATCH] musb: Test always evaluates to false

The removed part always evaluates to false.

Signed-off-by: Roel Kluin <[email protected]>
---
drivers/usb/musb/musb_gadget.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

Was a different test intended?

diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
index cbcf14a..1a19203 100644
--- a/drivers/usb/musb/musb_gadget.c
+++ b/drivers/usb/musb/musb_gadget.c
@@ -1697,8 +1697,7 @@ int usb_gadget_register_driver(struct usb_gadget_driver *driver)
return -EINVAL;

/* driver must be initialized to support peripheral mode */
- if (!musb || !(musb->board_mode == MUSB_OTG
- || musb->board_mode != MUSB_OTG)) {
+ if (!musb) {
DBG(1, "%s, no dev??\n", __func__);
return -ENODEV;
}

2010-01-29 10:42:16

by Felipe Balbi

Subject: Re: [PATCH] musb: Test always evaluates to false

On Sat, Jan 09, 2010 at 01:09:01PM +0100, ext Roel Kluin wrote:
>The removed part always evaluates to false.
>
>Signed-off-by: Roel Kluin <[email protected]>

Acked-by: Felipe Balbi <[email protected]>

--
balbi